GNU logs - #45816, boring messages

Message sent to bug-guile@HIDDEN:

Subject: bug#45816: (ice-9 suspendable-ports):get-bytevector-some! is broken
Resent-From: d4ryus <d4ryus@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-guile@HIDDEN
Resent-Date: Tue, 12 Jan 2021 15:04:01 +0000
Resent-Message-ID: <handler.45816.B.161046378715215 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 45816 <at> debbugs.gnu.org
Date: Tue, 12 Jan 2021 15:19:05 +0100
From: d4ryus <d4ryus@HIDDEN>
Message-ID: <X/2v2XvE8XuIHwAv@HIDDEN>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="4zG0w5A58Fq5uK3u"
Content-Disposition: inline
Received-SPF: pass client-ip=80.241.56.172; envelope-from=d4ryus@HIDDEN;
 helo=mout-p-202.mailbox.org
X-Spam_score_int: -27
X-Spam_score: -2.8
X-Spam_bar: --
X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
 RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,
 SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -1.3 (-)
X-Mailman-Approved-At: Tue, 12 Jan 2021 10:03:04 -0500
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.3 (--)


--4zG0w5A58Fq5uK3u
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

hi,

(ice-9 suspendable-ports):get-bytevector-some! calls bytevector-copy!
with transfer-size (which is a number) as third argument:

  ...
  (define (get-bytevector-some! port bv start count)
    (if (zero? count)
        0
        (call-with-values (lambda () (fill-input port 1 'binary))
          (lambda (buf cur buffered)
            (if (zero? buffered)
                (begin
                  (set-port-buffer-has-eof?! buf #f)
                  the-eof-object)
                (let ((transfer-size (min count buffered)))
                  (bytevector-copy! (port-buffer-bytevector buf) cur
                                    transfer-size start buffered)
                  (set-port-buffer-cur! buf (+ cur transfer-size))
                  transfer-size))))))
  ...

The third argument to bytevector-copy! must be the target bytevector,
from the doc:

  Scheme Procedure: bytevector-copy! source source-start target target-start len

    Copy len bytes from source into target, starting reading from
    source-start (a positive index within source) and start writing at
    target-start. It is permitted for the source and target regions to
    overlap.

I think the correct call is:

  (bytevector-copy! (port-buffer-bytevector buf) cur
                    bv start transfer-size)


A potentional fix is attached.

If you need any additional information, please let me know.


-  d4ryus

--4zG0w5A58Fq5uK3u
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment;
	filename="suspendable-get-bytevector-some-fix.patch"

diff --git a/module/ice-9/suspendable-ports.scm b/module/ice-9/suspendable-ports.scm
index f5f005cca..a823f1d37 100644
--- a/module/ice-9/suspendable-ports.scm
+++ b/module/ice-9/suspendable-ports.scm
@@ -338,7 +338,7 @@
                 the-eof-object)
               (let ((transfer-size (min count buffered)))
                 (bytevector-copy! (port-buffer-bytevector buf) cur
-                                  transfer-size start buffered)
+                                  bv start transfer-size)
                 (set-port-buffer-cur! buf (+ cur transfer-size))
                 transfer-size))))))


--4zG0w5A58Fq5uK3u--

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: d4ryus <d4ryus@HIDDEN>
Subject: bug#45816: Acknowledgement ((ice-9 suspendable-ports):get-bytevector-some!
 is broken)
Message-ID: <handler.45816.B.161046378715215.ack <at> debbugs.gnu.org>
References: <X/2v2XvE8XuIHwAv@HIDDEN>
X-Gnu-PR-Message: ack 45816
X-Gnu-PR-Package: guile
Reply-To: 45816 <at> debbugs.gnu.org
Date: Tue, 12 Jan 2021 15:04:02 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

Your message has been sent to the package maintainer(s):
 bug-guile@HIDDEN

If you wish to submit further information on this problem, please
send it to 45816 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
45816: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D45816
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Message sent to bug-guile@HIDDEN:

Subject: bug#45816: (ice-9 suspendable-ports):get-bytevector-some! is broken
References: <X/2v2XvE8XuIHwAv@HIDDEN>
In-Reply-To: <X/2v2XvE8XuIHwAv@HIDDEN>
Resent-From: d4ryus <d4ryus@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-guile@HIDDEN
Resent-Date: Thu, 06 May 2021 10:47:01 +0000
Resent-Message-ID: <handler.45816.B45816.16202980107477 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 45816 <at> debbugs.gnu.org
Date: Thu, 6 May 2021 12:46:34 +0200
From: d4ryus <d4ryus@HIDDEN>
Message-ID: <YJPJCvRP+Xm+1cEB@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

Hi,

this was fixed by:

  commit f591ad28f1bcec67f17a123766f798d16bec5373
  Author: Andrew Whatson <whatson@HIDDEN>
  Date:   Fri Jan 22 20:10:10 2021 +1000

    Fix suspendable implementation of 'get-bytevector-some!'

    * module/ice-9/suspendable-ports.scm (get-bytevector-some!): Fix
      incorrect arguments to bytevector-copy!

which was released with guile 3.0.6.

- d4ryus

Last modified: Thu, 6 May 2021 11:00:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.