GNU bug report logs - #45830
Assert, that user and group names are unique -> breaks guix system reconfigure

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 45830 in the body.
You can then email your comments to 45830 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Jonathan Brielmaier <jonathan.brielmaier <at> web.de>
To: bug-guix <at> gnu.org
Cc: leo.prikler <at> student.tugraz.at
Subject: Assert, that user and group names are unique -> breaks guix system
 reconfigure
Date: Wed, 13 Jan 2021 00:03:27 +0100

Hi Leo,

your commit a3002104:
system: Assert, that user and group names are unique.

breaks `guix system reconfigure` for me and other people (at least two
in IRC).

$ guix system reconfigure config.scm
guix system: error: the following groups appear more than once: lp

$ sudo grep lp /etc/group
lp:x:989:

lpadmin:x:975:

$ sudo grep lp /etc/passwd
lp:!:18467::::::

The same happend on my server with the `nginx` group.

I reverted it for the mean time, as I find it pretty grave...

~Jonathan

Message #8 received at 45830 <at> debbugs.gnu.org (full text, mbox):

From: Jonathan Brielmaier <jonathan.brielmaier <at> web.de>
To: 45830 <at> debbugs.gnu.org
Subject: Assert, that user and group names are unique -> breaks guix system
 reconfigure
Date: Wed, 13 Jan 2021 00:18:57 +0100

The original bug with the patch leading to this issue is:
https://issues.guix.gnu.org/45570

Message #11 received at 45830 <at> debbugs.gnu.org (full text, mbox):

From: Leo Prikler <leo.prikler <at> student.tugraz.at>
To: Jonathan Brielmaier <jonathan.brielmaier <at> web.de>
Cc: 45830 <at> debbugs.gnu.org
Subject: Re: Assert, that user and group names are unique -> breaks guix
 system reconfigure
Date: Wed, 13 Jan 2021 00:23:27 +0100

Hi Jonathan,

Am Mittwoch, den 13.01.2021, 00:03 +0100 schrieb Jonathan Brielmaier:
> Hi Leo,
> 
> your commit a3002104:
> system: Assert, that user and group names are unique.
> 
> breaks `guix system reconfigure` for me and other people (at least
> two
> in IRC).
> 
> $ guix system reconfigure config.scm
> guix system: error: the following groups appear more than once: lp
> 
> $ sudo grep lp /etc/group
> lp:x:989:
> 
> lpadmin:x:975:
> 
> $ sudo grep lp /etc/passwd
> lp:!:18467::::::
It would seem you have two or more services adding an lp group then. 
Or one service and a manually defined one.

> The same happend on my server with the `nginx` group.
Same problem here; you're probably adding an nginx group twice in some
way.  This is especially concerning, given that it's groups twice – for
some reason nothing is adding additional users or else that check would
have been triggered first.

> I reverted it for the mean time, as I find it pretty grave...
I would have preferred, if you could instead have demoted it to a
warning.  I understand, that stuff suddenly breaking can be
frustrating, but I doubt the configurations you're using are fine.

> ~Jonathan
Regards,
Leo

Message #16 received at 45830-done <at> debbugs.gnu.org (full text, mbox):

From: Leo Prikler <leo.prikler <at> student.tugraz.at>
To: Jonathan Brielmaier <jonathan.brielmaier <at> web.de>
Cc: 45830-done <at> debbugs.gnu.org
Subject: Re: Assert, that user and group names are unique -> breaks guix
 system reconfigure
Date: Wed, 13 Jan 2021 00:53:10 +0100

Hello again,
Am Mittwoch, den 13.01.2021, 00:23 +0100 schrieb Leo Prikler:
> Hi Jonathan,
> 
> Am Mittwoch, den 13.01.2021, 00:03 +0100 schrieb Jonathan Brielmaier:
> > Hi Leo,
> > 
> > your commit a3002104:
> > system: Assert, that user and group names are unique.
> > 
> > breaks `guix system reconfigure` for me and other people (at least
> > two
> > in IRC).
> > 
> > $ guix system reconfigure config.scm
> > guix system: error: the following groups appear more than once: lp
> > 
> > $ sudo grep lp /etc/group
> > lp:x:989:
> > 
> > lpadmin:x:975:
> > 
> > $ sudo grep lp /etc/passwd
> > lp:!:18467::::::
> It would seem you have two or more services adding an lp group then. 
> Or one service and a manually defined one.
> 
> > The same happend on my server with the `nginx` group.
> Same problem here; you're probably adding an nginx group twice in
> some
> way.  This is especially concerning, given that it's groups twice –
> for
> some reason nothing is adding additional users or else that check
> would
> have been triggered first.
> 
> > I reverted it for the mean time, as I find it pretty grave...
> I would have preferred, if you could instead have demoted it to a
> warning.  I understand, that stuff suddenly breaking can be
> frustrating, but I doubt the configurations you're using are fine.
> 
> > ~Jonathan
> Regards,
> Leo
I've re-applied the patch with errors demoted to warnings.  I hope you
and the other people, who've reported this in IRC will be able to
figure out where the duplicate groups come from.

Regards,
Leo

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.