GNU bug report logs - #45862
[PATCH 0/1] Fix libnode and r-v8

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 45862 in the body.
You can then email your comments to 45862 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: zimoun <zimon.toutoune <at> gmail.com>
To: guix-patches <at> gnu.org
Cc: zimoun <zimon.toutoune <at> gmail.com>
Subject: [PATCH 0/1] Fix libnode and r-v8
Date: Thu, 14 Jan 2021 15:30:54 +0100

Hi,

Commit 1d77141f6d introduces a regression about libnode.  See:

--8<---------------cut here---------------start------------->8---
$ for ci in $(git -C ~/src/guix/guix log --format="%H" 1d77141f6d^^..1d77141f6d) ;\
  do echo "# Commit: $ci" ;\
     guix time-machine --commit=$ci -- build libnode --no-grafts -v 0 ;\
  done

# Commit: 1d77141f6d5004cf10d1f9ead53855f25a973847
Mise à jour du canal « guix » depuis le dépôt Git « https://git.savannah.gnu.org/git/guix.git »...
guix build: error: build of `/gnu/store/yzpk9vr4ipa58vhfqcb66jpwjs808y3n-libnode-10.20.0.drv' failed

# Commit: ac80cbfab69b59d17fcf38ef9f4ce0acc0e5f9e6
Mise à jour du canal « guix » depuis le dépôt Git « https://git.savannah.gnu.org/git/guix.git »...
/gnu/store/7m6nkxcaky1423078mnxa9zkrxyz2c30-libnode-10.20.0
--8<---------------cut here---------------end--------------->8---

The patch fixes it.  The test is done against r-v8 which uses libnode.
Everything builds fine now.


All the best,
simon

zimoun (1):
  gnu: libnode: Fix regression in unused phases.

 gnu/packages/node.scm | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)


base-commit: 88eb5370ec155902ed5fe7636e91e932079b338a
-- 
2.29.2

Message #8 received at 45862 <at> debbugs.gnu.org (full text, mbox):

From: zimoun <zimon.toutoune <at> gmail.com>
To: 45862 <at> debbugs.gnu.org
Cc: rekado <at> elephly.net, zimoun <zimon.toutoune <at> gmail.com>
Subject: [PATCH 1/1] gnu: libnode: Fix regression in unused phases.
Date: Thu, 14 Jan 2021 15:34:29 +0100

Regression introduced in 1d77141f6d5004cf10d1f9ead53855f25a973847.
Reported by Pierre-Antoine Bouttier
<pierre-antoine.bouttier <at> univ-grenoble-alpes.fr>.

* gnu/packages/node.scm (libnode)[arguments]: Delete phase
"patch-node-shebang".
---
 gnu/packages/node.scm | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/node.scm b/gnu/packages/node.scm
index 9e07cd906e..a495f6d763 100644
--- a/gnu/packages/node.scm
+++ b/gnu/packages/node.scm
@@ -8,6 +8,7 @@
 ;;; Copyright © 2018, 2019, 2020 Marius Bakke <mbakke <at> fastmail.com>
 ;;; Copyright © 2020 Pierre Langlois <pierre.langlois <at> gmx.com>
 ;;; Copyright © 2020 Ricardo Wurmus <rekado <at> elephly.net>
+;;; Copyright © 2021 Simon Tournier <zimon.toutoune <at> gmail.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -238,4 +239,5 @@ devices.")
         `(cons* "--shared" "--without-npm" ,flags))
        ((#:phases phases '%standard-phases)
         `(modify-phases ,phases
-           (delete 'patch-npm-shebang)))))))
+           (delete 'patch-npm-shebang)
+           (delete 'patch-node-shebang)))))))
-- 
2.29.2

Message #13 received at 45862-done <at> debbugs.gnu.org (full text, mbox):

From: Ricardo Wurmus <rekado <at> elephly.net>
To: zimoun <zimon.toutoune <at> gmail.com>
Cc: 45862-done <at> debbugs.gnu.org
Subject: Re: [bug#45862] [PATCH 0/1] Fix libnode and r-v8
Date: Wed, 20 Jan 2021 22:35:00 +0100

Hi,

> Commit 1d77141f6d introduces a regression about libnode.  See: […]

Sorry about that!

> The patch fixes it.  The test is done against r-v8 which uses libnode.
> Everything builds fine now.

Indeed!  Applied and pushed with commit 41134f915f.

Thank you!

-- 
Ricardo

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.