GNU bug report logs - #45889
Nextcloud Client

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 45889 in the body.
You can then email your comments to 45889 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Raghav Gururajan <rg <at> raghavgururajan.name>
To: guix-patches <at> gnu.org
Subject: Nextcloud Desktop
Date: Fri, 15 Jan 2021 05:09:31 -0500

[Message part 1 (text/plain, inline)]

Hello Guix!

Please find the attached patch-set to add Nextcloud desktop application 
to guix.

Regards,
RG.

[0001-gnu-Add-appstream.patch (text/x-patch, attachment)]

[0002-gnu-Add-nextcloud-desktop.patch (text/x-patch, attachment)]

Message #8 received at 45889 <at> debbugs.gnu.org (full text, mbox):

From: Raghav Gururajan <rg <at> raghavgururajan.name>
To: 45889 <at> debbugs.gnu.org
Subject: Nextcloud Desktop (v2)
Date: Sat, 16 Jan 2021 01:40:44 -0500

[Message part 1 (text/plain, inline)]

[0001-gnu-Add-appstream.patch (text/x-patch, attachment)]

[0002-gnu-Add-nextcloud-desktop.patch (text/x-patch, attachment)]

Message #11 received at 45889 <at> debbugs.gnu.org (full text, mbox):

From: Raghav Gururajan <rg <at> raghavgururajan.name>
To: 45889 <at> debbugs.gnu.org
Subject: Nextcloud Desktop (v3)
Date: Sat, 16 Jan 2021 03:33:57 -0500

[Message part 1 (text/plain, inline)]

[0001-gnu-Add-appstream.patch (text/x-patch, attachment)]

[0002-gnu-Add-nextcloud-desktop.patch (text/x-patch, attachment)]

Message #14 received at 45889 <at> debbugs.gnu.org (full text, mbox):

From: Raghav Gururajan <rg <at> raghavgururajan.name>
To: 45889 <at> debbugs.gnu.org
Subject: Nextcloud Desktop (v4)
Date: Sat, 16 Jan 2021 05:09:20 -0500

[Message part 1 (text/plain, inline)]

[0001-gnu-Add-appstream.patch (text/x-patch, attachment)]

[0002-gnu-Add-nextcloud-desktop.patch (text/x-patch, attachment)]

Message #17 received at 45889 <at> debbugs.gnu.org (full text, mbox):

From: Nicolò Balzarotti <anothersms <at> gmail.com>
To: Raghav Gururajan <rg <at> raghavgururajan.name>, 45889 <at> debbugs.gnu.org
Subject: Re: [bug#45889] Nextcloud Desktop (v4)
Date: Sat, 16 Jan 2021 11:48:16 +0100

Raghav Gururajan <rg <at> raghavgururajan.name> writes:

Hi!
> Please find the attached patch-set to add Nextcloud desktop application 
> to guix.
I usually don't do patch review, so don't weight too much my comments.

Why is it placed inside a new module?  It should fit nicely in sync.scm

> +         (url "https://github.com/nextcloud/desktop.git")
.git shouldn't be needed

> +        (base32 "1ba9z1kv3wlrmaxsn442vn0inzbd0smvq4xkavarn1h8i0dm62hb"))))
This hash is wrong, I get 022k7b3c30dymrjc1g3ly2cac1c34gkqnvjya6p7w2j3qw2w1dm2

> +             (with-directory-excursion "src/3rdparty"
> +               (for-each delete-file-recursively
> +                         (list
> +                          "libcrashreporter-qt"
> +                          "sqlite3")))
This can be expressed in terms of what you you are keeping instead.

Something along the line of:

(let ((preserved-3rdparty-files
                '("QProgressIndicator" "qtlockedfile" "qtokenizer"
                  "qtsingleapplication" "kmessagewidget")))
           (with-directory-excursion "src/3rdparty"
             (for-each
              (lambda (directory)
                (simple-format #t "deleting: ~A\n" directory)
                (delete-file-recursively directory))
              (lset-difference string=?
                               (scandir ".")
                               (cons* "." ".." preserved-3rdparty-files))))
           #t)

> +         (add-after 'remove-thirdparty 'patch-plugin-dirs
> +           (lambda* (#:key outputs #:allow-other-keys)
> +             (substitute* "shell_integration/libcloudproviders/CMakeLists.txt"
> +               (("PKGCONFIG_GETVAR\\(dbus-1 session_bus_services_dir
> _install_dir\\)")
This line is too long, you can use something like
("PKGCONFIG_GETVAR\\(.*") instead.

> +                "set(_install_dir> \"${CMAKE_INSTALL_PREFIX}/share/dbus-1/services\")"))
Other long line, maybe string-append.

> +             (substitute* "shell_integration/dolphin/CMakeLists.txt"
> +               (("ON CACHE")
> +                "OFF CACHE"))
> +             #t))

Why?

> +         (add-before 'check 'pre-check
> +           (lambda _
> +             (setenv "HOME" (getcwd))
> +             #t))

It's missing a comment on why this is needed (like qttest tries to create
$HOME/.qttest/config/autostart/)
> +    (license license:gpl2+)))

Unbundled dependencies have different licenses
QprogressIndicator is under expat while others lgpl2.1+ if I'm not wrong

Also, I tried removing ruby and python-sphinx from the dependencies and
it did build fine, so be sure all of them are needed (or are they used
for some optional feature?).

Thanks

Message #20 received at 45889 <at> debbugs.gnu.org (full text, mbox):

From: Raghav Gururajan <rg <at> raghavgururajan.name>
To: 45889 <at> debbugs.gnu.org
Subject: Nextcloud Desktop (v5)
Date: Sat, 16 Jan 2021 09:34:11 -0500

[Message part 1 (text/plain, inline)]

[0001-gnu-Add-appstream.patch (text/x-patch, attachment)]

[0002-gnu-Add-nextcloud-desktop.patch (text/x-patch, attachment)]

Message #23 received at 45889 <at> debbugs.gnu.org (full text, mbox):

From: Raghav Gururajan <rg <at> raghavgururajan.name>
To: Nicolò Balzarotti <anothersms <at> gmail.com>,
 45889 <at> debbugs.gnu.org
Subject: Re: [bug#45889] Nextcloud Desktop (v4)
Date: Sat, 16 Jan 2021 09:42:10 -0500

Hi Nicolò!

> Why is it placed inside a new module?  It should fit nicely in sync.scm

Nextcloud is a big project. There will be other packages like server, 
plugins etc., which can then be added to this module. Concept is similar 
to linphone.scm.

> .git shouldn't be needed

Updated in v5.

> This hash is wrong, I get 022k7b3c30dymrjc1g3ly2cac1c34gkqnvjya6p7w2j3qw2w1dm2

Updated in v5.

> Something along the line of:
> 
> (let ((preserved-3rdparty-files
>                  '("QProgressIndicator" "qtlockedfile" "qtokenizer"
>                    "qtsingleapplication" "kmessagewidget")))
>             (with-directory-excursion "src/3rdparty"
>               (for-each
>                (lambda (directory)
>                  (simple-format #t "deleting: ~A\n" directory)
>                  (delete-file-recursively directory))
>                (lset-difference string=?
>                                 (scandir ".")
>                                 (cons* "." ".." preserved-3rdparty-files))))
>             #t)

The snippet didn't work, but I added comments in v5.

> This line is too long, you can use something like
> ("PKGCONFIG_GETVAR\\(.*") instead.

If I use this, it causes parsing error.

> Other long line, maybe string-append.

Ah, I have been advised before not to break lines like this via 
string-append.

> Why?

Added comments in v5.

> It's missing a comment on why this is needed (like qttest tries to create
> $HOME/.qttest/config/autostart/)
>> +    (license license:gpl2+)))

Added comments in v5.

> Unbundled dependencies have different licenses
> QprogressIndicator is under expat while others lgpl2.1+ if I'm not wrong

Updated in v5.

> Also, I tried removing ruby and python-sphinx from the dependencies and
> it did build fine, so be sure all of them are needed (or are they used
> for some optional feature?).

Ruby is for patch-shebangs phase. Sphinx was looked for during configure 
phase, but doesn't seem to do anything, so I removed it in v5.

Thanks so much for the review. :-)

Regards,
RG.

Message #26 received at 45889 <at> debbugs.gnu.org (full text, mbox):

From: Raghav Gururajan <rg <at> raghavgururajan.name>
To: 45889 <at> debbugs.gnu.org
Subject: Nextcloud Client (v6)
Date: Sun, 17 Jan 2021 09:44:14 -0500

[Message part 1 (text/plain, inline)]

[0015-gnu-Add-nextcloud-client.patch (text/x-patch, attachment)]

[0014-gnu-Add-appstream.patch (text/x-patch, attachment)]

Message #31 received at 45889 <at> debbugs.gnu.org (full text, mbox):

From: david larsson <david.larsson <at> selfhosted.xyz>
To: Raghav Gururajan <rg <at> raghavgururajan.name>
Cc: Guix-patches <guix-patches-bounces+david.larsson=selfhosted.xyz <at> gnu.org>,
 45889 <at> debbugs.gnu.org
Subject: Re: [bug#45889] Nextcloud Client (v6)
Date: Sun, 24 Jan 2021 19:45:08 +0100

On 2021-01-17 15:44, Raghav Gururajan wrote:
> 

Hi,

Thank you for working on this! I have tried to package this myself but 
haven't much success beyond being able to login and sync things and to 
receive notifications via libnotify. However, this patch also doesn't 
succeeed in a fully functional nextcloud-desktop, yet - though I hope 
you do succeed!

I tried this out, and started it with --log-window (or similar) and it 
complained about qt-graphical-effect, so I suggest you add it to 
propagated-inputs to have that error go away. And as a general tip - 
start nextcloud-desktop with the log-window flag.

I wish you best of luck in completing it!

Best regards,
David

Message #34 received at 45889 <at> debbugs.gnu.org (full text, mbox):

From: Raghav Gururajan <rg <at> raghavgururajan.name>
To: david larsson <david.larsson <at> selfhosted.xyz>
Cc: Guix-patches <guix-patches-bounces+david.larsson=selfhosted.xyz <at> gnu.org>,
 45889 <at> debbugs.gnu.org
Subject: Re: [bug#45889] Nextcloud Client (v6)
Date: Mon, 1 Feb 2021 10:07:47 -0500

[Message part 1 (text/plain, inline)]

Hi David!

> Thank you for working on this! I have tried to package this myself but 
> haven't much success beyond being able to login and sync things and to 
> receive notifications via libnotify. However, this patch also doesn't 
> succeeed in a fully functional nextcloud-desktop, yet - though I hope 
> you do succeed!

I can confirm that this patch-set is functional. I haven't faced any 
issues. Please let me know which function(s) didn't work for you. I'll 
look into them. :-)

> I tried this out, and started it with --log-window (or similar) and it 
> complained about qt-graphical-effect, so I suggest you add it to 
> propagated-inputs to have that error go away. And as a general tip - 
> start nextcloud-desktop with the log-window flag.

Ah thanks! Yeah, it needed qtgraphicaleffects. Added them in v7. Also, 
the application excepts that the system runs either gnome-keyring or 
kwallet.

Regards,
RG.

[OpenPGP_0x5F5816647F8BE551.asc (application/pgp-keys, attachment)]

[OpenPGP_signature (application/pgp-signature, attachment)]

Message #37 received at 45889 <at> debbugs.gnu.org (full text, mbox):

From: Raghav Gururajan <rg <at> raghavgururajan.name>
To: 45889 <at> debbugs.gnu.org
Subject: Nextcloud Client (v7)
Date: Mon, 1 Feb 2021 10:13:18 -0500

[Message part 1 (text/plain, inline)]

[0001-gnu-Add-appstream.patch (text/x-patch, attachment)]

[0002-gnu-kwayland-Disable-failing-tests.patch (text/x-patch, attachment)]

[0003-gnu-Add-nextcloud-client.patch (text/x-patch, attachment)]

[OpenPGP_0x5F5816647F8BE551.asc (application/pgp-keys, attachment)]

[OpenPGP_signature (application/pgp-signature, attachment)]

Message #40 received at 45889 <at> debbugs.gnu.org (full text, mbox):

From: Leo Prikler <leo.prikler <at> student.tugraz.at>
To: Raghav Gururajan <rg <at> raghavgururajan.name>, 45889 <at> debbugs.gnu.org
Subject: Re: Nextcloud Client (v7)
Date: Tue, 09 Feb 2021 11:22:26 +0100

Hello,

Am Montag, den 01.02.2021, 10:13 -0500 schrieb Raghav Gururajan:
> Subject: [PATCH 1/3] gnu: Add appstream.
Mostly LGTM.

> +    (native-inputs
> +     `(("cmake" ,cmake)
Is cmake really needed?  I know that meson falls back to cmake if pkg-
config fails and also supports output to cmake, but meson/ninja should
be the default.

> Subject: [PATCH 2/3] gnu: kwayland: Disable failing tests.
LGTM, we might want to push that independently.

> +           (let ((keep '( ;; Not available in Guix.
> +                         "QProgressIndicator" "kmessagewidget"
> "qtlockedfile"
> +                         "qtokenizer" "qtsingleapplication")))
Could you try packaging those for Guix as well?

> +       #:imported-modules
> +       (,@%qt-build-system-modules
> +        (guix build glib-or-gtk-build-system))
> +       #:modules
> +       ((guix build qt-build-system)
> +        ((guix build glib-or-gtk-build-system)
> +         #:prefix glib-or-gtk:)
> +        (guix build utils))
As with your telegram patch, I personally think the ordering is wrong
here.

> +               (("PKGCONFIG_GETVAR\\(dbus-1 session_bus_services_dir
> _install_dir\\)")
> +                "set(_install_dir
> \"${CMAKE_INSTALL_PREFIX}/share/dbus-1/services\")"))
You might want to regexp the middle part in case it is changed.

> +             ;; Turn-off the use of absolute Qt paths for
> installation.
> +             (substitute* "shell_integration/dolphin/CMakeLists.txt"
> +               (("ON CACHE")
> +                "OFF CACHE"))
What does this achieve exactly?

Btw. slightly off-topic, but if you're planning to reply to this patch-
set and send v8 at roughly the same time, please collapse it to a
single message as you're already using a "patches as attachments"
style.  Having everything in a single message makes it a little easier
for me to respond and Evolution can save all attachments to a directory
just fine.

Regards,
Leo

Message #43 received at 45889 <at> debbugs.gnu.org (full text, mbox):

From: Leo Prikler <leo.prikler <at> student.tugraz.at>
To: Raghav Gururajan <rg <at> raghavgururajan.name>, 45889 <at> debbugs.gnu.org
Subject: Re: Nextcloud Client (v7)
Date: Tue, 09 Feb 2021 13:53:04 +0100

Am Montag, den 01.02.2021, 10:13 -0500 schrieb Raghav Gururajan:
> Subject: [PATCH 2/3] gnu: kwayland: Disable failing tests.
It seems the test you've disabled is no longer the only failing one.
Upstream kwayland builds by disabling tests altogether, so you can skip
this patch if you don't want to investigate further.  If you do want to
investigate further, I suggest doing those patches separately from
Nextcloud.

> 17/45 Test #17: kwayland-testWindowmanagement ..............Child
> aborted***Exception:   0.17 sec
> qt.qpa.xcb: could not connect to display 
> qt.qpa.plugin: Could not load the Qt platform plugin "xcb" in "" even
> though it was found.
> This application failed to start because no Qt platform plugin could
> be initialized. Reinstalling the application may fix this problem.
> 
> Available platform plugins are: eglfs, linuxfb, minimal, minimalegl,
> offscreen, vnc, xcb, wayland-egl, wayland, wayland-xcomposite-egl,
> wayland-xcomposite-glx.

Regards,
Leo

Message #46 received at 45889 <at> debbugs.gnu.org (full text, mbox):

From: Raghav Gururajan <rg <at> raghavgururajan.name>
To: Leo Prikler <leo.prikler <at> student.tugraz.at>, 45889 <at> debbugs.gnu.org
Subject: Re: Nextcloud Client (v8)
Date: Sat, 13 Feb 2021 15:36:42 -0500

[Message part 1 (text/plain, inline)]

Hi Leo!

> Is cmake really needed?  I know that meson falls back to cmake if pkg-
> config fails and also supports output to cmake, but meson/ninja should
> be the default.

Yes, it is used to generate `.cmake` files inder '[out]/lib/cmake'.

> Could you try packaging those for Guix as well?

They don't have dedicated build scripts.

> As with your telegram patch, I personally think the ordering is wrong
> here.

I changed it in v8.

> You might want to regexp the middle part in case it is changed.

I could use PKGCONFIG_GETVAR\\(.+\\) but that would conflict with other 
PKGCONFIG_GETVAR lines now or in future.

> What does this achieve exactly?

It configures the build-system to install modules in output "out" 
instead of Qt's (input) path.

I have attached v8 with this email.

Regards,
RG.

[0001-gnu-Add-appstream.patch (text/x-patch, attachment)]

[0002-gnu-Add-nextcloud-client.patch (text/x-patch, attachment)]

[OpenPGP_0x5F5816647F8BE551.asc (application/pgp-keys, attachment)]

[OpenPGP_signature (application/pgp-signature, attachment)]

Message #49 received at 45889 <at> debbugs.gnu.org (full text, mbox):

From: Leo Prikler <leo.prikler <at> student.tugraz.at>
To: Raghav Gururajan <rg <at> raghavgururajan.name>, 45889 <at> debbugs.gnu.org
Subject: Re: Nextcloud Client (v8)
Date: Sat, 13 Feb 2021 22:47:11 +0100

Hi Raghav,

Am Samstag, den 13.02.2021, 15:36 -0500 schrieb Raghav Gururajan:
> Hi Leo!
> 
> > Is cmake really needed?  I know that meson falls back to cmake if
> > pkg-
> > config fails and also supports output to cmake, but meson/ninja
> > should
> > be the default.
> 
> Yes, it is used to generate `.cmake` files inder '[out]/lib/cmake'.
Fair enough.

> > Could you try packaging those for Guix as well?
> 
> They don't have dedicated build scripts.
That may be an issue.  You might want to check which of those are
perhaps optional, so that you don't need to pull them in.  For example
it appears you're also deleting libcrashreporter-qt with no
replacement.

kmessagewidget appears to be a part of KDE core.  If anything there is
strictly necessary for building, we should perhaps define a package
variant, that has a slightly patched kmessagewidget.  qtlockedfile and
qtsingleapplication appear to be part of [1], a sort of metapackage,
from which you could spawn multiple descriptions.  For qtokenizer, I am
really not sure.

> > As with your telegram patch, I personally think the ordering is
> > wrong
> > here.
> 
> I changed it in v8.
LGTM.

> > You might want to regexp the middle part in case it is changed.
> 
> I could use PKGCONFIG_GETVAR\\(.+\\) but that would conflict with
> other 
> PKGCONFIG_GETVAR lines now or in future.
Okay, but you can do something like PKGCONFIG_GETVAR\\(.+
_install_dir\\), assuming that such variables should generally only be
bound once.  To be honest, I don't know enough CMake to tell, whether
that is a good idea, however.

> > What does this achieve exactly?
> 
> It configures the build-system to install modules in output "out" 
> instead of Qt's (input) path.
In that case, the comment should probably read something along the
lines of "Make sure, that <X> is installed under $prefix."

Regards,
Leo

[1] https://github.com/qtproject/qt-solutions

Message #52 received at 45889 <at> debbugs.gnu.org (full text, mbox):

From: Raghav Gururajan <rg <at> raghavgururajan.name>
To: Leo Prikler <leo.prikler <at> student.tugraz.at>, 45889 <at> debbugs.gnu.org
Subject: Re: Nextcloud Client (v8)
Date: Sat, 13 Feb 2021 18:54:21 -0500

[Message part 1 (text/plain, inline)]

Hi Leo!

> That may be an issue.  You might want to check which of those are
> perhaps optional, so that you don't need to pull them in.  For example
> it appears you're also deleting libcrashreporter-qt with no
> replacement.

I tried building with each one of them, but build fails without them 
(except libcrashreporter-qt).

> kmessagewidget appears to be a part of KDE core.  If anything there is
> strictly necessary for building, we should perhaps define a package
> variant, that has a slightly patched kmessagewidget.  qtlockedfile and
> qtsingleapplication appear to be part of [1], a sort of metapackage,
> from which you could spawn multiple descriptions.  For qtokenizer, I am
> really not sure.

Thanks for the info. This package doesn't have an option or code to use 
packaged ones.

> Okay, but you can do something like PKGCONFIG_GETVAR\\(.+
> _install_dir\\), assuming that such variables should generally only be
> bound once.  To be honest, I don't know enough CMake to tell, whether
> that is a good idea, however.

Changed in v9.

> In that case, the comment should probably read something along the
> lines of "Make sure, that <X> is installed under $prefix."

Changed in v9.

v9 is attached.

Regards,
RG.

[0001-gnu-Add-appstream.patch (text/x-patch, attachment)]

[0002-gnu-Add-nextcloud-client.patch (text/x-patch, attachment)]

[OpenPGP_signature (application/pgp-signature, attachment)]

Message #55 received at 45889 <at> debbugs.gnu.org (full text, mbox):

From: Raghav Gururajan <rg <at> raghavgururajan.name>
To: Leo Prikler <leo.prikler <at> student.tugraz.at>, 45889 <at> debbugs.gnu.org
Subject: Re: Nextcloud Client (v9)
Date: Sat, 13 Feb 2021 19:47:59 -0500

[Message part 1 (text/plain, inline)]

Hi Leo!

> v9 is attached.

Attached wrong ones there, here are the correct ones.

Regards,
RG.

[0001-gnu-Add-appstream.patch (text/x-patch, attachment)]

[0002-gnu-Add-nextcloud-client.patch (text/x-patch, attachment)]

[OpenPGP_signature (application/pgp-signature, attachment)]

Message #58 received at 45889 <at> debbugs.gnu.org (full text, mbox):

From: Leo Prikler <leo.prikler <at> student.tugraz.at>
To: Raghav Gururajan <rg <at> raghavgururajan.name>, 45889 <at> debbugs.gnu.org
Subject: Re: Nextcloud Client (v8)
Date: Sun, 14 Feb 2021 11:53:07 +0100

Hi Raghav,

Am Samstag, den 13.02.2021, 18:54 -0500 schrieb Raghav Gururajan:
> Hi Leo!
> 
> > That may be an issue.  You might want to check which of those are
> > perhaps optional, so that you don't need to pull them in.  For
> > example
> > it appears you're also deleting libcrashreporter-qt with no
> > replacement.
> 
> I tried building with each one of them, but build fails without them 
> (except libcrashreporter-qt).
Interesting.  Is this due to CMakeLists picking up, that they're
missing and not replacing them with core stuff?

> > kmessagewidget appears to be a part of KDE core.  If anything there
> > is
> > strictly necessary for building, we should perhaps define a package
> > variant, that has a slightly patched kmessagewidget.  qtlockedfile
> > and
> > qtsingleapplication appear to be part of [1], a sort of
> > metapackage,
> > from which you could spawn multiple descriptions.  For qtokenizer,
> > I am
> > really not sure.
> 
> Thanks for the info. This package doesn't have an option or code to
> use packaged ones.
Perhaps you can patch the CMakeLists to add such support? 
Alternatively, you might want to delete them and unpack the upstream
ones to their locations.

> > Okay, but you can do something like PKGCONFIG_GETVAR\\(.+
> > _install_dir\\), assuming that such variables should generally only
> > be
> > bound once.  To be honest, I don't know enough CMake to tell,
> > whether
> > that is a good idea, however.
> 
> Changed in v9.
Note, that you're missing a space here.  This would also match
PKGCONFIG_GETVAR(pkg var foobar_install_dir).

> > In that case, the comment should probably read something along the
> > lines of "Make sure, that <X> is installed under $prefix."
> 
> Changed in v9.
LGTM.

Regards,
Leo

Message #61 received at 45889 <at> debbugs.gnu.org (full text, mbox):

From: Raghav Gururajan <rg <at> raghavgururajan.name>
To: Leo Prikler <leo.prikler <at> student.tugraz.at>, 45889 <at> debbugs.gnu.org
Subject: Re: Nextcloud Client (v10)
Date: Thu, 18 Feb 2021 15:23:30 -0500

[Message part 1 (text/plain, inline)]

Hi Leo!

> Interesting.  Is this due to CMakeLists picking up, that they're
> missing and not replacing them with core stuff?
> 
> Perhaps you can patch the CMakeLists to add such support?
> Alternatively, you might want to delete them and unpack the upstream
> ones to their locations.

I have asked upstream and they are looking into providing options to use 
distribution packages. 
https://github.com/nextcloud/desktop/issues/2929#issuecomment-780548919

So once they update the source in the next-release, I will update the 
package and remove the 3rdparty directory completely. :-)

> Note, that you're missing a space here.  This would also match
> PKGCONFIG_GETVAR(pkg var foobar_install_dir).

Changed in v10.

V10 is attached.

Regards,
RG.

[0001-gnu-Add-appstream.patch (text/x-patch, attachment)]

[0002-gnu-Add-nextcloud-client.patch (text/x-patch, attachment)]

[OpenPGP_signature (application/pgp-signature, attachment)]

Message #64 received at 45889 <at> debbugs.gnu.org (full text, mbox):

From: Leo Prikler <leo.prikler <at> student.tugraz.at>
To: Raghav Gururajan <rg <at> raghavgururajan.name>, 45889 <at> debbugs.gnu.org
Subject: Re: Nextcloud Client (v10)
Date: Thu, 18 Feb 2021 23:26:30 +0100

Hi Raghav!

Am Donnerstag, den 18.02.2021, 15:23 -0500 schrieb Raghav Gururajan:
> Hi Leo!
> 
> > Interesting.  Is this due to CMakeLists picking up, that they're
> > missing and not replacing them with core stuff?
> > 
> > Perhaps you can patch the CMakeLists to add such support?
> > Alternatively, you might want to delete them and unpack the
> > upstream
> > ones to their locations.
> 
> I have asked upstream and they are looking into providing options to
> use 
> distribution packages. 
> https://github.com/nextcloud/desktop/issues/2929#issuecomment-780548919
Good to know.

> So once they update the source in the next-release, I will update
> the 
> package and remove the 3rdparty directory completely. :-)
In the meantime, would you mind packaging those 3rdparty sources from
their respective origins and add them in at build time?  That way, all
we'd need to transition from pseudo-unbundled to actually unbundled
would be to drop one phase.

> > Note, that you're missing a space here.  This would also match
> > PKGCONFIG_GETVAR(pkg var foobar_install_dir).
> 
> Changed in v10.
LGTM.

Regards,
Leo

Message #67 received at 45889 <at> debbugs.gnu.org (full text, mbox):

From: Raghav Gururajan <rg <at> raghavgururajan.name>
To: Leo Prikler <leo.prikler <at> student.tugraz.at>, 45889 <at> debbugs.gnu.org
Subject: Re: Nextcloud Client (v10)
Date: Sun, 21 Feb 2021 12:04:27 -0500

[Message part 1 (text/plain, inline)]

Hi Leo!

> In the meantime, would you mind packaging those 3rdparty sources from
> their respective origins and add them in at build time?  That way, all
> we'd need to transition from pseudo-unbundled to actually unbundled
> would be to drop one phase.

I was about to start doing it via 'copy-inputs, then noticed the source 
content differs with the ones at QtSolutions. The files of 
QtSingleApplication and QtLockedFile at QtSolutions were not modified 
for many years, whereas, the files of QtSingleApplication and 
QtLockedFile at nextcloud was last modified in 2020.

Regards,
RG.

[OpenPGP_signature (application/pgp-signature, attachment)]

Message #70 received at 45889 <at> debbugs.gnu.org (full text, mbox):

From: Leo Prikler <leo.prikler <at> student.tugraz.at>
To: Raghav Gururajan <rg <at> raghavgururajan.name>, 45889 <at> debbugs.gnu.org
Subject: Re: Nextcloud Client (v10)
Date: Sun, 21 Feb 2021 18:45:43 +0100

Hi Raghav,

Am Sonntag, den 21.02.2021, 12:04 -0500 schrieb Raghav Gururajan:
> Hi Leo!
> 
> > In the meantime, would you mind packaging those 3rdparty sources
> > from
> > their respective origins and add them in at build time?  That way,
> > all
> > we'd need to transition from pseudo-unbundled to actually unbundled
> > would be to drop one phase.
> 
> I was about to start doing it via 'copy-inputs, then noticed the
> source 
> content differs with the ones at QtSolutions. The files of 
> QtSingleApplication and QtLockedFile at QtSolutions were not
> modified 
> for many years, whereas, the files of QtSingleApplication and 
> QtLockedFile at nextcloud was last modified in 2020.
Looking at QtSingleApplication, the changes made by Nextcloud seem
rather cosmetic, so packaging the upstream version, which also had
"cosmetic" changes to it since their shared ancestor should not be an
issue.

Regards,
Leo

Message #73 received at 45889 <at> debbugs.gnu.org (full text, mbox):

From: Raghav Gururajan <rg <at> raghavgururajan.name>
To: Leo Prikler <leo.prikler <at> student.tugraz.at>, 45889 <at> debbugs.gnu.org
Subject: Re: Nextcloud Client (v11)
Date: Sun, 21 Feb 2021 13:09:12 -0500

[Message part 1 (text/plain, inline)]

Hi Leo!

> Looking at QtSingleApplication, the changes made by Nextcloud seem
> rather cosmetic, so packaging the upstream version, which also had
> "cosmetic" changes to it since their shared ancestor should not be an
> issue.

Ah Cool!

I have attached v11.

Regards,
RG.

[0002-gnu-Add-appstream.patch (text/x-patch, attachment)]

[0003-gnu-Add-nextcloud-client.patch (text/x-patch, attachment)]

[OpenPGP_signature (application/pgp-signature, attachment)]

Message #76 received at 45889 <at> debbugs.gnu.org (full text, mbox):

From: Leo Prikler <leo.prikler <at> student.tugraz.at>
To: Raghav Gururajan <rg <at> raghavgururajan.name>, 45889 <at> debbugs.gnu.org
Subject: Re: Nextcloud Client (v11)
Date: Sun, 21 Feb 2021 19:22:27 +0100

Hi Raghav,

Am Sonntag, den 21.02.2021, 13:09 -0500 schrieb Raghav Gururajan:
> Hi Leo!
> 
> > Looking at QtSingleApplication, the changes made by Nextcloud seem
> > rather cosmetic, so packaging the upstream version, which also had
> > "cosmetic" changes to it since their shared ancestor should not be
> > an
> > issue.
> 
> Ah Cool!
Just in case I've been unclear, "upstream" here means "not bundled".

> I have attached v11.
Did you by chance mess up the patch numbering?

> +(define-module (gnu packages nextcloud)
I just now noticed, that this would be a good fit for sync, which
already hosts owncloud-client.

> +    (version "3.1.2")
For the record, upstream updated to 3.1.3 three days ago.  Time flies.

Regards,
Leo

Message #79 received at 45889 <at> debbugs.gnu.org (full text, mbox):

From: Raghav Gururajan <rg <at> raghavgururajan.name>
To: Leo Prikler <leo.prikler <at> student.tugraz.at>, 45889 <at> debbugs.gnu.org
Subject: Re: Nextcloud Client (v11)
Date: Sun, 21 Feb 2021 13:22:29 -0500

[Message part 1 (text/plain, inline)]

Hi Leo!

> I have attached v11.

Ignore v11. The build fails. There are missing classes in the 
QtSolutions source. So v10 is the viable patch-set.

Regards,
RG.

[OpenPGP_0x5F5816647F8BE551.asc (application/pgp-keys, attachment)]

[OpenPGP_signature (application/pgp-signature, attachment)]

Message #82 received at 45889 <at> debbugs.gnu.org (full text, mbox):

From: Raghav Gururajan <rg <at> raghavgururajan.name>
To: Leo Prikler <leo.prikler <at> student.tugraz.at>, 45889 <at> debbugs.gnu.org
Subject: Re: Nextcloud Client (v12)
Date: Sun, 21 Feb 2021 13:50:47 -0500

[Message part 1 (text/plain, inline)]

Hi Leo!

>> +(define-module (gnu packages nextcloud)
> I just now noticed, that this would be a good fit for sync, which
> already hosts owncloud-client.

This new module is for nextcloud suite of packages. nextcloud-client, 
nextcloud-server, nextcloud-spreed, nextcloud-deck, nextcloud-news ... 
nextcloud-foobar.

>> +    (version "3.1.2")
> For the record, upstream updated to 3.1.3 three days ago.  Time flies.

Wow! Okay, I have made v12.

Regards,
RG.

[0001-gnu-Add-appstream.patch (text/x-patch, attachment)]

[0002-gnu-Add-nextcloud-client.patch (text/x-patch, attachment)]

[OpenPGP_signature (application/pgp-signature, attachment)]

Message #85 received at 45889 <at> debbugs.gnu.org (full text, mbox):

From: Leo Prikler <leo.prikler <at> student.tugraz.at>
To: Raghav Gururajan <rg <at> raghavgururajan.name>, 45889 <at> debbugs.gnu.org
Subject: Re: Nextcloud Client (v12)
Date: Sun, 21 Feb 2021 20:37:02 +0100

Am Sonntag, den 21.02.2021, 13:50 -0500 schrieb Raghav Gururajan:
> Hi Leo!
> 
> > > +(define-module (gnu packages nextcloud)
> > I just now noticed, that this would be a good fit for sync, which
> > already hosts owncloud-client.
> 
> This new module is for nextcloud suite of packages. nextcloud-
> client, 
> nextcloud-server, nextcloud-spreed, nextcloud-deck, nextcloud-news
> ... 
> nextcloud-foobar.
Still seems pretty sync to me, especially since it's just the client
for now.

> There are missing classes in the QtSolutions source.
(X) Doubt

It appears the Nextcloud variant has an added namespace layer, that one
should easily be able to strip via substitute*.  I do wonder where that
comes from, though, it seems to have been there "forever".

Regards,
Leo

Message #88 received at 45889 <at> debbugs.gnu.org (full text, mbox):

From: Raghav Gururajan <rg <at> raghavgururajan.name>
To: Leo Prikler <leo.prikler <at> student.tugraz.at>, 45889 <at> debbugs.gnu.org
Subject: Re: Nextcloud Client (v13)
Date: Mon, 22 Feb 2021 12:29:13 -0500

[Message part 1 (text/plain, inline)]

Hi Leo!

> Still seems pretty sync to me, especially since it's just the client
> for now.

Circular-dependency when putting it in sync.scm. So we'll keep it as is 
I guess.

> (X) Doubt
> 
> It appears the Nextcloud variant has an added namespace layer, that one
> should easily be able to strip via substitute*.  I do wonder where that
> comes from, though, it seems to have been there "forever".

No idea! Thanks for fixing the build errors.

Also, I cannot package them separately because the build script is not 
viable. No libraries gets built, except for .o files. Also, INSTALL.txt 
deals with Windows and MacOS.

I have attached v13.

Regards,
RG.

[0001-gnu-Add-appstream.patch (text/x-patch, attachment)]

[0002-gnu-Add-nextcloud-client.patch (text/x-patch, attachment)]

[OpenPGP_signature (application/pgp-signature, attachment)]

Message #91 received at 45889 <at> debbugs.gnu.org (full text, mbox):

From: Raghav Gururajan <rg <at> raghavgururajan.name>
To: Leo Prikler <leo.prikler <at> student.tugraz.at>, 45889 <at> debbugs.gnu.org
Subject: Re: Nextcloud Client (v14)
Date: Tue, 23 Feb 2021 09:27:04 -0500

[Message part 1 (text/plain, inline)]

[0001-gnu-Add-appstream.patch (text/x-patch, attachment)]

[0002-gnu-Add-nextcloud-client.patch (text/x-patch, attachment)]

[OpenPGP_signature (application/pgp-signature, attachment)]

Message #94 received at 45889 <at> debbugs.gnu.org (full text, mbox):

From: Leo Prikler <leo.prikler <at> student.tugraz.at>
To: Raghav Gururajan <rg <at> raghavgururajan.name>, 45889 <at> debbugs.gnu.org
Subject: Re: Nextcloud Client (v14)
Date: Tue, 23 Feb 2021 18:58:48 +0100

Hi Raghav,

Am Dienstag, den 23.02.2021, 09:27 -0500 schrieb Raghav Gururajan:
> +             (let* ((qtsolutions (assoc-ref inputs "qtsolutions")))
> +               (for-each
> +                (lambda (dir)
> +                  (copy-recursively
> +                   (string-append qtsolutions "/" dir "/src")
> +                   (string-append "src/3rdparty/" dir)))
> +                '("qtlockedfile" "qtsingleapplication")))
> +             (with-directory-excursion "src/gui"
> +               (substitute* `("application.h" "application.cpp")
> +                 (("SharedTools::QtSingleApplication")
> "QtSingleApplication")
> +                 (("slotParseMessage\\(const QString &(msg)?.*\\)")
> +                  "slotParseMessage(const QString &msg)")))
Being the one who helped review this, I of course know, what it does,
but others might not, so this probably deserves a (short) comment.

> +       ("qtsolutions"
> +        ,(origin
> +           (method git-fetch)
> +           (uri
> +            (git-reference
> +             (url "https://github.com/qtproject/qt-solutions")
> +             (commit "9568abd142d581b67b86a5f63d823a34b0612702")))
> +           (file-name
> +            (git-file-name "qtsolutions" "9568abd"))
> +           (sha256
> +            (base32
> "17fnmassflm3vxi0krpr6fff368jy38cby31a48rban4nqqmgx7n"))))
I'm still not convinced, that this can't be made a package or perhaps
multiple packages, one per "solution".  Each of the folder seems to
contain a project file, which to be fair do have some non-Unix-related
install declarations, but it should at least install a statically
linked package *somewhere*.  We can go from there.

Alternatively, as I see this as a source, that will get copied around
in the same way I copied libgd from gedit, you can at least extract the
origin into a function in qt.scm, potentially named qt-solutions.

Regards,
Leo

Message #97 received at 45889 <at> debbugs.gnu.org (full text, mbox):

From: Raghav Gururajan <rg <at> raghavgururajan.name>
To: Leo Prikler <leo.prikler <at> student.tugraz.at>, 45889 <at> debbugs.gnu.org
Subject: Re: Nextcloud Client (v15)
Date: Tue, 9 Mar 2021 01:00:57 -0500

[Message part 1 (text/plain, inline)]

Hi Leo!

> I'm still not convinced, that this can't be made a package or perhaps
> multiple packages, one per "solution".  Each of the folder seems to
> contain a project file, which to be fair do have some non-Unix-related
> install declarations, but it should at least install a statically
> linked package *somewhere*.  We can go from there.
> 
> Alternatively, as I see this as a source, that will get copied around
> in the same way I copied libgd from gedit, you can at least extract the
> origin into a function in qt.scm, potentially named qt-solutions.


In attached v15, I have:

[1] Packaged QtSolutions.
[2] Removed QtLockedFile, QtSingleApplication, and KMessageWidget from 
3rdparty.
[3] Patched the source to use KMessageWidget from KWidgetsAddons, and, 
to use QtLockedFile and QtSingleApplication from QtSolutions.

\o/

Regards,
RG.

[0001-gnu-Add-appstream.patch (text/x-patch, attachment)]

[0002-gnu-Add-qtsolutions.patch (text/x-patch, attachment)]

[0003-gnu-Add-nextcloud-client.patch (text/x-patch, attachment)]

[OpenPGP_signature (application/pgp-signature, attachment)]

Message #100 received at 45889 <at> debbugs.gnu.org (full text, mbox):

From: Leo Prikler <leo.prikler <at> student.tugraz.at>
To: Raghav Gururajan <rg <at> raghavgururajan.name>, 45889 <at> debbugs.gnu.org
Subject: Re: Nextcloud Client (v15)
Date: Tue, 09 Mar 2021 08:03:08 +0100

Hi Raghav,

> Subject: [PATCH 2/3] gnu: Add qtsolutions.
> +      (version
> +       (git-version "0" revision commit))

> +         (file-name
> +          (git-file-name name version))

> +                 (("qt5")
> +                  "qt")

> +                 (("-head")
> +                  "")

> +                 (("SUBDIRS\\+=examples")
> +                  ""))
Try not to arbitrarily use too many new lines.  If you break Scheme
code in such a manner for no good reason, it will look odd.

> +                 (("toAscii")
> +                  "toLatin1"))
Why not to UTF-8?  Is the input already UTF-8 and we want to convert it
to a single-byte character set?

> +                 (("\\$\\$PWD")
> +                  (assoc-ref outputs "out")))
You should install the shared libraries in the install phase.

> +                         (list
> +                          "qtlockedfile"
> +                          "qtpropertybrowser"
> +                          "qtservice"
> +                          "qtsingleapplication"
> +                          "qtsoap")
Use '(...) for fixed input.

> Subject: [PATCH 3/3] gnu: Add nextcloud-client.
> +         (commit
> +          (string-append "v" version)))

> +                 (("    \\.\\./3rdparty/qtlockedfile/?.*")
> +                  "")
> +                 (("    \\.\\./3rdparty/qtsingleapplication/?.*")
> +                  "")
> +                 (("    \\.\\./3rdparty/kmessagewidget/?.*")
> +                  "")
> +                 (("   list\\(APPEND 3rdparty_SRC
> \\.\\./3rdparty/?.*\\)")
> +                  "")
I'm starting to grow a little suspicious about matching the leading
spaces.  You probably want to lead this (and similar stuff in 0001)
with [ \t]*.

> +                 (("\\$\\{CMAKE_SOURCE_DIR\\}/src/3rdparty/qtlockedf
> ile")
> +                  (string-append (assoc-ref inputs "qtsolutions")
> +                                 "/include/qtlockedfile/"))
> +                 (("\\$\\{CMAKE_SOURCE_DIR\\}/src/3rdparty/qtsinglea
> pplication")
> +                  (string-append (assoc-ref inputs "qtsolutions")
> +                                 "/include/qtsingleapplication/"))
> +                 (("\\$\\{CMAKE_SOURCE_DIR\\}/src/3rdparty/kmessagew
> idget")
> +                  (string-append (assoc-ref inputs "kwidgetsaddons")
> +                                 "/include/KF5/KWidgetsAddons/"))
LGTM, but probably deserves a comment.
Also, you might skip the stuff leading up to /3rdparty, i.e. have
".*/3rdparty/qtlockedfile", etc.  Perhaps this gives you enough wiggle
room to do lockedfile and single application on the same line, but it
doesn't hurt if it doesn't.

> +                 (("\\$\\{synclib_NAME\\}")
> +                  (string-append "${synclib_NAME} "
> +                                 "QtSolutions_LockedFile "
> +                                 "QtSolutions_SingleApplication "
> +                                 "KF5WidgetsAddons")))
Definitely deserves a comment and perhaps a less broad match?

> +               (substitute* '("application.h" "application.cpp")
> +                 (("SharedTools::QtSingleApplication")
> +                  "QtSingleApplication")
> +                 (("slotParseMessage\\(const QString &(msg)?.*\\)")
> +                  "slotParseMessage(const QString &msg)")))
Also deserves a comment about QtSingleApplication differences.

> +                (string-append "set(_install_dir
> \"${CMAKE_INSTALL_PREFIX}"
> +                               "/share/dbus-1/services\")")))
Would the raw string here exceed a line?

> +      ;; All ThirdParty (except QtProgressIndicator)
> +      license:lgpl2.1+
This is now just qtokenizer, right?

Regards,
Leo

Message #103 received at 45889 <at> debbugs.gnu.org (full text, mbox):

From: Raghav Gururajan <rg <at> raghavgururajan.name>
To: Leo Prikler <leo.prikler <at> student.tugraz.at>, 45889 <at> debbugs.gnu.org
Subject: Re: Nextcloud Client (v16)
Date: Tue, 9 Mar 2021 05:50:43 -0500

[Message part 1 (text/plain, inline)]

Hi Leo!

> Try not to arbitrarily use too many new lines.  If you break Scheme
> code in such a manner for no good reason, it will look odd.

Done.

> Why not to UTF-8?

Done.

> You should install the shared libraries in the install phase.

Done.

> Use '(...) for fixed input.

Done.

> I'm starting to grow a little suspicious about matching the leading
> spaces.  You probably want to lead this (and similar stuff in 0001)
> with [ \t]*.

Done.

> LGTM, but probably deserves a comment.

Done.

> Definitely deserves a comment and perhaps a less broad match?

Done the comment.

I think this is perfect match. The mentioned libraries will get linked 
wherever synclib gets linked. Also, this patch is compatible with 
current master, which is different from this version.

> Also deserves a comment about QtSingleApplication differences.

Done.

> Would the raw string here exceed a line?

Yep!

> This is now just qtokenizer, right?

Changed.

Please find the attached v16.

Regards,
RG.

[0001-gnu-Add-appstream.patch (text/x-patch, attachment)]

[0002-gnu-Add-qtsolutions.patch (text/x-patch, attachment)]

[0003-gnu-Add-nextcloud-client.patch (text/x-patch, attachment)]

[OpenPGP_signature (application/pgp-signature, attachment)]

Message #106 received at 45889 <at> debbugs.gnu.org (full text, mbox):

From: Leo Prikler <leo.prikler <at> student.tugraz.at>
To: Raghav Gururajan <rg <at> raghavgururajan.name>, 45889 <at> debbugs.gnu.org
Subject: Re: Nextcloud Client (v16)
Date: Tue, 09 Mar 2021 12:39:01 +0100

Hi Raghav,

Mostly LGTM.

Am Dienstag, den 09.03.2021, 05:50 -0500 schrieb Raghav Gururajan:
> > Definitely deserves a comment and perhaps a less broad match?
> 
> Done the comment.
> 
> I think this is perfect match. The mentioned libraries will get
> linked 
> wherever synclib gets linked. Also, this patch is compatible with 
> current master, which is different from this version.
Perhaps the comment should reflect that a little better.  You might
also want to expand that during the unvendoring in the snippet, so that
it's less confusing.

> +                                    `(("src" ,(string-append
> "include/" solution)
> +                                       #:include-regexp ("\\.h$"))
I think you should unvendor dependencies between the solutions, so that
you can put them in "include/" directly (like putting the solutions in
"/lib").

Regards,
Leo

Message #109 received at 45889 <at> debbugs.gnu.org (full text, mbox):

From: Raghav Gururajan <rg <at> raghavgururajan.name>
To: Leo Prikler <leo.prikler <at> student.tugraz.at>, 45889 <at> debbugs.gnu.org
Subject: Re: Nextcloud Client (v16)
Date: Tue, 9 Mar 2021 07:29:05 -0500

[Message part 1 (text/plain, inline)]

Hi Leo!

> Perhaps the comment should reflect that a little better.  You might
> also want to expand that during the unvendoring in the snippet, so that
> it's less confusing.

Done.

> I think you should unvendor dependencies between the solutions, so that
> you can put them in "include/" directly (like putting the solutions in
> "/lib").

Done.

Please find the attached v17.

Regards,
RG.

[0001-gnu-Add-appstream.patch (text/x-patch, attachment)]

[0002-gnu-Add-qtsolutions.patch (text/x-patch, attachment)]

[0003-gnu-Add-nextcloud-client.patch (text/x-patch, attachment)]

[OpenPGP_signature (application/pgp-signature, attachment)]

Message #112 received at 45889 <at> debbugs.gnu.org (full text, mbox):

From: Leo Prikler <leo.prikler <at> student.tugraz.at>
To: Raghav Gururajan <rg <at> raghavgururajan.name>, 45889 <at> debbugs.gnu.org
Subject: Re: Nextcloud Client (v17)
Date: Tue, 09 Mar 2021 13:43:36 +0100

Am Dienstag, den 09.03.2021, 07:29 -0500 schrieb Raghav Gururajan:
> Hi Leo!
> 
> > Perhaps the comment should reflect that a little better.  You might
> > also want to expand that during the unvendoring in the snippet, so
> > that
> > it's less confusing.
> 
> Done.
The comment certainly improved FSVO improved, but it somehow does not
reduce my bikeshedding mood.  In particular, I feel like we ought to do
this in the snippet.

> > I think you should unvendor dependencies between the solutions, so
> > that
> > you can put them in "include/" directly (like putting the solutions
> > in
> > "/lib").
> 
> Done.
You just masked an install error without actually unvendoring
dependencies.

Regards,
Leo

Message #115 received at 45889 <at> debbugs.gnu.org (full text, mbox):

From: Raghav Gururajan <rg <at> raghavgururajan.name>
To: Leo Prikler <leo.prikler <at> student.tugraz.at>, 45889 <at> debbugs.gnu.org
Subject: Re: Nextcloud Client (v18)
Date: Tue, 9 Mar 2021 10:16:17 -0500

[Message part 1 (text/plain, inline)]

Hi Leo!

> The comment certainly improved FSVO improved, but it somehow does not
> reduce my bikeshedding mood.  In particular, I feel like we ought to do
> this in the snippet.

Moved to snippet.

> You just masked an install error without actually unvendoring
> dependencies.

Done.

Please find the attached v18.

Regards,
RG.

[0001-gnu-Add-appstream.patch (text/x-patch, attachment)]

[0002-gnu-Add-qtsolutions.patch (text/x-patch, attachment)]

[0003-gnu-Add-nextcloud-client.patch (text/x-patch, attachment)]

[OpenPGP_signature (application/pgp-signature, attachment)]

Message #120 received at 45889-done <at> debbugs.gnu.org (full text, mbox):

From: Leo Prikler <leo.prikler <at> student.tugraz.at>
To: Raghav Gururajan <rg <at> raghavgururajan.name>, 45889-done <at> debbugs.gnu.org
Subject: Re: Nextcloud Client (v18)
Date: Wed, 10 Mar 2021 00:24:09 +0100

Am Dienstag, den 09.03.2021, 10:16 -0500 schrieb Raghav Gururajan:
> Hi Leo!
> 
> > The comment certainly improved FSVO improved, but it somehow does
> > not
> > reduce my bikeshedding mood.  In particular, I feel like we ought
> > to do
> > this in the snippet.
> 
> Moved to snippet.
> 
> > You just masked an install error without actually unvendoring
> > dependencies.
> 
> Done.
> 
> Please find the attached v18.
I've applied some cosmetic and less cosmetic changes, reviewed the
licenses and pushed nextcloud as
82a2f182c59cd9adef4991e0adfb575fec95e52d.

Regards,
Leo

Message #123 received at 45889-done <at> debbugs.gnu.org (full text, mbox):

From: Raghav Gururajan <rg <at> raghavgururajan.name>
To: Leo Prikler <leo.prikler <at> student.tugraz.at>, 45889-done <at> debbugs.gnu.org
Subject: Re: Nextcloud Client (v18)
Date: Tue, 9 Mar 2021 22:46:53 -0500

[Message part 1 (text/plain, inline)]

Hi Leo!

>> Please find the attached v18.
> I've applied some cosmetic and less cosmetic changes, reviewed the
> licenses and pushed nextcloud as
> 82a2f182c59cd9adef4991e0adfb575fec95e52d.

Thanks so much for helping me with every step of the way. I appreciate 
it. :-)

Regards,
RG.

[OpenPGP_signature (application/pgp-signature, attachment)]

Message #126 received at 45889 <at> debbugs.gnu.org (full text, mbox):

From: Raghav Gururajan <rg <at> raghavgururajan.name>
To: Leo Prikler <leo.prikler <at> student.tugraz.at>, 45889 <at> debbugs.gnu.org
Subject: Re: Nextcloud Client (v18)
Date: Thu, 11 Mar 2021 01:45:06 -0500

[Message part 1 (text/plain, inline)]

Hi Leo!

>>> Please find the attached v18.
>> I've applied some cosmetic and less cosmetic changes, reviewed the
>> licenses and pushed nextcloud as
>> 82a2f182c59cd9adef4991e0adfb575fec95e52d.
> 
> Thanks so much for helping me with every step of the way. I appreciate 
> it. :-)

I have named the package wrong. Could you please merge the attached 
patch please?

Thank you!

Regards,
RG.

[0001-gnu-Rename-nextcloud-client-to-nextcloud-desktop.patch (text/x-patch, attachment)]

[OpenPGP_signature (application/pgp-signature, attachment)]

Message #129 received at 45889 <at> debbugs.gnu.org (full text, mbox):

From: Leo Prikler <leo.prikler <at> student.tugraz.at>
To: Raghav Gururajan <rg <at> raghavgururajan.name>, 45889 <at> debbugs.gnu.org
Subject: Re: Nextcloud Client (v18)
Date: Thu, 11 Mar 2021 07:49:31 +0100

Am Donnerstag, den 11.03.2021, 01:45 -0500 schrieb Raghav Gururajan:
> Hi Leo!
> 
> > > > Please find the attached v18.
> > > I've applied some cosmetic and less cosmetic changes, reviewed
> > > the
> > > licenses and pushed nextcloud as
> > > 82a2f182c59cd9adef4991e0adfb575fec95e52d.
> > 
> > Thanks so much for helping me with every step of the way. I
> > appreciate 
> > it. :-)
> 
> I have named the package wrong. Could you please merge the attached 
> patch please?
I don't see the name "nextcloud-client" as particularly problematic. 
It follows the same scheme as owncloud-client, which it is a fork of
IIUC.  What would be the reason to prefer nextcloud-desktop?

Regards,
Leo

Message #132 received at 45889 <at> debbugs.gnu.org (full text, mbox):

From: Raghav Gururajan <rg <at> raghavgururajan.name>
To: Leo Prikler <leo.prikler <at> student.tugraz.at>, 45889 <at> debbugs.gnu.org
Subject: Re: Nextcloud Client (v18)
Date: Thu, 11 Mar 2021 02:44:57 -0500

[Message part 1 (text/plain, inline)]

Hi Leo!

> I don't see the name "nextcloud-client" as particularly problematic.
> It follows the same scheme as owncloud-client, which it is a fork of
> IIUC.  What would be the reason to prefer nextcloud-desktop?

The upstream uses the name 'desktop' (nextcloud/desktop in contrast to 
owncloud/client).

Also, It will be distinct from nextcloud-cli, if we get one in guix.

Regards,
RG.

[OpenPGP_signature (application/pgp-signature, attachment)]

Message #135 received at 45889 <at> debbugs.gnu.org (full text, mbox):

From: david larsson <david.larsson <at> selfhosted.xyz>
To: 45889 <at> debbugs.gnu.org, leo.prikler <at> student.tugraz.at,
 rg <at> raghavgururajan.name
Cc: Guix-patches <guix-patches-bounces+david.larsson=selfhosted.xyz <at> gnu.org>,
 45889-done <at> debbugs.gnu.org
Subject: Re: bug#45889: Nextcloud Client (v18)
Date: Fri, 12 Mar 2021 10:25:26 +0100

On 2021-03-10 00:24, Leo Prikler wrote:
> Am Dienstag, den 09.03.2021, 10:16 -0500 schrieb Raghav Gururajan:
>> Hi Leo!
>> 
>> > The comment certainly improved FSVO improved, but it somehow does
>> > not
>> > reduce my bikeshedding mood.  In particular, I feel like we ought
>> > to do
>> > this in the snippet.
>> 
>> Moved to snippet.
>> 
>> > You just masked an install error without actually unvendoring
>> > dependencies.
>> 
>> Done.
>> 
>> Please find the attached v18.
> I've applied some cosmetic and less cosmetic changes, reviewed the
> licenses and pushed nextcloud as
> 82a2f182c59cd9adef4991e0adfb575fec95e52d.
> 
> Regards,
> Leo

This is great news! I have really been looking forward to this. Thank 
you both for almost 3 months of great work on this!

Best regards,
David

Message #141 received at 45889 <at> debbugs.gnu.org (full text, mbox):

From: Raghav Gururajan <rg <at> raghavgururajan.name>
To: david larsson <david.larsson <at> selfhosted.xyz>, 45889 <at> debbugs.gnu.org,
 leo.prikler <at> student.tugraz.at
Cc: Guix-patches <guix-patches-bounces+david.larsson=selfhosted.xyz <at> gnu.org>,
 45889-done <at> debbugs.gnu.org
Subject: Re: bug#45889: Nextcloud Client (v18)
Date: Fri, 12 Mar 2021 04:47:36 -0500

[Message part 1 (text/plain, inline)]

Hi David!

> This is great news! I have really been looking forward to this. Thank 
> you both for almost 3 months of great work on this!

:-)

It's in, https://guix.gnu.org/en/packages/nextcloud-client-3.1.3/

Regards,
RG.

[OpenPGP_signature (application/pgp-signature, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.