GNU bug report logs - #45960
[PATCH] gnu: Add obs-spectralizer.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 45960 in the body.
You can then email your comments to 45960 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Andrew Tropin <andrew <at> trop.in>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: Add obs-spectralizer.
Date: Mon, 18 Jan 2021 19:57:13 +0300

[Message part 1 (text/plain, inline)]

[0001-gnu-Add-obs-spectralizer.patch (text/x-patch, attachment)]

Message #10 received at 45960-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Andrew Tropin <andrew <at> trop.in>
Cc: 45960-done <at> debbugs.gnu.org
Subject: Re: bug#45960: [PATCH] gnu: Add obs-spectralizer.
Date: Tue, 02 Feb 2021 10:34:09 +0100

Hi,

Andrew Tropin <andrew <at> trop.in> skribis:

> From cf3a2cf54a17e131dcd57a1fb280d3586521c500 Mon Sep 17 00:00:00 2001
> From: Andrew Tropin <andrew <at> trop.in>
> Date: Mon, 18 Jan 2021 19:39:44 +0300
> Subject: [PATCH] gnu: Add obs-spectralizer.
>
> * gnu/packages/video.scm (obs-spectralizer): New variable.

Applied!  I didn’t check whether OBS can actually load it, but I see
it’s installed under ‘lib/obs-plugins’, which is where the new search
path expects to find it, so it should be fine.

Thanks,
Ludo’.

Message #13 received at 45960-done <at> debbugs.gnu.org (full text, mbox):

From: Andrew Tropin <andrew <at> trop.in>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 45960-done <at> debbugs.gnu.org
Subject: Re: bug#45960: [PATCH] gnu: Add obs-spectralizer.
Date: Tue, 2 Feb 2021 12:53:11 +0300

Very nice! Thank you!

It won't load until obs updated to the commit with OBS_PLUGINS*_PATH
variables support [fn:1], but as you said it's future-proof and already
installs to the correct location.

There is another very similar patch, which adds another obs plugin. You
probably already aware of it, but here is a link:
http://issues.guix.gnu.org/45961. Accidentally, it has empty propagated
inputs and I'm not sure if it will apply to current master at all, but I
can update it if it's needed.


* Footnotes

[fn:1] http://issues.guix.gnu.org/46113

-- 
Best regards,
Andrew Tropin

Message #16 received at 45960-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Andrew Tropin <andrew <at> trop.in>
Cc: 46113 <at> debbugs.gnu.org, 45960-done <at> debbugs.gnu.org
Subject: Re: bug#45960: [PATCH] gnu: Add obs-spectralizer.
Date: Wed, 03 Feb 2021 11:43:37 +0100

Hi,

Andrew Tropin <andrew <at> trop.in> skribis:

> It won't load until obs updated to the commit with OBS_PLUGINS*_PATH
> variables support [fn:1], but as you said it's future-proof and already
> installs to the correct location.
>
> There is another very similar patch, which adds another obs plugin. You
> probably already aware of it, but here is a link:
> http://issues.guix.gnu.org/45961. Accidentally, it has empty propagated
> inputs and I'm not sure if it will apply to current master at all, but I
> can update it if it's needed.
>
>
> * Footnotes
>
> [fn:1] http://issues.guix.gnu.org/46113

Ah ha!  So on ‘master’, there’s the OBS_PLUGINS_DIRECTORY patch that you
provided earlier, which is why I wrote that the plugins should work.

Should we wait for the next OBS release instead of packaging an
arbitrary commit?

Ludo’.

Message #19 received at 45960-done <at> debbugs.gnu.org (full text, mbox):

From: Alexey Abramov <levenson <at> mmer.org>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 46113 <at> debbugs.gnu.org, 45960-done <at> debbugs.gnu.org,
 Andrew Tropin <andrew <at> trop.in>
Subject: Re: [bug#46113] bug#45960: [PATCH] gnu: Add obs-spectralizer.
Date: Wed, 03 Feb 2021 15:00:53 +0100

Hi,

Thanks for merging my patch =) I am not insist on keeping [1], but I do think that is more cleaner solution. 

With the upstream patch, Obs will be able to extend the list of plugin directories. We are going to add ~/.guix-profile/ to that list, which means Obs will have two different locations with partially different so files. It doesn't look clean to me. 

In addition, [1] doesn't require to have OBS_PLUGINS_DIRECTORY variables. If there is no such, it will run with its defaults.


Footnotes:
[1]  https://issues.guix.gnu.org/45707

-- 
Alexey

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.