GNU bug report logs - #45989
[PATCH 0/2] gnu: python-invoke: Patch reference to bash.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 45989 in the body.
You can then email your comments to 45989 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Tanguy Le Carrour <tanguy <at> bioneland.org>
To: guix-patches <at> gnu.org
Cc: Tanguy Le Carrour <tanguy <at> bioneland.org>
Subject: [PATCH 0/2] gnu: python-invoke: Patch reference to bash.
Date: Tue, 19 Jan 2021 19:22:57 +0100

Hi Guix,

Invoke's code contains a reference to `/bin/bash`. This path does not exist
in the build environment of another package I am working on. I don't
know why it seems to work for some other packages, thought !?

Best regards

Tanguy Le Carrour (2):
  gnu: python-invoke: Patch reference to bash.
  gnu: python-invoke: Update to 1.5.0.

 gnu/packages/python-xyz.scm | 18 +++++++++++++++---
 1 file changed, 15 insertions(+), 3 deletions(-)

-- 
2.30.0

Message #8 received at 45989 <at> debbugs.gnu.org (full text, mbox):

From: Tanguy Le Carrour <tanguy <at> bioneland.org>
To: 45989 <at> debbugs.gnu.org
Cc: Tanguy Le Carrour <tanguy <at> bioneland.org>
Subject: [PATCH 1/2] gnu: python-invoke: Patch reference to bash.
Date: Tue, 19 Jan 2021 19:25:41 +0100

* gnu/packages/python-xyz.scm (python-invoke)[arguments]: Patch
the reference to 'bash' in the source.
[inputs]: Add bash.
---
 gnu/packages/python-xyz.scm | 14 +++++++++++++-
 1 file changed, 13 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index d08e23936c..de36222bba 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -15129,7 +15129,19 @@ projects.")
     (build-system python-build-system)
     (arguments
      ;; XXX: Requires many dependencies that are not yet in Guix.
-     `(#:tests? #f))
+     `(#:tests? #f
+       #:phases
+       (modify-phases %standard-phases
+         (add-after 'unpack 'fix-bash-path
+           (lambda* (#:key inputs #:allow-other-keys)
+             (let ((bash (assoc-ref inputs "bash")))
+               (substitute* "invoke/config.py"
+                 (("shell = \"/bin/bash\"")
+                  (string-append "shell = \"" bash "/bin/bash\""))
+                 )
+               #t))))))
+    (inputs
+     `(("bash" ,bash-minimal)))
     (synopsis "Pythonic task execution")
     (description
      "Invoke is a Python task execution tool and library, drawing inspiration
-- 
2.30.0

Message #11 received at 45989 <at> debbugs.gnu.org (full text, mbox):

From: Tanguy Le Carrour <tanguy <at> bioneland.org>
To: 45989 <at> debbugs.gnu.org
Cc: Tanguy Le Carrour <tanguy <at> bioneland.org>
Subject: [PATCH 2/2] gnu: python-invoke: Update to 1.5.0.
Date: Tue, 19 Jan 2021 19:25:42 +0100

* gnu/packages/python-xyz.scm (python-invoke): Update to 1.5.0.
---
 gnu/packages/python-xyz.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index de36222bba..3f83c877b4 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -15119,13 +15119,13 @@ projects.")
   (package
     (name "python-invoke")
     (home-page "https://www.pyinvoke.org/")
-    (version "1.4.1")
+    (version "1.5.0")
     (source (origin
               (method url-fetch)
               (uri (pypi-uri "invoke" version))
               (sha256
                (base32
-                "0pg1lpl4583z83i12262v72y1a4cxdcxi7vqhl8dpqv9wszj6gyy"))))
+                "0l16v7zcbgi36z6pvmdrs5q4ks8lalcafi5d9nhrpcjzbc3n1igh"))))
     (build-system python-build-system)
     (arguments
      ;; XXX: Requires many dependencies that are not yet in Guix.
-- 
2.30.0

Message #16 received at 45989-done <at> debbugs.gnu.org (full text, mbox):

From: 宋文武 <iyzsong <at> outlook.com>
To: Tanguy Le Carrour <tanguy <at> bioneland.org>
Cc: 45989-done <at> debbugs.gnu.org
Subject: Re: [bug#45989] [PATCH 0/2] gnu: python-invoke: Patch reference to
 bash.
Date: Fri, 12 Feb 2021 20:16:57 +0800

Tanguy Le Carrour <tanguy <at> bioneland.org> writes:

> Hi Guix,
>
> Invoke's code contains a reference to `/bin/bash`. This path does not exist
> in the build environment of another package I am working on. I don't
> know why it seems to work for some other packages, thought !?
I think they'll failed too unless they configured the shell somehow...

Pushed, thank you!

Message #19 received at 45989-done <at> debbugs.gnu.org (full text, mbox):

From: Tanguy LE CARROUR <tanguy <at> bioneland.org>
To: 宋文武 <iyzsong <at> outlook.com>
Cc: 45989-done <at> debbugs.gnu.org
Subject: Re: [bug#45989] [PATCH 0/2] gnu: python-invoke: Patch reference to
 bash.
Date: Fri, 12 Feb 2021 14:46:15 +0100

Hi,


Excerpts from 宋文武's message of February 12, 2021 1:16 pm:
> Tanguy Le Carrour <tanguy <at> bioneland.org> writes:
> 
>> Hi Guix,
>>
>> Invoke's code contains a reference to `/bin/bash`. This path does not exist
>> in the build environment of another package I am working on. I don't
>> know why it seems to work for some other packages, thought !?
> I think they'll failed too unless they configured the shell somehow...

You right! I figured out that I had myself the `INVOKE_RUN_SHELL` envvar set.


> Pushed, thank you!

Thanks!

-- 
Tanguy

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.