GNU bug report logs - #45998
[PATCH] gnu: linux-libre: Allow disk encryption by default.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 45998 in the body.
You can then email your comments to 45998 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Caliph Nomble <calnomble <at> protonmail.com>
To: guix-patches <at> gnu.org
Cc: Caliph Nomble <calnomble <at> protonmail.com>
Subject: [PATCH] gnu: linux-libre: Allow disk encryption by default.
Date: Tue, 19 Jan 2021 22:47:19 +0000

* gnu/packages/linux.scm (%default-extra-linux-options): Enable CONFIG_DM_CRYPT
as a module.
---
 gnu/packages/linux.scm | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
index 7ed71e9d8f..26b3035518 100644
--- a/gnu/packages/linux.scm
+++ b/gnu/packages/linux.scm
@@ -641,6 +641,8 @@ for ARCH and optionally VARIANT, or #f if there is no such configuration."
     ("CONFIG_MEMCG_KMEM" . #t)
     ("CONFIG_CPUSETS" . #t)
     ("CONFIG_PROC_PID_CPUSET" . #t)
+    ;; Allow disk encryption by default
+    ("CONFIG_DM_CRYPT" . m)
     ;; Modules required for initrd:
     ("CONFIG_NET_9P" . m)
     ("CONFIG_NET_9P_VIRTIO" . m)
-- 
2.26.2

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: guix-patches--- via <guix-patches <at> gnu.org>
Cc: 45998 <at> debbugs.gnu.org, Caliph Nomble <calnomble <at> protonmail.com>
Subject: Re: [bug#45998] [PATCH] gnu: linux-libre: Allow disk encryption by
 default.
Date: Tue, 19 Jan 2021 20:54:35 -0500

On Tue, Jan 19, 2021 at 10:47:19PM +0000, guix-patches--- via wrote:
> * gnu/packages/linux.scm (%default-extra-linux-options): Enable CONFIG_DM_CRYPT
> as a module.

This option is already enabled in the kernel configs. Can you say why we
should put it in %default-extra-linux-options as well? Is there some use
case that isn't being served currently?

Message #14 received at 45998 <at> debbugs.gnu.org (full text, mbox):

From: Caliph Nomble <calnomble <at> protonmail.com>
To: Leo Famulari <leo <at> famulari.name>
Cc: "45998 <at> debbugs.gnu.org" <45998 <at> debbugs.gnu.org>
Subject: Re: [bug#45998] [PATCH] gnu: linux-libre: Allow disk encryption by
 default.
Date: Wed, 20 Jan 2021 03:28:28 +0000

Hi,

I know at least linux-libre-arm64-generic doesn't have the option already set,
and a quick glance through mainline kernel defconfigs made it seem like it'd be
better as a general option. I could have been wrong in thinking it'd do best as
a general option, but it needs to be in linux-libre-arm64-generic, at least.

Thanks.

Message #17 received at 45998 <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Caliph Nomble <calnomble <at> protonmail.com>
Cc: "45998 <at> debbugs.gnu.org" <45998 <at> debbugs.gnu.org>
Subject: Re: [bug#45998] [PATCH] gnu: linux-libre: Allow disk encryption by
 default.
Date: Wed, 20 Jan 2021 12:08:49 -0500

On Wed, Jan 20, 2021 at 03:28:28AM +0000, Caliph Nomble wrote:
> Hi,
> 
> I know at least linux-libre-arm64-generic doesn't have the option already set,
> and a quick glance through mainline kernel defconfigs made it seem like it'd be
> better as a general option. I could have been wrong in thinking it'd do best as
> a general option, but it needs to be in linux-libre-arm64-generic, at least.

Okay, let's do it!

Your patch applies with an author of "guix-patches--- via
<guix-patches <at> gnu.org>".

Shall I change it to "Caliph Nomble <calnomble <at> protonmail.com>"?

Message #20 received at 45998 <at> debbugs.gnu.org (full text, mbox):

From: Caliph Nomble <calnomble <at> protonmail.com>
To: "45998 <at> debbugs.gnu.org" <45998 <at> debbugs.gnu.org>
Cc: Leo Famulari <leo <at> famulari.name>
Subject: Re: [bug#45998] [PATCH] gnu: linux-libre: Allow disk encryption by
 default.
Date: Thu, 21 Jan 2021 22:21:16 +0000

Hi,

> Shall I change it to "Caliph Nomble <calnomble <at> protonmail.com>"?

Yes, that would be very much appreciated. I have no idea why that happens; I
know the same thing occured for a previous patch I submitted. If you know of
any way to prevent that in the future, too, please tell me.

Thanks!

Message #23 received at 45998 <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Caliph Nomble <calnomble <at> protonmail.com>
Cc: "45998 <at> debbugs.gnu.org" <45998 <at> debbugs.gnu.org>
Subject: Re: [bug#45998] [PATCH] gnu: linux-libre: Allow disk encryption by
 default.
Date: Fri, 22 Jan 2021 14:08:37 -0500

On Thu, Jan 21, 2021 at 10:21:16PM +0000, Caliph Nomble wrote:
> Yes, that would be very much appreciated. I have no idea why that happens; I
> know the same thing occured for a previous patch I submitted. If you know of
> any way to prevent that in the future, too, please tell me.

Alright, I've queued up your patch for the next kernel update.

Regarding your name not being included in your patch submissions, what
commands are you using to create and submit your patches?

Message #26 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Tobias Geerinckx-Rice <me <at> tobias.gr>
To: Caliph Nomble <calnomble <at> protonmail.com>, Leo Famulari <leo <at> famulari.name>
Cc: "45998 <at> debbugs.gnu.org" <45998 <at> debbugs.gnu.org>, guix-patches <at> gnu.org
Subject: Re: [bug#45998] [PATCH] gnu: linux-libre: Allow disk encryption by
 default.
Date: Fri, 22 Jan 2021 21:25:41 +0100

[Message part 1 (text/plain, inline)]

Caliph,

guix-patches--- via 写道：
>> Shall I change it to "Caliph Nomble 
>> <calnomble <at> protonmail.com>"?
>
> Yes, that would be very much appreciated. I have no idea why 
> that happens; I
> know the same thing occured for a previous patch I submitted.

I doubt there's fault with your patch workflow.

Your non-patch listmails lack a name as well.  For example[0]:

> From: guix-patches--- via <guix-patches <at> gnu.xxx>

Whilst[1]:

> From: Leo Famulari <xxx <at> famulari.xxx> [2]

Kind regards,

T G-R

[0]: 
https://lists.gnu.org/archive/html/guix-patches/2021-01/msg00842.html
[1]: 
https://lists.gnu.org/archive/html/guix-patches/2021-01/msg00862.html
[2]: I checked; the domain's still available.

[signature.asc (application/pgp-signature, inline)]

Message #32 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Tobias Geerinckx-Rice <me <at> tobias.gr>
Cc: 45998 <at> debbugs.gnu.org, Caliph Nomble <calnomble <at> protonmail.com>,
 guix-patches <at> gnu.org, Leo Famulari <leo <at> famulari.name>
Subject: Re: [bug#45998] [PATCH] gnu: linux-libre: Allow disk encryption by
 default.
Date: Fri, 22 Jan 2021 21:38:07 +0100

[Message part 1 (text/plain, inline)]

guix-patches--- via 写道：
> From: guix-patches--- via <guix-patches <at> gnu.org>
> [...]
>
> Caliph,

Hmmm.

Kind regards,

T G-R

[signature.asc (application/pgp-signature, inline)]

Message #38 received at 45998 <at> debbugs.gnu.org (full text, mbox):

From: Caliph Nomble <calnomble <at> protonmail.com>
To: "45998 <at> debbugs.gnu.org" <45998 <at> debbugs.gnu.org>
Cc: Tobias Geerinckx-Rice <me <at> tobias.gr>, Leo Famulari <leo <at> famulari.name>
Subject: Re: [bug#45998] [PATCH] gnu: linux-libre: Allow disk encryption by
 default.
Date: Sat, 23 Jan 2021 17:21:58 +0000

Hi,

Leo Famulari:
> Regarding your name not being included in your patch submissions, what
> commands are you using to create and submit your patches?

I'm just using git format-patch and send-email (with --from manually set to
this email address), though I do use hydroxide as an smtp bridge to ProtonMail.
Headers are all correct in the send-email confirm interface before sending.

Tobias Geerinckx-Rice:
> Hmmm.

Might be an issue with emails being forwarded through the mailing list and thus
replacing their original address, then? With this not happening in other cases
due to CCs.

Thanks!

Message #41 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: guix-patches--- via <guix-patches <at> gnu.org>
Cc: 45998-done <at> debbugs.gnu.org, Caliph Nomble <calnomble <at> protonmail.com>
Subject: Re: [bug#45998] [PATCH] gnu: linux-libre: Allow disk encryption by
 default.
Date: Sun, 24 Jan 2021 14:07:24 -0500

On Tue, Jan 19, 2021 at 10:47:19PM +0000, guix-patches--- via wrote:
> * gnu/packages/linux.scm (%default-extra-linux-options): Enable CONFIG_DM_CRYPT
> as a module.

Pushed as 82fd2eeed3335116cac6bd198420da7ba36cbc52

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.