GNU bug report logs - #46018
[PATCH] Add dwl.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 46018 in the body.
You can then email your comments to 46018 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Z572 <873216071 <at> qq.com>
To: guix-patches <at> gnu.org
Subject: [PATCH] Add dwl.
Date: Thu, 21 Jan 2021 20:14:40 +0800

[0001-gnu-Add-dwl.patch (text/x-patch, attachment)]

From fa60adfd7b2b48ea12a1ed66e7da9db94412e3af Mon Sep 17 00:00:00 2001
From: Zheng Junjie <873216071 <at> qq.com>
Date: Thu, 21 Jan 2021 20:12:13 +0800
Subject: [PATCH] gnu: Add dwl.

---
 gnu/packages/wm.scm | 48 +++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 48 insertions(+)

diff --git a/gnu/packages/wm.scm b/gnu/packages/wm.scm
index 084822f2c7..682fc69dbe 100644
--- a/gnu/packages/wm.scm
+++ b/gnu/packages/wm.scm
@@ -41,6 +41,7 @@
 ;;; Copyright © 2020 B. Wilson <elaexuotee <at> wilsonb.com>
 ;; Copyright © 2020 Niklas Eklund <niklas.eklund <at> posteo.net>
 ;;; Copyright © 2020 Robert Smith <robertsmith <at> posteo.net>
+;;; Copyright © 2021 Zheng Junjie <873216071 <at> qq.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -1258,6 +1259,53 @@ It is inspired by Xmonad and dwm.  Its major features include:
 project derived from the original Calm Window Manager.")
     (license license:isc)))
 
+(define-public dwl
+  (package
+    (name "dwl")
+    (version "0.1")
+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+                    (url "https://github.com/djpohly/dwl")
+                    (commit (string-append "v" version))))
+              (file-name (git-file-name name version))
+              (sha256
+               (base32
+                "18g2sx8cv54zl5iw5m9lzngrp6ra2pyp7c68qps2ava3brw9m0j2"))))
+    (build-system gnu-build-system)
+    (arguments
+     `(#:tests? #f                      ; no tests
+       #:make-flags
+       (list
+        "CC=gcc"
+        (string-append "PREFIX=" %output))
+       #:phases
+       (modify-phases %standard-phases
+         (delete 'configure)            ; no configure
+         (replace 'install              ; no install targer
+           (lambda* (#:key outputs #:allow-other-keys)
+             (let* ((out (assoc-ref outputs "out"))
+                    (bin (string-append out "/bin")))
+               (install-file "dwl" bin)))))))
+    (native-inputs
+     `(("pkg-config" ,pkg-config)))
+    (inputs
+     `(("wlroots" ,wlroots)))
+    (home-page "https://github.com/djpohly/dwl")
+    (synopsis "Dwm for Wayland")
+    (description
+     "A compact, hackable compositor for Wayland based on wlroots.  It is
+intended to fill the same space in the Wayland world that dwm does in X11,
+primarily in terms of philosophy, and secondarily in terms of functionality.
+Like dwm, dwl is:
+@itemize
+@item Easy to understand, hack on, and extend with patches
+@item One C source file (or a very small number) configurable via config.h
+@item Limited to 2000 SLOC to promote hackability
+@item Tied to as few external dependencies as possible
+@end itemize")      ;; LICENSE   LICENSE.dwm  LICENSE.tinywl
+    (license (list license:gpl3+ license:expat license:cc0))))
+
 (define-public nitrogen
   (package
     (name "nitrogen")
-- 
2.30.0

Message #8 received at 46018 <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Z572 <873216071 <at> qq.com>
Cc: 46018 <at> debbugs.gnu.org
Subject: Re: [bug#46018] [PATCH] Add dwl.
Date: Sat, 23 Jan 2021 12:15:23 +0100

Hello,

Z572 <873216071 <at> qq.com> writes:

> Subject: [PATCH] gnu: Add dwl.

Thank you! Some comments follow.

> +(define-public dwl
> +  (package
> +    (name "dwl")
> +    (version "0.1")
> +    (source (origin
> +              (method git-fetch)
> +              (uri (git-reference
> +                    (url "https://github.com/djpohly/dwl")
> +                    (commit (string-append "v" version))))
> +              (file-name (git-file-name name version))
> +              (sha256
> +               (base32
> +                "18g2sx8cv54zl5iw5m9lzngrp6ra2pyp7c68qps2ava3brw9m0j2"))))
> +    (build-system gnu-build-system)
> +    (arguments
> +     `(#:tests? #f                      ; no tests
> +       #:make-flags
> +       (list
> +        "CC=gcc"

Instead of "CC=gcc", you should use

                 (string-append "CC=" ,(cc-for-target))

for cross-compilation.

> +        (string-append "PREFIX=" %output))

Here, I think it is preferable to use

          (string-append "PREFIX=" (assoc-ref %outputs "out"))

> +       #:phases
> +       (modify-phases %standard-phases
> +         (delete 'configure)            ; no configure
> +         (replace 'install              ; no install targer

Typo: ";no install target"

> +           (lambda* (#:key outputs #:allow-other-keys)
> +             (let* ((out (assoc-ref outputs "out"))
> +                    (bin (string-append out "/bin")))
> +               (install-file "dwl" bin)))))))
> +    (native-inputs
> +     `(("pkg-config" ,pkg-config)))
> +    (inputs
> +     `(("wlroots" ,wlroots)))
> +    (home-page "https://github.com/djpohly/dwl")
> +    (synopsis "Dwm for Wayland")

It would be nice to expound Dwm, e.g.,

  "Dynamic window manager for Wayland"

> +    (description
> +     "A compact, hackable compositor for Wayland based on wlroots.  It is

This should be a complete sentence, e.g.,

  Dwl is a compact, hackable...
   
> +intended to fill the same space in the Wayland world that dwm does in X11,
> +primarily in terms of philosophy, and secondarily in terms of functionality.
> +Like dwm, dwl is:
> +@itemize
> +@item Easy to understand, hack on, and extend with patches
> +@item One C source file (or a very small number) configurable via config.h
> +@item Limited to 2000 SLOC to promote hackability
> +@item Tied to as few external dependencies as possible

I suggest rewrite so it doesn't include a list. For example:

  Like dwm, dwl is easy to understand and hack on, due to a limited
  size and a few external dependencies.  It is configurable via @file{config.h}.

Could you send an updated patch?

Regards,
-- 
Nicolas Goaziou

Message #11 received at 46018 <at> debbugs.gnu.org (full text, mbox):

From: Z572 <873216071 <at> qq.com>
To: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Cc: 46018 <at> debbugs.gnu.org
Subject: Re: bug#46018: [PATCH] Add dwl.
Date: Sat, 23 Jan 2021 20:17:18 +0800

[0001-gnu-Add-dwl.patch (text/x-patch, attachment)]

From 19ea34ad94d10453e0b6697a835217df50a34d45 Mon Sep 17 00:00:00 2001
From: Zheng Junjie <873216071 <at> qq.com>
Date: Thu, 21 Jan 2021 20:12:13 +0800
Subject: [PATCH] gnu: Add dwl.

---
 gnu/packages/wm.scm | 44 ++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 44 insertions(+)

diff --git a/gnu/packages/wm.scm b/gnu/packages/wm.scm
index 084822f2c7..38e0d5ea98 100644
--- a/gnu/packages/wm.scm
+++ b/gnu/packages/wm.scm
@@ -41,6 +41,7 @@
 ;;; Copyright © 2020 B. Wilson <elaexuotee <at> wilsonb.com>
 ;; Copyright © 2020 Niklas Eklund <niklas.eklund <at> posteo.net>
 ;;; Copyright © 2020 Robert Smith <robertsmith <at> posteo.net>
+;;; Copyright © 2021 Zheng Junjie <873216071 <at> qq.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -1258,6 +1259,49 @@ It is inspired by Xmonad and dwm.  Its major features include:
 project derived from the original Calm Window Manager.")
     (license license:isc)))
 
+(define-public dwl
+  (package
+    (name "dwl")
+    (version "0.1")
+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+                    (url "https://github.com/djpohly/dwl")
+                    (commit (string-append "v" version))))
+              (file-name (git-file-name name version))
+              (sha256
+               (base32
+                "18g2sx8cv54zl5iw5m9lzngrp6ra2pyp7c68qps2ava3brw9m0j2"))))
+    (build-system gnu-build-system)
+    (arguments
+     `(#:tests? #f                      ; no tests
+       #:make-flags
+       (list
+        (string-append "CC=" ,(cc-for-target))
+        (string-append "PREFIX=" (assoc-ref %outputs "out")))
+       #:phases
+       (modify-phases %standard-phases
+         (delete 'configure)            ; no configure
+         (replace 'install              ; no install target
+           (lambda* (#:key outputs #:allow-other-keys)
+             (let* ((out (assoc-ref outputs "out"))
+                    (bin (string-append out "/bin")))
+               (install-file "dwl" bin)))))))
+    (native-inputs
+     `(("pkg-config" ,pkg-config)))
+    (inputs
+     `(("wlroots" ,wlroots)))
+    (home-page "https://github.com/djpohly/dwl")
+    (synopsis "Dynamic window manager for Wayland")
+    (description
+     "A compact, hackable compositor for Wayland based on wlroots.  It is
+intended to fill the same space in the Wayland world that dwm does in X11,
+primarily in terms of philosophy, and secondarily in terms of functionality.
+Like dwm, dwl is easy to understand and hack on, due to a limited size and
+ a few external dependencies.  It is configurable via @file{config.h}.")
+    ;;             LICENSE       LICENSE.dwm   LICENSE.tinywl
+    (license (list license:gpl3+ license:expat license:cc0))))
+
 (define-public nitrogen
   (package
     (name "nitrogen")
-- 
2.30.0

Message #16 received at 46018-done <at> debbugs.gnu.org (full text, mbox):

From: 宋文武 <iyzsong <at> outlook.com>
To: Z572 <873216071 <at> qq.com>
Cc: 46018-done <at> debbugs.gnu.org, Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Subject: Re: [bug#46018] [PATCH] Add dwl.
Date: Fri, 12 Feb 2021 15:35:41 +0800

Pushed, thank you for the patch, and Nicolas Goaziou for the review!

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.