GNU bug report logs - #46021
[PATCH]: gnu: ecl: Propagate some dependencies used in header files

Previous Next

Package: guix-patches;

Reported by: Zhu Zihao <all_but_last <at> 163.com>

Date: Thu, 21 Jan 2021 15:30:02 UTC

Severity: normal

Tags: patch

Done: Guillaume Le Vaillant <glv <at> posteo.net>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 46021 in the body.
You can then email your comments to 46021 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#46021; Package guix-patches. (Thu, 21 Jan 2021 15:30:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Zhu Zihao <all_but_last <at> 163.com>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Thu, 21 Jan 2021 15:30:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Zhu Zihao <all_but_last <at> 163.com>
To: guix-patches <at> gnu.org
Subject: [PATCH]: gnu: ecl: Propagate some dependencies used in header files
Date: Thu, 21 Jan 2021 23:12:25 +0800
[Message part 1 (text/plain, inline)]
ECL's header includes the header of gmp, libgc, libatomic-ops and
libffi. This help fix some program use ecl as build input failed to link
with it.



-- 
Retrieve my PGP public key:

  gpg --recv-keys D47A9C8B2AE3905B563D9135BE42B352A9F6821F

Zihao
[signature.asc (application/pgp-signature, inline)]

Information forwarded to guix-patches <at> gnu.org:
bug#46021; Package guix-patches. (Thu, 21 Jan 2021 15:42:01 GMT) Full text and rfc822 format available.

Message #8 received at 46021 <at> debbugs.gnu.org (full text, mbox):

From: Zhu Zihao <all_but_last <at> 163.com>
To: 46021 <at> debbugs.gnu.org
Subject: Re: bug#46021: Acknowledgement ([PATCH]: gnu: ecl: Propagate some
 dependencies used in header files)
Date: Thu, 21 Jan 2021 23:40:42 +0800
[Message part 1 (text/plain, inline)]

[signature.asc (application/pgp-signature, inline)]
[0001-gnu-ecl-Propagate-some-dependencies-used-in-header-f.patch (text/x-patch, inline)]
From 191564b413e7e95e0e246935026392cd152464fe Mon Sep 17 00:00:00 2001
From: Zhu Zihao <all_but_last <at> 163.com>
Date: Thu, 21 Jan 2021 23:06:52 +0800
Subject: [PATCH] gnu: ecl: Propagate some dependencies used in header files.

* gnu/packages/lisp.scm(ecl)[inputs]: Remove.
[propagated-inputs]: Add gmp, libatomic-ops, libgc, libffi.
---
 gnu/packages/lisp.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/packages/lisp.scm b/gnu/packages/lisp.scm
index 3c09b0af8a..fb4f7cb7bd 100644
--- a/gnu/packages/lisp.scm
+++ b/gnu/packages/lisp.scm
@@ -236,7 +236,7 @@ interface to the Tk widget system.")
      `(("cl-asdf" ,cl-asdf)
        ("which" ,which)
        ("texinfo" ,texinfo)))
-    (inputs
+    (propagated-inputs
      `(("gmp" ,gmp)
        ("libatomic-ops" ,libatomic-ops)
        ("libgc" ,libgc)
-- 
2.30.0

[Message part 4 (text/plain, inline)]


-- 
Retrieve my PGP public key:

  gpg --recv-keys D47A9C8B2AE3905B563D9135BE42B352A9F6821F

Zihao
[0001-gnu-ecl-Propagate-some-dependencies-used-in-header-f.patch (text/x-patch, inline)]
From 191564b413e7e95e0e246935026392cd152464fe Mon Sep 17 00:00:00 2001
From: Zhu Zihao <all_but_last <at> 163.com>
Date: Thu, 21 Jan 2021 23:06:52 +0800
Subject: [PATCH] gnu: ecl: Propagate some dependencies used in header files.

* gnu/packages/lisp.scm(ecl)[inputs]: Remove.
[propagated-inputs]: Add gmp, libatomic-ops, libgc, libffi.
---
 gnu/packages/lisp.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/packages/lisp.scm b/gnu/packages/lisp.scm
index 3c09b0af8a..fb4f7cb7bd 100644
--- a/gnu/packages/lisp.scm
+++ b/gnu/packages/lisp.scm
@@ -236,7 +236,7 @@ interface to the Tk widget system.")
      `(("cl-asdf" ,cl-asdf)
        ("which" ,which)
        ("texinfo" ,texinfo)))
-    (inputs
+    (propagated-inputs
      `(("gmp" ,gmp)
        ("libatomic-ops" ,libatomic-ops)
        ("libgc" ,libgc)
-- 
2.30.0


Information forwarded to guix-patches <at> gnu.org:
bug#46021; Package guix-patches. (Fri, 29 Jan 2021 01:57:02 GMT) Full text and rfc822 format available.

Message #11 received at 46021 <at> debbugs.gnu.org (full text, mbox):

From: Zhu Zihao <all_but_last <at> 163.com>
To: 46021 <at> debbugs.gnu.org
Subject: Re: bug#46021: Acknowledgement ([PATCH]: gnu: ecl: Propagate some
 dependencies used in header files)
Date: Fri, 29 Jan 2021 09:56:21 +0800
[Message part 1 (text/plain, inline)]
ping.
-- 
Retrieve my PGP public key:

  gpg --recv-keys D47A9C8B2AE3905B563D9135BE42B352A9F6821F

Zihao
[signature.asc (application/pgp-signature, inline)]

Information forwarded to guix-patches <at> gnu.org:
bug#46021; Package guix-patches. (Fri, 29 Jan 2021 08:51:02 GMT) Full text and rfc822 format available.

Message #14 received at 46021 <at> debbugs.gnu.org (full text, mbox):

From: Guillaume Le Vaillant <glv <at> posteo.net>
To: Zhu Zihao <all_but_last <at> 163.com>
Cc: 46021 <at> debbugs.gnu.org
Subject: Re: [bug#46021] Acknowledgement ([PATCH]: gnu: ecl: Propagate some
 dependencies used in header files)
Date: Fri, 29 Jan 2021 09:49:56 +0100
[Message part 1 (text/plain, inline)]
Zhu Zihao <all_but_last <at> 163.com> skribis:

> ECL's header includes the header of gmp, libgc, libatomic-ops and
> libffi. This help fix some program use ecl as build input failed to link
> with it.

I tried a `guix environment -C --ad-hoc ecl -- ecl --eval '(compile-file "test.lisp")'`
and ECL compiled the file successfully, so it must have found the
headers it needed.

Could you give an example of build failure solved by your patch?
[signature.asc (application/pgp-signature, inline)]

Information forwarded to guix-patches <at> gnu.org:
bug#46021; Package guix-patches. (Fri, 29 Jan 2021 09:35:02 GMT) Full text and rfc822 format available.

Message #17 received at 46021 <at> debbugs.gnu.org (full text, mbox):

From: Zhu Zihao <all_but_last <at> 163.com>
To: Guillaume Le Vaillant <glv <at> posteo.net>
Cc: 46021 <at> debbugs.gnu.org
Subject: Re: [bug#46021] Acknowledgement ([PATCH]: gnu: ecl: Propagate some
 dependencies used in header files)
Date: Fri, 29 Jan 2021 17:34:20 +0800
[Message part 1 (text/plain, inline)]
Guillaume Le Vaillant writes:

> Zhu Zihao <all_but_last <at> 163.com> skribis:
>
>> ECL's header includes the header of gmp, libgc, libatomic-ops and
>> libffi. This help fix some program use ecl as build input failed to link
>> with it.
>
> I tried a `guix environment -C --ad-hoc ecl -- ecl --eval '(compile-file "test.lisp")'`
> and ECL compiled the file successfully, so it must have found the
> headers it needed.

Because we already wrapped ECL executable with CPATH and LIBRARY_PATH
environment variable. so any compilation done in ECL can find the
library and header.

If some 3-rd party program want to link with ECL(If they use ECL as
thier extension language). Compiler will failed to find gmp, libgc etc.

A simple example here, start with `guix environment --ad-hoc ecl`

```
chino <at> asus-laptop:~/tmp$ cat test.c
#include <ecl/ecl.h>

int main() {
  cl_boot(0, NULL);
  return 0;
}
chino <at> asus-laptop:~/tmp$ CFLAGS="$(ecl-config --cflags) $(ecl-config --ldflags) $(ecl-config --libs)"
chino <at> asus-laptop:~/tmp$ LANG=en_US.utf-8 gcc -c test.c -o test $CFLAGS
In file included from /gnu/store/lzfxjn036h3kis13lcc222rpwcnqazkr-ecl-20.4.24/include/ecl/ecl.h:37,
                 from test.c:1:
/gnu/store/lzfxjn036h3kis13lcc222rpwcnqazkr-ecl-20.4.24/include/ecl/config.h:59:10: fatal error: gmp.h: No such file or directory
   59 | #include "gmp.h"
      |          ^~~~~~~
compilation terminated.
```

-- 
Retrieve my PGP public key:

  gpg --recv-keys D47A9C8B2AE3905B563D9135BE42B352A9F6821F

Zihao
[signature.asc (application/pgp-signature, inline)]

Reply sent to Guillaume Le Vaillant <glv <at> posteo.net>:
You have taken responsibility. (Tue, 02 Feb 2021 09:40:03 GMT) Full text and rfc822 format available.

Notification sent to Zhu Zihao <all_but_last <at> 163.com>:
bug acknowledged by developer. (Tue, 02 Feb 2021 09:40:03 GMT) Full text and rfc822 format available.

Message #22 received at 46021-done <at> debbugs.gnu.org (full text, mbox):

From: Guillaume Le Vaillant <glv <at> posteo.net>
To: Zhu Zihao <all_but_last <at> 163.com>
Cc: 46021-done <at> debbugs.gnu.org
Subject: Re: [bug#46021] Acknowledgement ([PATCH]: gnu: ecl: Propagate some
 dependencies used in header files)
Date: Tue, 02 Feb 2021 10:39:34 +0100
[Message part 1 (text/plain, inline)]
Patch pushed as 90ad8bd1a63abbf94f2ebb9f10630773d1f15ece.
Thanks.
[signature.asc (application/pgp-signature, inline)]

bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Tue, 02 Mar 2021 12:24:05 GMT) Full text and rfc822 format available.

This bug report was last modified 3 years and 26 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.