GNU bug report logs - #46024
Perl mode colors the word "argument" funny

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 46024 in the body.
You can then email your comments to 46024 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: 積丹尼 Dan Jacobson <jidanni <at> jidanni.org>
To: bug-gnu-emacs <at> gnu.org
Subject: Perl mode colors the word "argument" funny
Date: Fri, 22 Jan 2021 04:05:19 +0800

Perl mode colors the word "argument" funny:
for ( $r[$v] ) {
        $_->{argument}  = 0 + shift;
}
Cperl mode doesn't.
emacs-version "27.1"

Message #8 received at 46024 <at> debbugs.gnu.org (full text, mbox):

From: haj <at> posteo.de (Harald Jörg)
To: 46024 <at> debbugs.gnu.org
Cc: 積丹尼 Dan Jacobson <jidanni <at> jidanni.org>
Subject: Re: bug#46024: Perl mode colors the word "argument" funny
Date: Fri, 22 Jan 2021 01:33:55 +0100

積丹尼 Dan Jacobson <jidanni <at> jidanni.org> writes:

> Perl mode colors the word "argument" funny:
> for ( $r[$v] ) {
>         $_->{argument}  = 0 + shift;
> }
> Cperl mode doesn't.
> emacs-version "27.1"

"argument" as a keyword in Perl mode came as a patch for Bug#27613 -
together with a couple of other keywords: anon, has, our, state,
supersede, let, and temp.

However, only 'our' and 'state' are part of Perl 5.  A keyword 'has' is
available with popular Perl extensions (Moose, Moo etc.), so arguably
fontification as a declarator is acceptable... though slightly
inaccurate.

The keywords 'anon', 'has', 'supersede', 'let' and 'temp' are part of
the Raku language, which started as "Perl 6", as described in the
language docs:
https://docs.raku.org/language/variables#Variable_declarators_and_scope.
'argument' apparently didn't make it into the language at all, but Raku
also has 'augment' and 'constant', and Perl's 'local' is called 'temp'
in Raku.

CPerl mode has caught only a few keywords from non-core Perl, these are
also available with popular extensions ('try','catch','finally').  Perl
mode seems to have adopted some more Raku-stuff (e.g. it registers
variable names like "my $amazing-variable" to imenu, but fontifies only
the $amazing-part).

So I wonder: What is the ambition of Emacs to support Raku?  The
languages Perl (Perl 5) and Raku (Perl 6) have diverged in their syntax,
so robably it is rather cumbersome to support both with any of the Perl
modes.  In my opionion, randomly adding Raku features to the modes
brings more confusion than productivity, and in any case keywords which
are no longer part of either language should be eliminated, in
particular: 'argument', which is the topic of this bug report.
-- 
Cheers,
haj

Message #11 received at 46024 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: haj <at> posteo.de (Harald Jörg)
Cc: 46024 <at> debbugs.gnu.org,
 積丹尼 Dan Jacobson <jidanni <at> jidanni.org>
Subject: Re: bug#46024: Perl mode colors the word "argument" funny
Date: Fri, 22 Jan 2021 19:38:33 +0100

haj <at> posteo.de (Harald Jörg) writes:

> So I wonder: What is the ambition of Emacs to support Raku?  The
> languages Perl (Perl 5) and Raku (Perl 6) have diverged in their syntax,
> so robably it is rather cumbersome to support both with any of the Perl
> modes.  In my opionion, randomly adding Raku features to the modes
> brings more confusion than productivity, and in any case keywords which
> are no longer part of either language should be eliminated, in
> particular: 'argument', which is the topic of this bug report.

Long term, it does seem like the best solution would be to have a
separate mode for Raku, and not keep tweaking (c)perl-mode to add Raku
features, I think.

So backing out this change ('argument' etc) sounds like a good idea to
me.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #14 received at 46024 <at> debbugs.gnu.org (full text, mbox):

From: haj <at> posteo.de (Harald Jörg)
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 46024 <at> debbugs.gnu.org,
 積丹尼 Dan Jacobson <jidanni <at> jidanni.org>
Subject: Re: bug#46024: Perl mode colors the word "argument" funny [PATCH]
Date: Wed, 27 Jan 2021 15:08:28 +0100

[Message part 1 (text/plain, inline)]

Lars Ingebrigtsen <larsi <at> gnus.org> writes:

> [...]
> Long term, it does seem like the best solution would be to have a
> separate mode for Raku, and not keep tweaking (c)perl-mode to add Raku
> features, I think.
>
> So backing out this change ('argument' etc) sounds like a good idea to
> me.

The attached patch removes the declarators and prefixes which are not in
Perl.

BTW: There is a Raku mode, maintained by the Raku team in their
repository on GitHub.
-- 
Cheers,
haj

[0001-perl-mode.el-Eliminate-keywords-which-are-not-in-Per.patch (text/x-diff, attachment)]

Message #17 received at 46024 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: haj <at> posteo.de (Harald Jörg)
Cc: 46024 <at> debbugs.gnu.org,
 積丹尼 Dan Jacobson <jidanni <at> jidanni.org>
Subject: Re: bug#46024: Perl mode colors the word "argument" funny [PATCH]
Date: Thu, 28 Jan 2021 04:23:23 +0100

haj <at> posteo.de (Harald Jörg) writes:

> The attached patch removes the declarators and prefixes which are not in
> Perl.

Thanks; applied to Emacs 28.

> BTW: There is a Raku mode, maintained by the Raku team in their
> repository on GitHub.

I see...  and checking with `package-list', it's also on Melpa.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.