GNU bug report logs - #46036
fails do build on macos 10.7

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 46036 in the body.
You can then email your comments to 46036 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Riccardo Mottola <riccardo.mottola <at> libero.it>
To: bug-gnu-emacs <at> gnu.org
Subject: fails do build on macos 10.7
Date: Fri, 22 Jan 2021 15:57:18 +0100

Compilation of 27.1 yields:
nsfns.m:496:33: error: unexpected type name 'BOOL': expected expression
  NSNumber *isUbiquitousItem = @YES;
                                ^
/usr/include/objc/objc.h:50:26: note: expanded from macro 'YES'
#define YES             (BOOL)1
                         ^

this code is guarded with MacOS 10.7, but the compiler doesn't like it.

It is as easy to write it old-style:
  NSNumber *isUbiquitousItem = [NSNumber numberWithBool:YES];

and emacs 27.1 happily running on Lion again.

Thanks

Message #8 received at 46036 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Riccardo Mottola <riccardo.mottola <at> libero.it>, Alan Third <alan <at> idiocy.org>
Cc: 46036 <at> debbugs.gnu.org
Subject: Re: bug#46036: fails do build on macos 10.7
Date: Sat, 30 Jan 2021 10:57:20 +0200

> Date: Fri, 22 Jan 2021 15:57:18 +0100
> From: Riccardo Mottola <riccardo.mottola <at> libero.it>
> 
> Compilation of 27.1 yields:
> nsfns.m:496:33: error: unexpected type name 'BOOL': expected expression
>    NSNumber *isUbiquitousItem = @YES;
>                                  ^
> /usr/include/objc/objc.h:50:26: note: expanded from macro 'YES'
> #define YES             (BOOL)1
>                           ^
> 
> this code is guarded with MacOS 10.7, but the compiler doesn't like it.
> 
> It is as easy to write it old-style:
>    NSNumber *isUbiquitousItem = [NSNumber numberWithBool:YES];
> 
> and emacs 27.1 happily running on Lion again.

Alan, any comments on this?

Message #11 received at 46036 <at> debbugs.gnu.org (full text, mbox):

From: Alan Third <alan <at> idiocy.org>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 46036 <at> debbugs.gnu.org, Riccardo Mottola <riccardo.mottola <at> libero.it>
Subject: Re: bug#46036: fails do build on macos 10.7
Date: Sat, 30 Jan 2021 10:56:59 +0000

On Sat, Jan 30, 2021 at 10:57:20AM +0200, Eli Zaretskii wrote:
> > Date: Fri, 22 Jan 2021 15:57:18 +0100
> > From: Riccardo Mottola <riccardo.mottola <at> libero.it>
> > 
> > Compilation of 27.1 yields:
> > nsfns.m:496:33: error: unexpected type name 'BOOL': expected expression
> >    NSNumber *isUbiquitousItem = @YES;
> >                                  ^
> > /usr/include/objc/objc.h:50:26: note: expanded from macro 'YES'
> > #define YES             (BOOL)1
> >                           ^
> > 
> > this code is guarded with MacOS 10.7, but the compiler doesn't like it.
> > 
> > It is as easy to write it old-style:
> >    NSNumber *isUbiquitousItem = [NSNumber numberWithBool:YES];
> > 
> > and emacs 27.1 happily running on Lion again.
> 
> Alan, any comments on this?

Looks fine to me. Is this good to go into Emacs 27, or does it have to
wait until the release is done?
-- 
Alan Third

Message #14 received at 46036 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Alan Third <alan <at> idiocy.org>
Cc: 46036 <at> debbugs.gnu.org, riccardo.mottola <at> libero.it
Subject: Re: bug#46036: fails do build on macos 10.7
Date: Sat, 30 Jan 2021 14:05:05 +0200

> Date: Sat, 30 Jan 2021 10:56:59 +0000
> From: Alan Third <alan <at> idiocy.org>
> Cc: Riccardo Mottola <riccardo.mottola <at> libero.it>, 46036 <at> debbugs.gnu.org
> 
> On Sat, Jan 30, 2021 at 10:57:20AM +0200, Eli Zaretskii wrote:
> > > Date: Fri, 22 Jan 2021 15:57:18 +0100
> > > From: Riccardo Mottola <riccardo.mottola <at> libero.it>
> > > 
> > > Compilation of 27.1 yields:
> > > nsfns.m:496:33: error: unexpected type name 'BOOL': expected expression
> > >    NSNumber *isUbiquitousItem = @YES;
> > >                                  ^
> > > /usr/include/objc/objc.h:50:26: note: expanded from macro 'YES'
> > > #define YES             (BOOL)1
> > >                           ^
> > > 
> > > this code is guarded with MacOS 10.7, but the compiler doesn't like it.
> > > 
> > > It is as easy to write it old-style:
> > >    NSNumber *isUbiquitousItem = [NSNumber numberWithBool:YES];
> > > 
> > > and emacs 27.1 happily running on Lion again.
> > 
> > Alan, any comments on this?
> 
> Looks fine to me. Is this good to go into Emacs 27, or does it have to
> wait until the release is done?

Please push to emacs-27.

Is this change safe, or will we need another pretest to be sure?  I
thought we could next go straight to a release candidate.

Thanks.

Message #17 received at 46036 <at> debbugs.gnu.org (full text, mbox):

From: Riccardo Mottola <riccardo.mottola <at> libero.it>
To: Eli Zaretskii <eliz <at> gnu.org>, Alan Third <alan <at> idiocy.org>
Cc: 46036 <at> debbugs.gnu.org
Subject: Re: bug#46036: fails do build on macos 10.7
Date: Sat, 30 Jan 2021 19:32:17 +0100

Hi,


Eli Zaretskii wrote:
>>>> this code is guarded with MacOS 10.7, but the compiler doesn't like it.
>>>>
>>>> It is as easy to write it old-style:
>>>>     NSNumber *isUbiquitousItem = [NSNumber numberWithBool:YES];
>>>>
>>>> and emacs 27.1 happily running on Lion again.
>>> Alan, any comments on this?
>> Looks fine to me. Is this good to go into Emacs 27, or does it have to
>> wait until the release is done?
> Please push to emacs-27.
>
> Is this change safe, or will we need another pretest to be sure?  I
> thought we could next go straight to a release candidate.


to my knowledge it is safe: it is really equivalent code, the new syntax 
is just a shortcut. A test on a newer MacOS is of course needed, I don't 
have one.

Riccardo

Message #20 received at 46036 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Riccardo Mottola <riccardo.mottola <at> libero.it>
Cc: alan <at> idiocy.org, 46036 <at> debbugs.gnu.org
Subject: Re: bug#46036: fails do build on macos 10.7
Date: Sat, 30 Jan 2021 20:34:00 +0200

> Cc: 46036 <at> debbugs.gnu.org
> From: Riccardo Mottola <riccardo.mottola <at> libero.it>
> Date: Sat, 30 Jan 2021 19:32:17 +0100
> 
> > Is this change safe, or will we need another pretest to be sure?  I
> > thought we could next go straight to a release candidate.
> 
> to my knowledge it is safe: it is really equivalent code, the new syntax 
> is just a shortcut. A test on a newer MacOS is of course needed, I don't 
> have one.

Thanks.

Message #25 received at 46036-done <at> debbugs.gnu.org (full text, mbox):

From: Alan Third <alan <at> idiocy.org>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 46036-done <at> debbugs.gnu.org, Riccardo Mottola <riccardo.mottola <at> libero.it>
Subject: Re: bug#46036: fails do build on macos 10.7
Date: Sat, 30 Jan 2021 22:15:57 +0000

On Sat, Jan 30, 2021 at 08:34:00PM +0200, Eli Zaretskii wrote:
> > Cc: 46036 <at> debbugs.gnu.org
> > From: Riccardo Mottola <riccardo.mottola <at> libero.it>
> > Date: Sat, 30 Jan 2021 19:32:17 +0100
> > 
> > > Is this change safe, or will we need another pretest to be sure?  I
> > > thought we could next go straight to a release candidate.
> > 
> > to my knowledge it is safe: it is really equivalent code, the new syntax 
> > is just a shortcut. A test on a newer MacOS is of course needed, I don't 
> > have one.
> 
> Thanks.

I agree that it's safe so I've pushed the change.
-- 
Alan Third

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.