GNU bug report logs - #4610
23.1; VC commit buffer should list files to be committed

Previous Next

Package: emacs;

Reported by: Tom Tromey <tromey <at> redhat.com>

Date: Thu, 1 Oct 2009 21:30:04 UTC

Severity: wishlist

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 4610 in the body.
You can then email your comments to 4610 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to bug-submit-list <at> lists.donarmstrong.com, Emacs Bugs <bug-gnu-emacs <at> gnu.org>:
bug#4610; Package emacs. (Thu, 01 Oct 2009 21:30:04 GMT) Full text and rfc822 format available.

Acknowledgement sent to Tom Tromey <tromey <at> redhat.com>:
New bug report received and forwarded. Copy sent to Emacs Bugs <bug-gnu-emacs <at> gnu.org>. (Thu, 01 Oct 2009 21:30:05 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Tom Tromey <tromey <at> redhat.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 23.1; VC commit buffer should list files to be committed
Date: Thu, 01 Oct 2009 15:23:50 -0600
Please write in English if possible, because the Emacs maintainers
usually do not have translators to read other languages for them.

Your bug report will be posted to the bug-gnu-emacs <at> gnu.org mailing list,
and to the gnu.emacs.bug news group.

Please describe exactly what actions triggered the bug
and the precise symptoms of the bug:


Today I accidentally committed one file but not another one from
*vc-dir*.  That happened because point was on one file, not on the
containing directory as I'd thought.

It would be nice if the VC commit message buffer listed the files that
were going to be committed.  Such a list should automatically be
stripped out before being sent to the underlying command as the commit
message.


If Emacs crashed, and you have the Emacs process in the gdb debugger,
please include the output from the following gdb commands:
    `bt full' and `xbacktrace'.
If you would like to further debug the crash, please read the file
/usr/share/emacs/23.1/etc/DEBUG for instructions.


In GNU Emacs 23.1.1 (i386-redhat-linux-gnu, GTK+ Version 2.16.5)
 of 2009-08-26 on x86-2.fedora.phx.redhat.com
Windowing system distributor `The X.Org Foundation', version 11.0.10601901
configured using `configure  '--build=i386-redhat-linux-gnu' '--host=i386-redhat-linux-gnu' '--target=i586-redhat-linux-gnu' '--program-prefix=' '--prefix=/usr' '--exec-prefix=/usr' '--bindir=/usr/bin' '--sbindir=/usr/sbin' '--sysconfdir=/etc' '--datadir=/usr/share' '--includedir=/usr/include' '--libdir=/usr/lib' '--libexecdir=/usr/libexec' '--localstatedir=/var' '--sharedstatedir=/var/lib' '--mandir=/usr/share/man' '--infodir=/usr/share/info' '--with-dbus' '--with-gif' '--with-jpeg' '--with-png' '--with-rsvg' '--with-tiff' '--with-xft' '--with-xpm' '--with-x-toolkit=gtk' 'build_alias=i386-redhat-linux-gnu' 'host_alias=i386-redhat-linux-gnu' 'target_alias=i586-redhat-linux-gnu' 'CFLAGS=-DMAIL_USE_LOCKF -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4 -m32 -march=i586 -mtune=generic -fasynchronous-unwind-tables''

Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: en_US.UTF-8
  value of $XMODIFIERS: nil
  locale-coding-system: utf-8-unix
  default-enable-multibyte-characters: t

Major mode: C/l

Minor modes in effect:
  erc-list-mode: t
  erc-menu-mode: t
  erc-autojoin-mode: t
  erc-ring-mode: t
  erc-pcomplete-mode: t
  erc-track-mode: t
  erc-track-minor-mode: t
  erc-match-mode: t
  erc-button-mode: t
  erc-fill-mode: t
  erc-stamp-mode: t
  erc-netsplit-mode: t
  erc-spelling-mode: t
  erc-truncate-mode: t
  shell-dirtrack-mode: t
  diff-auto-refine-mode: t
  flyspell-mode: t
  erc-status-mode: t
  erc-services-mode: t
  erc-networks-mode: t
  erc-irccontrols-mode: t
  erc-noncommands-mode: t
  erc-move-to-prompt-mode: t
  erc-readonly-mode: t
  tooltip-mode: t
  mouse-wheel-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  global-auto-composition-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  transient-mark-mode: t
  abbrev-mode: t

Recent input:
E = M-v M-v q C-l C-u C-u C-n n SPC E q C-l C-u C-n 
C-u C-n p SPC E q n n SPC M-> Q y n n SPC M-> SPC SPC 
2 K i SPC E q C-l SPC M-> Q y SPC 5 0 <return> M-> 
C-u C-p C-p C-p SPC E E S-SPC E S-SPC E S-SPC E S-SPC 
E C-z o <f10> M-v M-> <f10> <f10> <f10> C-z o SPC SPC 
q s M-v M-v M-v M-v M-< C-u C-n p SPC c SPC SPC SPC 
c SPC s z C-c b C-x k <return> C-x k <return> C-l C-z 
o <f10> <f10> <f10> <f10> C-z o M-v <switch-frame> 
<switch-frame> C-x s C-x b * G <tab> <return> M-> C-u 
C-p C-u C-p SPC 5 0 <return> M-> C-p SPC S W <return> 
C-p C-SPC C-n C-n C-n C-w C-n C-n C-k N o t SPC y e 
t , SPC s o r r y SPC a b o u t SPC t h a t <return> 
<backspace> . <return> I SPC w i l l SPC r e a d SPC 
t h e m SPC t o m r r <backspace> <backspace> o r r 
o w . C-f C-k C-c C-c M SPC = C-l q s C-z o C-x b C-g 
C-z o C-x b v a l o p <tab> <return> C-l C-v C-v C-l 
C-z o C-x b C-g C-x k <return> <f10> <f10> <f10> C-x 
b c p - a <tab> <M-backspace> s u p <tab> h <return> 
C-v C-v C-z o M-x r e p o r t - e m <tab> b <tab> <return> 
v c SPC c o m m i t C-g C-x b * V <tab> <tab> C-g M-x 
M-p <return>

Recent messages:
Sending...done
No more articles [2 times]
Expiring articles...done
(No changes need to be saved)
Saving /home/tromey/.newsrc.eld...
Saving file /home/tromey/.newsrc.eld...
Wrote /home/tromey/.newsrc.eld
Saving /home/tromey/.newsrc.eld...done
Quit [3 times]
Making completion list...
Quit
Tom




Information forwarded to bug-submit-list <at> lists.donarmstrong.com, Emacs Bugs <bug-gnu-emacs <at> gnu.org>:
bug#4610; Package emacs. (Thu, 10 Dec 2009 20:00:05 GMT) Full text and rfc822 format available.

Message #8 received at 4610 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Dan Nicolaescu <dann <at> ics.uci.edu>
To: Tom Tromey <tromey <at> redhat.com>
Cc: 4610 <at> debbugs.gnu.org
Subject: Re: bug#4610: 23.1; VC commit buffer should list files to be committed
Date: Thu, 10 Dec 2009 11:54:53 -0800 (PST)
Tom Tromey <tromey <at> redhat.com> writes:

  > Today I accidentally committed one file but not another one from
  > *vc-dir*.  That happened because point was on one file, not on the
  > containing directory as I'd thought.
  > 
  > It would be nice if the VC commit message buffer listed the files that
  > were going to be committed.  Such a list should automatically be
  > stripped out before being sent to the underlying command as the commit
  > message.

The list of files to be committed can be seen by using `log-edit-show-files'.
log-edit-hook can be configured to do it automatically.

On the other hand is it clear that showing such a list by default helps?
My personal experience with perforce (where files are listed in the
commit message by default -- and the list is editable) shows that the
same mistake is quite possible (and not infrequent) there.  IMMV...



Severity set to 'wishlist' from 'normal' Request was from Glenn Morris <rgm <at> gnu.org> to control <at> debbugs.gnu.org. (Wed, 27 Jan 2010 22:29:02 GMT) Full text and rfc822 format available.

Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#4610; Package emacs. (Sun, 18 Jul 2021 18:51:01 GMT) Full text and rfc822 format available.

Message #13 received at 4610 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Tom Tromey <tromey <at> redhat.com>
Cc: 4610 <at> debbugs.gnu.org
Subject: Re: bug#4610: 23.1; VC commit buffer should list files to be committed
Date: Sun, 18 Jul 2021 20:50:24 +0200
[Message part 1 (text/plain, inline)]
Tom Tromey <tromey <at> redhat.com> writes:

> Today I accidentally committed one file but not another one from
> *vc-dir*.  That happened because point was on one file, not on the
> containing directory as I'd thought.
>
> It would be nice if the VC commit message buffer listed the files that
> were going to be committed.  Such a list should automatically be
> stripped out before being sent to the underlying command as the commit
> message.

(I'm going through old bug reports that unfortunately weren't resolved
at the time.)

It seems like this was implemented a some point in the years since this
was reported.  By default, Emacs shows the included screenshot now, so
I'm closing this bug report.

[Message part 2 (image/png, inline)]
[Message part 3 (text/plain, inline)]


-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug closed, send any further explanations to 4610 <at> debbugs.gnu.org and Tom Tromey <tromey <at> redhat.com> Request was from Lars Ingebrigtsen <larsi <at> gnus.org> to control <at> debbugs.gnu.org. (Sun, 18 Jul 2021 18:51:02 GMT) Full text and rfc822 format available.

bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Mon, 16 Aug 2021 11:24:04 GMT) Full text and rfc822 format available.

This bug report was last modified 2 years and 225 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.