GNU bug report logs - #46234
[PATCH] Add new gopkg.in/yaml.v3

Previous Next

Package: guix-patches;

Reported by: Sharlatan Hellseher <sharlatanus <at> gmail.com>

Date: Mon, 1 Feb 2021 12:48:01 UTC

Severity: normal

Tags: patch

Done: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 46234 in the body.
You can then email your comments to 46234 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#46234; Package guix-patches. (Mon, 01 Feb 2021 12:48:01 GMT) Full text and rfc822 format available.

Acknowledgement sent to Sharlatan Hellseher <sharlatanus <at> gmail.com>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Mon, 01 Feb 2021 12:48:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Sharlatan Hellseher <sharlatanus <at> gmail.com>
To: guix-patches <at> gnu.org
Subject: [PATCH] Add new gopkg.in/yaml.v3
Date: Mon, 1 Feb 2021 12:46:50 +0000
[Message part 1 (text/plain, inline)]
--
… наш разум - превосходная объяснительная машина которая способна
найти смысл почти в чем угодно, истолковать любой феномен, но
совершенно не в состоянии принять мысль о непредсказуемости.
[0001-gnu-Add-gopkg.in-yaml.v3.patch (text/x-patch, attachment)]

Information forwarded to guix-patches <at> gnu.org:
bug#46234; Package guix-patches. (Sun, 13 Jun 2021 11:15:01 GMT) Full text and rfc822 format available.

Message #8 received at 46234 <at> debbugs.gnu.org (full text, mbox):

From: Sharlatan Hellseher <sharlatanus <at> gmail.com>
To: 46234 <at> debbugs.gnu.org
Subject: Re: bug#46234: Acknowledgement ([PATCH] Add new gopkg.in/yaml.v3)
Date: Sun, 13 Jun 2021 11:14:34 +0000
Hi Guix team!

Is there anything I may fix in this patch?
go Yaml v3 goes as one of the dependencies of some good packages like
dive and lazygit.

Regards

On Mon, 1 Feb 2021 at 12:48, GNU bug Tracking System
<help-debbugs <at> gnu.org> wrote:
>
> Thank you for filing a new bug report with debbugs.gnu.org.
>
> This is an automatically generated reply to let you know your message
> has been received.
>
> Your message is being forwarded to the package maintainers and other
> interested parties for their attention; they will reply in due course.
>
> Your message has been sent to the package maintainer(s):
>  guix-patches <at> gnu.org
>
> If you wish to submit further information on this problem, please
> send it to 46234 <at> debbugs.gnu.org.
>
> Please do not send mail to help-debbugs <at> gnu.org unless you wish
> to report a problem with the Bug-tracking system.
>
> --
> 46234: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=46234
> GNU Bug Tracking System
> Contact help-debbugs <at> gnu.org with problems



-- 

… наш разум - превосходная объяснительная машина которая способна
найти смысл почти в чем угодно, истолковать любой феномен, но
совершенно не в состоянии принять мысль о непредсказуемости.

Information forwarded to guix-patches <at> gnu.org:
bug#46234; Package guix-patches. (Fri, 18 Jun 2021 14:43:02 GMT) Full text and rfc822 format available.

Message #11 received at 46234 <at> debbugs.gnu.org (full text, mbox):

From: Xinglu Chen <public <at> yoctocell.xyz>
To: Sharlatan Hellseher <sharlatanus <at> gmail.com>, 46234 <at> debbugs.gnu.org
Subject: Re: [bug#46234] [PATCH] Add new gopkg.in/yaml.v3
Date: Fri, 18 Jun 2021 16:42:43 +0200
[Message part 1 (text/plain, inline)]
On Mon, Feb 01 2021, Sharlatan Hellseher wrote:

> +(define-public go-gopkg-in-yaml-v3
> +  (package
> +    (name "go-gopkg-in-yaml-v3")
> +    (version "3")
> +    (source
> +      (origin
> +        (method git-fetch)
> +        (uri (git-reference
> +               (url "https://gopkg.in/yaml.v3.git")
> +               (commit (string-append "v" version))))
> +        (file-name (git-file-name name version))
> +        (sha256
> +         (base32 "06f4lnrp494wqaygv09dggr2dwf3z2bawqhnlnnwiamg5y787k4g"))))
> +    (build-system go-build-system)
> +    (arguments
> +     '(#:import-path "gopkg.in/yaml.v3"))
> +    (native-inputs
> +     `(("go-gopkg-in-check-v1" ,go-gopkg-in-check-v1)))
> +    (home-page "https://gopkg.in/yaml.v2")
                                         ^^
Shouldn’t this be “https://gopkg.in/yaml.v3”?

> +    (synopsis "YAML reader and writer for the Go language")
> +    (description
> +     "This package provides a Go library for encode and decode YAML
> +values.
> +
> +v3 specification difference:
> +@itemize
> +@item YAML 1.1 bools (yes/no, on/off) are supported as long as they are
> +being decoded into a typed bool value.  Otherwise they behave as a string.
> +Booleans in YAML 1.2 are true/false only.
> +
> +@item Octals encode and decode as 0777 per YAML 1.1, rather than 0o777 as
> +specified in YAML 1.2, because most parsers still use the old format.  Octals in
> +the 0o777 format are supported though, so new files work.
> +
> +@item Does not support base-60 floats.  These are gone from YAML 1.2, and were
> +actually never supported by this package as it's clearly a poor choice.
> +@end itemize\n")
> +
> +@end itemize\n")

Duplicate lines/syntax error.  I don’t think \n is needed either.

Otherwise, LGTM.
[signature.asc (application/pgp-signature, inline)]

Information forwarded to guix-patches <at> gnu.org:
bug#46234; Package guix-patches. (Fri, 18 Jun 2021 19:31:02 GMT) Full text and rfc822 format available.

Message #14 received at 46234 <at> debbugs.gnu.org (full text, mbox):

From: Sharlatan Hellseher <sharlatanus <at> gmail.com>
To: Xinglu Chen <public <at> yoctocell.xyz>
Cc: 46234 <at> debbugs.gnu.org
Subject: Re: [bug#46234] [PATCH] Add new gopkg.in/yaml.v3
Date: Fri, 18 Jun 2021 19:29:38 +0000
[Message part 1 (text/plain, inline)]
Hi Xinglu,

I've reviewed your comments and updated the patch, thanks for your time!

On Fri, 18 Jun 2021 at 14:42, Xinglu Chen <public <at> yoctocell.xyz> wrote:
>
> On Mon, Feb 01 2021, Sharlatan Hellseher wrote:
>
> > +(define-public go-gopkg-in-yaml-v3
> > +  (package
> > +    (name "go-gopkg-in-yaml-v3")
> > +    (version "3")
> > +    (source
> > +      (origin
> > +        (method git-fetch)
> > +        (uri (git-reference
> > +               (url "https://gopkg.in/yaml.v3.git")
> > +               (commit (string-append "v" version))))
> > +        (file-name (git-file-name name version))
> > +        (sha256
> > +         (base32 "06f4lnrp494wqaygv09dggr2dwf3z2bawqhnlnnwiamg5y787k4g"))))
> > +    (build-system go-build-system)
> > +    (arguments
> > +     '(#:import-path "gopkg.in/yaml.v3"))
> > +    (native-inputs
> > +     `(("go-gopkg-in-check-v1" ,go-gopkg-in-check-v1)))
> > +    (home-page "https://gopkg.in/yaml.v2")
>                                          ^^
> Shouldn’t this be “https://gopkg.in/yaml.v3”?
>
> > +    (synopsis "YAML reader and writer for the Go language")
> > +    (description
> > +     "This package provides a Go library for encode and decode YAML
> > +values.
> > +
> > +v3 specification difference:
> > +@itemize
> > +@item YAML 1.1 bools (yes/no, on/off) are supported as long as they are
> > +being decoded into a typed bool value.  Otherwise they behave as a string.
> > +Booleans in YAML 1.2 are true/false only.
> > +
> > +@item Octals encode and decode as 0777 per YAML 1.1, rather than 0o777 as
> > +specified in YAML 1.2, because most parsers still use the old format.  Octals in
> > +the 0o777 format are supported though, so new files work.
> > +
> > +@item Does not support base-60 floats.  These are gone from YAML 1.2, and were
> > +actually never supported by this package as it's clearly a poor choice.
> > +@end itemize\n")
> > +
> > +@end itemize\n")
>
> Duplicate lines/syntax error.  I don’t think \n is needed either.
>
> Otherwise, LGTM.



-- 

… наш разум - превосходная объяснительная машина которая способна
найти смысл почти в чем угодно, истолковать любой феномен, но
совершенно не в состоянии принять мысль о непредсказуемости.
[0001-gnu-Add-gopkg.in-yaml.v3.patch (text/x-patch, attachment)]

Information forwarded to guix-patches <at> gnu.org:
bug#46234; Package guix-patches. (Sat, 19 Jun 2021 08:32:01 GMT) Full text and rfc822 format available.

Message #17 received at 46234 <at> debbugs.gnu.org (full text, mbox):

From: Xinglu Chen <public <at> yoctocell.xyz>
To: Sharlatan Hellseher <sharlatanus <at> gmail.com>
Cc: 46234 <at> debbugs.gnu.org
Subject: Re: [bug#46234] [PATCH] Add new gopkg.in/yaml.v3
Date: Sat, 19 Jun 2021 10:31:40 +0200
[Message part 1 (text/plain, inline)]
On Fri, Jun 18 2021, Sharlatan Hellseher wrote:

> Hi Xinglu,
>
> I've reviewed your comments and updated the patch, thanks for your
> time!

You are welcome!  The patch looks good to me, but you will have to wait
for someone with commit access to apply it :)

[signature.asc (application/pgp-signature, inline)]

Reply sent to Nicolas Goaziou <mail <at> nicolasgoaziou.fr>:
You have taken responsibility. (Tue, 22 Jun 2021 08:54:02 GMT) Full text and rfc822 format available.

Notification sent to Sharlatan Hellseher <sharlatanus <at> gmail.com>:
bug acknowledged by developer. (Tue, 22 Jun 2021 08:54:02 GMT) Full text and rfc822 format available.

Message #22 received at 46234-done <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Sharlatan Hellseher <sharlatanus <at> gmail.com>
Cc: Xinglu Chen <public <at> yoctocell.xyz>, 46234-done <at> debbugs.gnu.org
Subject: Re: [bug#46234] [PATCH] Add new gopkg.in/yaml.v3
Date: Tue, 22 Jun 2021 10:53:48 +0200
Hello,

Sharlatan Hellseher <sharlatanus <at> gmail.com> writes:

Thank you for the patch, and thanks Xinglu for the review.

I applied your patch with the following changes:

> gnu: Add gopkg.in/yaml.v3

I added a final full stop.


> +        (uri (git-reference
> +               (url "https://gopkg.in/yaml.v3.git")

I removed the ".git" suffix.

> +    (description
> +     "This package provides a Go library for encode and decode YAML
> +values.
> +
> +v3 specification difference:
> +@itemize
> +@item YAML 1.1 bools (yes/no, on/off) are supported as long as they are
> +being decoded into a typed bool value.  Otherwise they behave as a string.
> +Booleans in YAML 1.2 are true/false only.
> +
> +@item Octals encode and decode as 0777 per YAML 1.1, rather than 0o777 as
> +specified in YAML 1.2, because most parsers still use the old format.  Octals in
> +the 0o777 format are supported though, so new files work.
> +
> +@item Does not support base-60 floats.  These are gone from YAML 1.2, and were
> +actually never supported by this package as it's clearly a poor choice.
> +@end itemize")

I shortened the description.

Regards,
-- 
Nicolas Goaziou




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Tue, 20 Jul 2021 11:24:06 GMT) Full text and rfc822 format available.

This bug report was last modified 2 years and 253 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.