GNU bug report logs -
#46235
[PATCH] gnu: emacs-rg: Fix use on remote systems.
Previous Next
Reported by: Clément Lassieur <clement <at> lassieur.org>
Date: Mon, 1 Feb 2021 12:48:02 UTC
Severity: normal
Tags: patch
Done: Clément Lassieur <clement <at> lassieur.org>
Bug is archived. No further changes may be made.
To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 46235 in the body.
You can then email your comments to 46235 AT debbugs.gnu.org in the normal way.
Toggle the display of automated, internal messages from the tracker.
Report forwarded
to
guix-patches <at> gnu.org
:
bug#46235
; Package
guix-patches
.
(Mon, 01 Feb 2021 12:48:02 GMT)
Full text and
rfc822 format available.
Acknowledgement sent
to
Clément Lassieur <clement <at> lassieur.org>
:
New bug report received and forwarded. Copy sent to
guix-patches <at> gnu.org
.
(Mon, 01 Feb 2021 12:48:02 GMT)
Full text and
rfc822 format available.
Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):
* gnu/packages/emacs-xyz.scm (emacs-rg)[inputs]: Remove. Move ripgrep to...
[propagated-inputs]: ... here. This also gives access to ripgrep's manual.
[arguments]: Replace the full path with the executable name.
---
gnu/packages/emacs-xyz.scm | 13 ++++++-------
1 file changed, 6 insertions(+), 7 deletions(-)
diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 28c7b41d79..ba1865d05f 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -19,7 +19,7 @@
;;; Copyright © 2016, 2017, 2018, 2019, 2020 Arun Isaac <arunisaac <at> systemreboot.net>
;;; Copyright © 2017 Christopher Baines <mail <at> cbaines.net>
;;; Copyright © 2017, 2018, 2019, 2020 Mathieu Othacehe <m.othacehe <at> gmail.com>
-;;; Copyright © 2017, 2018, 2019, 2020 Clément Lassieur <clement <at> lassieur.org>
+;;; Copyright © 2017, 2018, 2019, 2020, 2021 Clément Lassieur <clement <at> lassieur.org>
;;; Copyright © 2017 Vasile Dumitrascu <va511e <at> yahoo.com>
;;; Copyright © 2017, 2018 Kyle Meyer <kyle <at> kyleam.com>
;;; Copyright © 2017 Kei Kebreau <kkebreau <at> posteo.net>
@@ -3848,19 +3848,18 @@ result.")
(arguments
'(#:phases
(modify-phases %standard-phases
- (add-after 'unpack 'hardcode-rg-path
- ;; Hardcode the path to ripgrep.
+ (add-after 'unpack 'remove-rg-path
+ ;; Remove the path to ripgrep so that it works on remote systems.
(lambda _
(let ((file "rg.el"))
(chmod file #o644)
(emacs-substitute-sexps file
- ("(defcustom rg-executable" (which "rg")))))))))
+ ("(defcustom rg-executable" "rg"))))))))
(propagated-inputs
`(("emacs-s" ,emacs-s)
("emacs-transient" ,emacs-transient)
- ("emacs-wgrep" ,emacs-wgrep)))
- (inputs
- `(("ripgrep" ,ripgrep)))
+ ("emacs-wgrep" ,emacs-wgrep)
+ ("ripgrep" ,ripgrep)))
(home-page "https://rgel.readthedocs.io/en/latest/")
(synopsis "Search tool based on @code{ripgrep}")
(description
--
2.30.0
Information forwarded
to
guix-patches <at> gnu.org
:
bug#46235
; Package
guix-patches
.
(Tue, 02 Feb 2021 08:28:02 GMT)
Full text and
rfc822 format available.
Message #8 received at 46235 <at> debbugs.gnu.org (full text, mbox):
Hello,
Clément Lassieur <clement <at> lassieur.org> writes:
> * gnu/packages/emacs-xyz.scm (emacs-rg)[inputs]: Remove. Move ripgrep to...
> [propagated-inputs]: ... here. This also gives access to ripgrep's manual.
> [arguments]: Replace the full path with the executable name.
LGTM!
Regards,
--
Nicolas Goaziou
Reply sent
to
Clément Lassieur <clement <at> lassieur.org>
:
You have taken responsibility.
(Tue, 02 Feb 2021 08:57:01 GMT)
Full text and
rfc822 format available.
Notification sent
to
Clément Lassieur <clement <at> lassieur.org>
:
bug acknowledged by developer.
(Tue, 02 Feb 2021 08:57:01 GMT)
Full text and
rfc822 format available.
Message #13 received at 46235-done <at> debbugs.gnu.org (full text, mbox):
Nicolas Goaziou <mail <at> nicolasgoaziou.fr> writes:
> Hello,
>
> Clément Lassieur <clement <at> lassieur.org> writes:
>
>> * gnu/packages/emacs-xyz.scm (emacs-rg)[inputs]: Remove. Move ripgrep to...
>> [propagated-inputs]: ... here. This also gives access to ripgrep's manual.
>> [arguments]: Replace the full path with the executable name.
>
> LGTM!
>
> Regards,
Thanks! Pushed
bug archived.
Request was from
Debbugs Internal Request <help-debbugs <at> gnu.org>
to
internal_control <at> debbugs.gnu.org
.
(Tue, 02 Mar 2021 12:24:08 GMT)
Full text and
rfc822 format available.
This bug report was last modified 3 years and 28 days ago.
Previous Next
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997,2003 nCipher Corporation Ltd,
1994-97 Ian Jackson.