GNU bug report logs - #46249
[PATCH] Update documented default PostgreSQL socket-directory

Previous Next

Package: guix-patches;

Reported by: Ben Sturmfels <ben <at> sturm.com.au>

Date: Tue, 2 Feb 2021 00:09:01 UTC

Severity: normal

Tags: patch

Done: Mathieu Othacehe <othacehe <at> gnu.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 46249 in the body.
You can then email your comments to 46249 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#46249; Package guix-patches. (Tue, 02 Feb 2021 00:09:01 GMT) Full text and rfc822 format available.

Acknowledgement sent to Ben Sturmfels <ben <at> sturm.com.au>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Tue, 02 Feb 2021 00:09:01 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Ben Sturmfels <ben <at> sturm.com.au>
To: guix-patches <at> gnu.org
Subject: [PATCH] Update documented default PostgreSQL socket-directory
Date: Tue, 02 Feb 2021 11:08:12 +1100
[Message part 1 (text/plain, inline)]
Hi Folks,

It looks like the documented default for PostgreSQL's socket-directory
variable should be "/var/run/postgresql", when it's currently
"/var/lib/postgresql" (the data directory). I've attached a patch.
Here's the original commit (thanks lfam for the IRC help):

https://git.savannah.gnu.org/cgit/guix.git/commit/?id=6c0679215f4ffa534c1eb2e8c8a6e043a0c993fe

Also noticed that since a recent reconfigure, my `psql` and `createdb`
commands now need an explicit `-h /var/run/postgresql` argument to
connect to the local database where one wasn't needed before - they look
in /tmp by default.

Regards,
Ben
[postgres_update_socket_directory.patch (text/x-patch, inline)]
From bfd7c9f015718eadd62bac0e85aa4a3b38a556d4 Mon Sep 17 00:00:00 2001
From: Ben Sturmfels <ben <at> sturm.com.au>
Date: Tue, 2 Feb 2021 10:49:21 +1100
Subject: [PATCH] services: postgresql: Update documented socket directory to
 match code.

* doc/guix.texi (Database Services): Update it.
---
 doc/guix.texi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/doc/guix.texi b/doc/guix.texi
index beff276f9d..b75c4f505c 100644
--- a/doc/guix.texi
+++ b/doc/guix.texi
@@ -19531,7 +19531,7 @@ configuration.
 @item @code{ident-file} (default: @code{%default-postgres-ident})
 Filename or G-expression for the user name mapping configuration.
 
-@item @code{socket-directory} (default: @code{"/var/lib/postgresql"})
+@item @code{socket-directory} (default: @code{"/var/run/postgresql"})
 Specifies the directory of the Unix-domain socket(s) on which PostgreSQL
 is to listen for connections from client applications.  If set to
 @code{#false} PostgreSQL does not listen on any Unix-domain sockets, in
-- 
2.30.0


Information forwarded to guix-patches <at> gnu.org:
bug#46249; Package guix-patches. (Tue, 02 Feb 2021 08:32:01 GMT) Full text and rfc822 format available.

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Mathieu Othacehe <othacehe <at> gnu.org>
To: guix-patches--- via <guix-patches <at> gnu.org>
Cc: Ben Sturmfels <ben <at> sturm.com.au>, 46249-done <at> debbugs.gnu.org
Subject: Re: [bug#46249] [PATCH] Update documented default PostgreSQL
 socket-directory
Date: Tue, 02 Feb 2021 09:31:35 +0100
Hey Ben,

> It looks like the documented default for PostgreSQL's socket-directory
> variable should be "/var/run/postgresql", when it's currently
> "/var/lib/postgresql" (the data directory). I've attached a patch.
> Here's the original commit (thanks lfam for the IRC help):

That's a dumb mistake on my part, thanks for fixing it.

> https://git.savannah.gnu.org/cgit/guix.git/commit/?id=6c0679215f4ffa534c1eb2e8c8a6e043a0c993fe
>
> Also noticed that since a recent reconfigure, my `psql` and `createdb`
> commands now need an explicit `-h /var/run/postgresql` argument to
> connect to the local database where one wasn't needed before - they look
> in /tmp by default.

Yes when the socket directory is enabled in PostgreSQL those tools try
to use it but with the default directory set to "/tmp". I have pushed a
patch on core-updates to set the default socket directory to
"/var/run/postgresql" like most of the other distributions.

In the meantime you can set the "socket-directory" field of
"postgresql-config-file" to #f to restore the previous behaviour.

Thanks,

Mathieu




Reply sent to Mathieu Othacehe <othacehe <at> gnu.org>:
You have taken responsibility. (Tue, 02 Feb 2021 08:32:02 GMT) Full text and rfc822 format available.

Notification sent to Ben Sturmfels <ben <at> sturm.com.au>:
bug acknowledged by developer. (Tue, 02 Feb 2021 08:32:02 GMT) Full text and rfc822 format available.

Information forwarded to guix-patches <at> gnu.org:
bug#46249; Package guix-patches. (Tue, 02 Feb 2021 11:21:02 GMT) Full text and rfc822 format available.

Message #16 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Ben Sturmfels <ben <at> sturm.com.au>
To: Mathieu Othacehe <othacehe <at> gnu.org>
Cc: 46249-done <at> debbugs.gnu.org, guix-patches--- via <guix-patches <at> gnu.org>,
 Ben Sturmfels <ben <at> sturm.com.au>
Subject: Re: [bug#46249] [PATCH] Update documented default PostgreSQL
 socket-directory
Date: Tue, 02 Feb 2021 22:20:18 +1100
On Tue, 02 Feb 2021, Mathieu Othacehe wrote:

> Hey Ben,
>
>> It looks like the documented default for PostgreSQL's socket-directory
>> variable should be "/var/run/postgresql", when it's currently
>> "/var/lib/postgresql" (the data directory). I've attached a patch.
>> Here's the original commit (thanks lfam for the IRC help):
>
> That's a dumb mistake on my part, thanks for fixing it.
>
>> https://git.savannah.gnu.org/cgit/guix.git/commit/?id=6c0679215f4ffa534c1eb2e8c8a6e043a0c993fe
>>
>> Also noticed that since a recent reconfigure, my `psql` and `createdb`
>> commands now need an explicit `-h /var/run/postgresql` argument to
>> connect to the local database where one wasn't needed before - they look
>> in /tmp by default.
>
> Yes when the socket directory is enabled in PostgreSQL those tools try
> to use it but with the default directory set to "/tmp". I have pushed a
> patch on core-updates to set the default socket directory to
> "/var/run/postgresql" like most of the other distributions.
>
> In the meantime you can set the "socket-directory" field of
> "postgresql-config-file" to #f to restore the previous behaviour.

Thanks for the quick follow-up Mathieu, that's very helpful.

While I'm bothering you, those comments "XXX: Remove when postgresql
default socket directory is changed to /var/run/postgresql" looked like
they could be might be redundant now. Is that the case?

Thanks again,
Ben




Information forwarded to guix-patches <at> gnu.org:
bug#46249; Package guix-patches. (Tue, 02 Feb 2021 11:21:02 GMT) Full text and rfc822 format available.

bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Tue, 02 Mar 2021 12:24:09 GMT) Full text and rfc822 format available.

This bug report was last modified 3 years and 27 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.