GNU bug report logs - #46300
28.0.50; Move revert-buffer global binding into a prefix map

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 46300 in the body.
You can then email your comments to 46300 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Sean Whitton <spwhitton <at> spwhitton.name>
To: bug-gnu-emacs <at> gnu.org
Cc: Eli Zaretskii <eliz <at> gnu.org>, Gregory Heytings <gregory <at> heytings.org>,
 Lars Ingebrigtsen <larsi <at> gnus.org>, emacs-devel <at> gnu.org
Subject: 28.0.50; Move revert-buffer global binding into a prefix map
Date: Thu, 04 Feb 2021 11:08:59 -0700

[Message part 1 (text/plain, inline)]

control: tag -1 + patch

On Thu 04 Feb 2021 at 05:46PM +01, Lars Ingebrigtsen wrote:

> Gregory Heytings <gregory <at> heytings.org> writes:
>
>> You forgot the proposal to which the mail you are replying to
>> explicitly refers.  So I'll copy it here again: it is to make "C-x g"
>> a keymap for buffer-related operations, with in particular "C-x g r"
>> bound to revert-buffer:
>>
>> C-x g c = clone-buffer
>> C-x g d = diff-buffers
>> C-x g f = fit-frame-to-buffer
>> C-x g h = hexl-mode
>> C-x g i = insert-buffer
>> C-x g l = font-lock-mode
>> C-x g n = rename-buffer
>> C-x g r = revert-buffer
>> C-x g R = revert-buffer-with-fine-grain
>> C-x g t = toggle-truncate-lines
>
> Of the alternative key bindings proposed, I like this the best.  I'd
> prefer `C-x g g' for revert-buffer, though -- it's more in like with the
> `g' binding in `special-mode-map', and `revert-buffer' is a command
> you're likely to want to execute a number of times (in some cases),
> while the rest of these are less keyboard-mashey.

Here's a patch doing that, since this seems like a solution which
satisfies most.  Exactly what else to bind into that map I leave to
others, for now, anyway.

-- 
Sean Whitton

[0001-Move-revert-buffer-global-binding-to-C-x-g-g.patch (text/x-diff, attachment)]

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Drew Adams <drew.adams <at> oracle.com>
To: Sean Whitton <spwhitton <at> spwhitton.name>, "bug-gnu-emacs <at> gnu.org"
 <bug-gnu-emacs <at> gnu.org>
Cc: Lars Ingebrigtsen <larsi <at> gnus.org>, Eli Zaretskii <eliz <at> gnu.org>,
 Gregory Heytings <gregory <at> heytings.org>,
 "emacs-devel <at> gnu.org" <emacs-devel <at> gnu.org>
Subject: RE: [External] : 28.0.50; Move revert-buffer global binding into a
 prefix map
Date: Thu, 4 Feb 2021 19:49:46 +0000

> this seems like a solution which satisfies most.

Most what?  Most users?  Most users polled?

Message #11 received at 46300 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Sean Whitton <spwhitton <at> spwhitton.name>
Cc: 46300 <at> debbugs.gnu.org, Gregory Heytings <gregory <at> heytings.org>,
 Eli Zaretskii <eliz <at> gnu.org>, emacs-devel <at> gnu.org
Subject: Re: bug#46300: 28.0.50; Move revert-buffer global binding into a
 prefix map
Date: Sun, 07 Feb 2021 13:31:42 +0100

Sean Whitton <spwhitton <at> spwhitton.name> writes:

> Here's a patch doing that, since this seems like a solution which
> satisfies most.  Exactly what else to bind into that map I leave to
> others, for now, anyway.

Thanks; applied to Emacs 28 (but I changed the binding to `C-x x g' to
avoid the Magit collision).

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #18 received at 46300 <at> debbugs.gnu.org (full text, mbox):

From: Drew Adams <drew.adams <at> oracle.com>
To: Lars Ingebrigtsen <larsi <at> gnus.org>, Sean Whitton <spwhitton <at> spwhitton.name>
Cc: "46300 <at> debbugs.gnu.org" <46300 <at> debbugs.gnu.org>,
 Eli Zaretskii <eliz <at> gnu.org>, Gregory Heytings <gregory <at> heytings.org>,
 "emacs-devel <at> gnu.org" <emacs-devel <at> gnu.org>
Subject: RE: [External] : Re: bug#46300: 28.0.50; Move revert-buffer global
 binding into a prefix map
Date: Sun, 7 Feb 2021 18:41:01 +0000

> Thanks; applied to Emacs 28 (but I changed the
> binding to `C-x x g' to avoid the Magit collision).

You traded a Bookmark+ collision for a Magit collision.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.