Received: (at 46313) by debbugs.gnu.org; 7 Feb 2021 16:57:27 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sun Feb 07 11:57:27 2021 Received: from localhost ([127.0.0.1]:48608 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1l8nNG-0001cz-W8 for submit <at> debbugs.gnu.org; Sun, 07 Feb 2021 11:57:27 -0500 Received: from mail.zaclys.net ([178.33.93.72]:37087) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <lle-bout@HIDDEN>) id 1l8nNE-0001cl-5k for 46313 <at> debbugs.gnu.org; Sun, 07 Feb 2021 11:57:25 -0500 Received: from [192.168.0.27] (82-64-145-38.subs.proxad.net [82.64.145.38]) (authenticated bits=0) by mail.zaclys.net (8.14.7/8.14.7) with ESMTP id 117GvGgv047687 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Sun, 7 Feb 2021 17:57:17 +0100 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.zaclys.net 117GvGgv047687 Authentication-Results: mail.zaclys.net; dmarc=fail (p=reject dis=none) header.from=zaclys.net Authentication-Results: mail.zaclys.net; spf=fail smtp.mailfrom=lle-bout@HIDDEN DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zaclys.net; s=default; t=1612717037; bh=BVAcxoazhp6HosKZPmKNqQtyYGN2l8nyjaCJWrwFpuw=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=oD5EE5yicDRr8/JrzUTvyCJfLSz3syIJDidEzZFkDy2epfwgcaQRDfvbyk/ROD2nr 1T4TAVzjfSXtrTz4cULDW9Z+jqVIHptld6hTZkc0GfGeyAQX3Gg3HCEnl5bGRgQWR2 5J8+JYkPhH1pyehJNtcsMeSyTMWbwufAPV3+/uNA= Message-ID: <94473bccc8667f30694bd17a6cdf99eac0ca145b.camel@HIDDEN> Subject: Re: [bug#46313] [PATCH] gnu: Add chiaki. From: =?ISO-8859-1?Q?L=E9o?= Le Bouter <lle-bout@HIDDEN> To: Nicolas Goaziou <mail@HIDDEN> Date: Sun, 07 Feb 2021 17:57:11 +0100 In-Reply-To: <87eehsusaa.fsf@HIDDEN> References: <20210205031731.27620-1-lle-bout@HIDDEN> <87eehsusaa.fsf@HIDDEN> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-wmVZmiIeS7R9oMqkm8hb" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 46313 Cc: 46313 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) --=-wmVZmiIeS7R9oMqkm8hb Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sun, 2021-02-07 at 10:43 +0100, Nicolas Goaziou wrote: > Hello, Hello! >=20 > L=C3=A9o Le Bouter via Guix-patches via <guix-patches@HIDDEN> writes: >=20 > > * gnu/packages/games.scm (chiaki): New variable. >=20 > Thank you. Some comments follow. >=20 > > + (recursive? #t))) >=20 > Do you know what sub-modules are being pulled? Could we unbundle them > instead? There is gf-complete, jerasure and nanopb. Will have to look for unbundling. >=20 > > + (synopsis "Free and Open Source PlayStation Remote Play > > Client") >=20 > Please remove "Free" and "Open Source": everything is in Guix. Also, > synopsis should not use titlecase: >=20 > "PlayStation Remote Play client" >=20 > > + (description "Chiaki is a Free and Open Source Software Client > > for > > +PlayStation 4 and PlayStation 5 Remote Play.") >=20 > See above. Also, couldyou expound a bit the description? >=20 Okay, merely copied the synopsis and description from the original project. > > + (license > > + (license:fsdg-compatible >=20 > It should be fsf-free instead of fsdg-compatible. >=20 > > + "file://LICENSES/AGPL-3.0-only-OpenSSL.txt" > > + "AGPL-3.0-only-OpenSSL")))) >=20 The thing is, the FSF does not approve that particular variant of the license with OpenSSL exception so that's why I only specified it is compatible. > I think the correct string would be "AGPL-3.0 WITH OpenSSL exception" > but I wonder if Guix cares about the exception. >=20 > Could you send an updated patch? >=20 ASAP. >=20 > Regards, Thank you. --=-wmVZmiIeS7R9oMqkm8hb Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEFIvLi9gL+xax3g6RRaix6GvNEKYFAmAgG+cACgkQRaix6GvN EKY1mBAAiA3GrBlDUM9IJEg+T7VAxn0cQfBxlvBq681srVi8pZaSM15vZe9R5bjw /4uJYrdv2Qu6ZVv3FGqLVvKD6aQL7Rp397GUpmJDBjaHZDCUds1NerZcbmJ3Cvof P2j0g/HqZK8GrtFbopk1XCDIsdzOxD6cW9FAcZgt4NbN9i4M7sNLy4RIV390gdc0 ierIiUDEu2DdTwMcdYAH3Bf/8Vhvrfif9dQ1XGwOduqvO/XDQkeF615zCbauc0pl ah9kon7ntc1NqAJLMwQuAAiHTeYwoV31EsJD7P6FGZYIstRcR2EHM/f+ueE/+Fwp XCOCV95VT0XgNW2a1SVKGzWARNDiuMwN7TmJx2twMB8D5z4swjN7veGlCQPKNiHf eMgOXTcdPOJApkeACn0CNir9k+X+qAJbaMrHnqAxl0eErZH3oH+E7ArO9x7vpKmE d5zmXzAHeVqfpTZtslBVg78dI3CW/tMmhMsXuz29Q4qbq6TNKAUBACQfHfmfWYtD IUBkky7qvN9X6UjEeY6H11JZFOhw1hPThGhMWX3sM3fD10JgbiaLrqEFYK8YsxeN gk8eZ3mj4tvOHPwBA6GOgeAh2wNNmP+2xWqWm8IZQ3tv4ucw7nRYuuABbDCrbjVj be8Vju0yGty5AbCex6w+fRZ96UQi194WlIE0EDzcXfOy5KtmESk= =OuDn -----END PGP SIGNATURE----- --=-wmVZmiIeS7R9oMqkm8hb--
guix-patches@HIDDEN:bug#46313; Package guix-patches.
Full text available.
Received: (at 46313) by debbugs.gnu.org; 7 Feb 2021 09:43:52 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Feb 07 04:43:52 2021
Received: from localhost ([127.0.0.1]:46899 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1l8gbg-0002v5-3T
for submit <at> debbugs.gnu.org; Sun, 07 Feb 2021 04:43:52 -0500
Received: from relay10.mail.gandi.net ([217.70.178.230]:34205)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <mail@HIDDEN>) id 1l8gbd-0002uq-Ip
for 46313 <at> debbugs.gnu.org; Sun, 07 Feb 2021 04:43:50 -0500
Received: from localhost (40-67.ipv4.commingeshautdebit.fr [185.131.40.67])
(Authenticated sender: admin@HIDDEN)
by relay10.mail.gandi.net (Postfix) with ESMTPSA id 555D9240003;
Sun, 7 Feb 2021 09:43:42 +0000 (UTC)
From: Nicolas Goaziou <mail@HIDDEN>
To: =?utf-8?Q?L=C3=A9o?= Le Bouter <lle-bout@HIDDEN>
Subject: Re: [bug#46313] [PATCH] gnu: Add chiaki.
References: <20210205031731.27620-1-lle-bout@HIDDEN>
Date: Sun, 07 Feb 2021 10:43:41 +0100
In-Reply-To: <20210205031731.27620-1-lle-bout@HIDDEN> (=?utf-8?Q?=22L?=
=?utf-8?Q?=C3=A9o?= Le Bouter via
Guix-patches via"'s message of "Fri, 5 Feb 2021 04:17:31 +0100")
Message-ID: <87eehsusaa.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 46313
Cc: 46313 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)
Hello,
L=C3=A9o Le Bouter via Guix-patches via <guix-patches@HIDDEN> writes:
> * gnu/packages/games.scm (chiaki): New variable.
Thank you. Some comments follow.
> + (recursive? #t)))
Do you know what sub-modules are being pulled? Could we unbundle them
instead?
> + (synopsis "Free and Open Source PlayStation Remote Play Client")
Please remove "Free" and "Open Source": everything is in Guix. Also,
synopsis should not use titlecase:
"PlayStation Remote Play client"
> + (description "Chiaki is a Free and Open Source Software Client for
> +PlayStation 4 and PlayStation 5 Remote Play.")
See above. Also, couldyou expound a bit the description?
> + (license
> + (license:fsdg-compatible
It should be fsf-free instead of fsdg-compatible.
> + "file://LICENSES/AGPL-3.0-only-OpenSSL.txt"
> + "AGPL-3.0-only-OpenSSL"))))
I think the correct string would be "AGPL-3.0 WITH OpenSSL exception"
but I wonder if Guix cares about the exception.
Could you send an updated patch?
Regards,
--=20
Nicolas Goaziou
guix-patches@HIDDEN:bug#46313; Package guix-patches.
Full text available.
Received: (at submit) by debbugs.gnu.org; 5 Feb 2021 03:18:07 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Feb 04 22:18:07 2021
Received: from localhost ([127.0.0.1]:42552 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1l7rdG-00057o-OS
for submit <at> debbugs.gnu.org; Thu, 04 Feb 2021 22:18:07 -0500
Received: from lists.gnu.org ([209.51.188.17]:56872)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <lle-bout@HIDDEN>) id 1l7rdD-00057e-HE
for submit <at> debbugs.gnu.org; Thu, 04 Feb 2021 22:18:05 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10]:57426)
by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <lle-bout@HIDDEN>)
id 1l7rd8-0004bd-NI
for guix-patches@HIDDEN; Thu, 04 Feb 2021 22:18:03 -0500
Received: from mail.zaclys.net ([178.33.93.72]:45943)
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <lle-bout@HIDDEN>)
id 1l7rd3-0001Jn-7M
for guix-patches@HIDDEN; Thu, 04 Feb 2021 22:17:58 -0500
Received: from localhost.localdomain
(lfbn-idf3-1-89-224.w81-249.abo.wanadoo.fr [81.249.216.224])
(authenticated bits=0)
by mail.zaclys.net (8.14.7/8.14.7) with ESMTP id 1153HaSx033636
(version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NO);
Fri, 5 Feb 2021 04:17:45 +0100
DMARC-Filter: OpenDMARC Filter v1.3.2 mail.zaclys.net 1153HaSx033636
Authentication-Results: mail.zaclys.net;
dmarc=fail (p=reject dis=none) header.from=zaclys.net
Authentication-Results: mail.zaclys.net;
spf=fail smtp.mailfrom=lle-bout@HIDDEN
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zaclys.net;
s=default; t=1612495065;
bh=azIDhuKToYz/XRQhOUYrpXhSYA9kCR0lIxcb0BiyPNw=;
h=From:To:Cc:Subject:Date:From;
b=Emu53OCbC6q9WcWCj5nNBCTnexlPcKRolJu+AVYRbiPk02rQxCv9URV9IZ+cbgV65
QomaqS6PF8Qy9aJznx2reqqZbOq/267Hmf5/DvTCdg5TCQCfVY1B6dhP5M/O+juQNY
bbZc/WQw8wa5jNvm0XiqmvWccDKjBNr1MljCx1XY=
From: =?UTF-8?q?L=C3=A9o=20Le=20Bouter?= <lle-bout@HIDDEN>
To: guix-patches@HIDDEN
Subject: [PATCH] gnu: Add chiaki.
Date: Fri, 5 Feb 2021 04:17:31 +0100
Message-Id: <20210205031731.27620-1-lle-bout@HIDDEN>
X-Mailer: git-send-email 2.30.0
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Received-SPF: pass client-ip=178.33.93.72; envelope-from=lle-bout@HIDDEN;
helo=mail.zaclys.net
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001,
SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -1.3 (-)
X-Debbugs-Envelope-To: submit
Cc: =?UTF-8?q?L=C3=A9o=20Le=20Bouter?= <lle-bout@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.3 (--)
* gnu/packages/games.scm (chiaki): New variable.
---
gnu/packages/games.scm | 39 +++++++++++++++++++++++++++++++++++++++
1 file changed, 39 insertions(+)
diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm
index e3e18bf09e..3d6ba05a39 100644
--- a/gnu/packages/games.scm
+++ b/gnu/packages/games.scm
@@ -12178,3 +12178,42 @@ game FPS.")
implemented using ncurses user interface. An SDL graphical version is also
available.")
(license license:gpl3+)))
+
+(define-public chiaki
+ (package
+ (name "chiaki")
+ (version "2.1.1")
+ (source
+ (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url "https://git.sr.ht/~thestr4ng3r/chiaki")
+ (commit (string-append "v" version))
+ (recursive? #t)))
+ (file-name (git-file-name name version))
+ (sha256
+ (base32
+ "1kjaahv80p040wicj1a4ac1j2zsg0dbbf60a9aapn45qlkq80h2n"))))
+ (build-system cmake-build-system)
+ (native-inputs
+ `(("python" ,python)
+ ("protobuf" ,protobuf)
+ ("pkg-config" ,pkg-config)
+ ("python-protobuf" ,python-protobuf)))
+ (inputs
+ `(("ffmpeg" ,ffmpeg)
+ ("opus" ,opus)
+ ("openssl" ,openssl)
+ ("libevdev" ,libevdev)
+ ("qtbase" ,qtbase)
+ ("qtmultimedia" ,qtmultimedia)
+ ("qtsvg" ,qtsvg)
+ ("sdl2" ,sdl2)))
+ (home-page "https://git.sr.ht/~thestr4ng3r/chiaki")
+ (synopsis "Free and Open Source PlayStation Remote Play Client")
+ (description "Chiaki is a Free and Open Source Software Client for
+PlayStation 4 and PlayStation 5 Remote Play.")
+ (license
+ (license:fsdg-compatible
+ "file://LICENSES/AGPL-3.0-only-OpenSSL.txt"
+ "AGPL-3.0-only-OpenSSL"))))
--
2.30.0
Léo Le Bouter <lle-bout@HIDDEN>:guix-patches@HIDDEN.
Full text available.guix-patches@HIDDEN:bug#46313; Package guix-patches.
Full text available.
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.