GNU bug report logs - #46391
[PATCH 0/1] Canonicalize-path load-path option

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 46391 in the body.
You can then email your comments to 46391 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: zimoun <zimon.toutoune <at> gmail.com>
To: guix-patches <at> gnu.org
Cc: zimoun <zimon.toutoune <at> gmail.com>
Subject: [PATCH 0/1] Canonicalize-path load-path option
Date: Tue,  9 Feb 2021 01:40:11 +0100

Hi,

This fixes <https://bugs.gnu.org/46390>.

The test suite does not check relative path for the load-path option.
I do not know what is the best to add a test about that.

Last, I remember discussions about absolute/relative path and I do not know
if this 'canonicalize-path' addition is the best fix here.


All the best,
simon


zimoun (1):
  scripts: build: Fix relative load-path.

 guix/scripts/build.scm | 16 +++++++++-------
 1 file changed, 9 insertions(+), 7 deletions(-)


base-commit: 4cd8bab7d4b345c5538b8d039d84a957df7a235f
-- 
2.29.2

Message #10 received at 46391-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: zimoun <zimon.toutoune <at> gmail.com>
Cc: 46391-done <at> debbugs.gnu.org
Subject: Re: bug#46391: [PATCH 0/1] Canonicalize-path load-path option
Date: Wed, 24 Feb 2021 23:46:59 +0100

Hi!

zimoun <zimon.toutoune <at> gmail.com> skribis:

> This fixes <https://bugs.gnu.org/46390>.
>
> The test suite does not check relative path for the load-path option.
> I do not know what is the best to add a test about that.
>
> Last, I remember discussions about absolute/relative path and I do not know
> if this 'canonicalize-path' addition is the best fix here.
>
>
> All the best,
> simon
>
>
> zimoun (1):
>   scripts: build: Fix relative load-path.
>
>  guix/scripts/build.scm | 16 +++++++++-------
>  1 file changed, 9 insertions(+), 7 deletions(-)

I’m discovering this after having independently addreses #46390, sorry
about that!  (Perhaps we should always send patches that fix bugs to the
corresponding bug report rather than/in addition to guix-patches?)

Let me know what you think.

Thanks,
Ludo’.

Message #13 received at 46391-done <at> debbugs.gnu.org (full text, mbox):

From: zimoun <zimon.toutoune <at> gmail.com>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 46391-done <at> debbugs.gnu.org
Subject: Re: bug#46391: [PATCH 0/1] Canonicalize-path load-path option
Date: Thu, 25 Feb 2021 00:04:07 +0100

Hi Ludo,

On Wed, 24 Feb 2021 at 23:46, Ludovic Courtès <ludo <at> gnu.org> wrote:

> I’m discovering this after having independently addreses #46390, sorry
> about that!  (Perhaps we should always send patches that fix bugs to the
> corresponding bug report rather than/in addition to guix-patches?)

Anyway, because your patch is better than mine. :-)

In general, I try to at least mention in bug-guix the number from
guix-patches.  Sometimes, I directly send the patch to bug-guix.  It
depends on my mood I guess. :-)

Well, I do not have an opinion.

Maybe tiny patch (like this) that fixes bug should be sent to the
corresponding bug report.  And larger patches should be sent to
guix-patches; it eases to keep separated the discussion about the bug
and about the patches, IMHO.


Cheers,
simon

Message #16 received at 46391-done <at> debbugs.gnu.org (full text, mbox):

From: zimoun <zimon.toutoune <at> gmail.com>
To: 46391-done <at> debbugs.gnu.org
Subject: Re: [bug#46391] [PATCH 0/1] Canonicalize-path load-path option
Date: Wed, 24 Feb 2021 13:18:47 +0100

Hi,

On Tue, 09 Feb 2021 at 01:40, zimoun <zimon.toutoune <at> gmail.com> wrote:

> This fixes <https://bugs.gnu.org/46390>.

Fixed by 9a38bed2cf32e9462badfa43e74cdd4580e804fc.


> The test suite does not check relative path for the load-path option.
> I do not know what is the best to add a test about that.
>
> Last, I remember discussions about absolute/relative path and I do not know
> if this 'canonicalize-path' addition is the best fix here.

[...]

> zimoun (1):
>   scripts: build: Fix relative load-path.

I even forgot to send the patch. :-)


Anyway, closing!

All the best,
simon

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.