GNU bug report logs - #46393
[PATCH] gnu: Add ocrfeeder

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 46393 in the body.
You can then email your comments to 46393 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Andy Tai <atai <at> atai.org>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: Add ocrfeeder
Date: Mon, 8 Feb 2021 19:54:43 -0800

[Message part 1 (text/plain, inline)]

[0001-gnu-Add-ocrfeeder.patch (text/x-patch, attachment)]

Message #8 received at 46393 <at> debbugs.gnu.org (full text, mbox):

From: Andy Tai <atai <at> atai.org>
To: 46393 <at> debbugs.gnu.org
Subject: Re: [PATCH] gnu: Add ocrfeeder
Date: Sat, 13 Feb 2021 18:40:57 -0800

* gnu/packages/gnome.scm (ocrfeeder): New variable
* gnu/packages/python-xyz.scm (python-sane): New variable
---
 gnu/packages/gnome.scm      | 67 ++++++++++++++++++++++++++++++++++++-
 gnu/packages/python-xyz.scm | 25 ++++++++++++++
 2 files changed, 91 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index 0f0b7c8157..be6e825ddd 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -56,7 +56,7 @@
 ;;; Copyright © 2020 Arun Isaac <arunisaac <at> systemreboot.net>
 ;;; Copyright © 2020 Michael Rohleder <mike <at> rohleder.de>
 ;;; Copyright © 2020 Tim Gesthuizen <tim.gesthuizen <at> yahoo.de>
-;;; Copyright © 2020 Andy Tai <atai <at> atai.org>
+;;; Copyright © 2020, 2021 Andy Tai <atai <at> atai.org>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -149,6 +149,7 @@
   #:use-module (gnu packages ninja)
   #:use-module (gnu packages node)
   #:use-module (gnu packages nss)
+  #:use-module (gnu packages ocr)
   #:use-module (gnu packages openldap)
   #:use-module (gnu packages package-management)
   #:use-module (gnu packages password-utils)
@@ -12034,3 +12035,67 @@ for the GNOME 3.x platform with many
features.  It aims to be a very complete
 editing environment for translation issues within the GNU gettext/GNOME desktop
 world.")
     (license license:gpl3+)))
+
+
+(define-public ocrfeeder
+  (package
+    (name "ocrfeeder")
+    (version "0.8.3")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append "mirror://gnome/sources/ocrfeeder/"
+                                  (version-major+minor version) "/"
+                                  "ocrfeeder-" version ".tar.xz"))
+              (sha256
+               (base32
+                "12f5gnq92ffnd5zaj04df7jrnsdz1zn4zcgpbf5p9qnd21i2y529"))))
+    (build-system gnu-build-system)
+    (arguments
+     `(#:phases
+       (modify-phases %standard-phases
+         (add-after
+          'install 'wrap-program
+          (lambda* (#:key outputs #:allow-other-keys)
+            (let ((prog (string-append (assoc-ref outputs "out")
+                                       "/bin/" "ocrfeeder"))
+                  (pylib (string-append (assoc-ref outputs "out")
+                                        "/lib/python"
+                                        ,(version-major+minor
+                                          (package-version python))
+                                        "/site-packages")))
+              (wrap-program prog
+                `("PYTHONPATH" = (,(getenv "PYTHONPATH") ,pylib))
+                `("GI_TYPELIB_PATH" = (,(getenv "GI_TYPELIB_PATH"))))
+              #t)))
+         )))
+    (native-inputs
+     `(("glib:bin" ,glib "bin")                   ; for glib-compile-resources
+       ("gobject-introspection" ,gobject-introspection)
+       ("gtk+:bin" ,gtk+ "bin")                   ; for gtk-update-icon-cache
+       ("intltool" ,intltool)
+       ("itstool" ,itstool)
+       ("pkg-config" ,pkg-config)
+       ("xmllint" ,libxml2)))
+    (inputs
+     `(("enchant" ,enchant)
+       ("glib" ,glib)
+       ("goocanvas" ,goocanvas)
+       ("gtk" ,gtk+)
+       ("gtkspell3" ,gtkspell3)
+       ("libjpeg" ,libjpeg-turbo)
+       ("libtiff" ,libtiff)
+       ("libraw" ,libraw)
+       ("ocrad" ,ocrad)
+       ("python" ,python-wrapper)
+       ("python-pygobject" ,python-pygobject)
+       ("python-odfpy" ,python-odfpy)
+       ("python-pillow" ,python-pillow)
+       ("python-pyenchant" ,python-pyenchant)
+       ("python-reportlab" ,python-reportlab)
+       ("python-sane" ,python-sane)
+       ("sane-backends" ,sane-backends)
+       ("tesseract-ocr" ,tesseract-ocr)))
+    (home-page "https://wiki.gnome.org/Apps/OCRFeeder")
+    (synopsis "A Complete OCR Suite")
+    (description "OCRFeeder is a complete Optical Character
Recognition and Document Analysis and Recognition program")
+    (license license:gpl3+)))
diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index e879742e5f..1c9bb2f77d 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -96,6 +96,7 @@
 ;;; Copyright © 2020, 2021 Zheng Junjie <873216071 <at> qq.com>
 ;;; Copyright © 2021 Morgan Smith <Morgan.J.Smith <at> outlook.com>
 ;;; Copyright © 2020 EuAndreh <eu <at> euandre.org>
+;;; Copyright © 2021 Andy Tai <atai <at> atai.org>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -179,6 +180,7 @@
   #:use-module (gnu packages readline)
   #:use-module (gnu packages sdl)
   #:use-module (gnu packages search)
+  #:use-module (gnu packages scanner)
   #:use-module (gnu packages shells)
   #:use-module (gnu packages sphinx)
   #:use-module (gnu packages ssh)
@@ -23735,3 +23737,26 @@ implementations.")
       "Pivy provides python bindings for Coin, a 3D graphics library with an
 Application Programming Interface based on the Open Inventor 2.1 API.")
     (license license:isc)))
+
+
+
+(define-public python-sane
+  (package
+    (name "python-sane")
+    (version "2.9.1")
+    (source
+      (origin
+        (method url-fetch)
+        (uri (pypi-uri name version))
+        (sha256
+          (base32
+            "1pi597z94n2mkd821ln52fq0g727n2jxfskf280ip3kf7jw8w294"))))
+    (build-system python-build-system)
+    (native-inputs
+      `(("python-pytest" ,python-pytest)))
+    (inputs
+      `(("sane-backends" ,sane-backends)))
+    (home-page "https://github.com/python-pillow/Sane")
+    (synopsis "Python interface to the SANE scanner")
+    (description "Python interface to the SANE scanner and frame
grabber interface for Linux")
+    (license license:expat)))
\ No newline at end of file
-- 
2.30.0

Message #11 received at 46393 <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Andy Tai <atai <at> atai.org>
Cc: 46393 <at> debbugs.gnu.org
Subject: Re: [bug#46393] [PATCH] gnu: Add ocrfeeder
Date: Sat, 20 Feb 2021 19:33:56 -0500

On Sat, Feb 13, 2021 at 06:40:57PM -0800, Andy Tai wrote:
> * gnu/packages/gnome.scm (ocrfeeder): New variable
> * gnu/packages/python-xyz.scm (python-sane): New variable

In general, we add packages one commit at a time, so we prefer to
receive this as two patches. First, a patch that adds python-sane, and
then a second patch adding ocrfeeder.

> +(define-public ocrfeeder

Overall LGTM, thanks!

> +    (synopsis "A Complete OCR Suite")

I would write, simply, "Complete OCR Suite". For some reason, the linter
doesn't complain for me, but it should recommend against starting
synopses with an article. That is, with "a", "an", or "the".

https://guix.gnu.org/manual/en/html_node/Synopses-and-Descriptions.html

> +    (description "OCRFeeder is a complete Optical Character
> Recognition and Document Analysis and Recognition program")

And make sure to end the sentence with a period "."

> +(define-public python-sane

Great!

> +    (synopsis "Python interface to the SANE scanner")
> +    (description "Python interface to the SANE scanner and frame
> grabber interface for Linux")

We prefer to use complete sentences in the description. You can always
make it simple:

"This package provides Python interface to the SANE scanner and frame
grabber interface for Linux."

> +    (license license:expat)))

I looked in the repo and it doesn't look like the expat license:

https://directory.fsf.org/wiki/License:Expat

I'm not sure what it is? Can you do a little research? That FSF license
directory might help.

Message #14 received at 46393 <at> debbugs.gnu.org (full text, mbox):

From: Andy Tai <atai <at> atai.org>
To: Leo Famulari <leo <at> famulari.name>
Cc: 46393 <at> debbugs.gnu.org
Subject: Re: [bug#46393] [PATCH] gnu: Add ocrfeeder
Date: Sat, 20 Feb 2021 22:37:27 -0800

On Sat, Feb 20, 2021 at 4:34 PM Leo Famulari <leo <at> famulari.name> wrote:
>
> On Sat, Feb 13, 2021 at 06:40:57PM -0800, Andy Tai wrote:
> > * gnu/packages/gnome.scm (ocrfeeder): New variable
> > * gnu/packages/python-xyz.scm (python-sane): New variable
>
> In general, we add packages one commit at a time, so we prefer to
> receive this as two patches. First, a patch that adds python-sane, and
> then a second patch adding ocrfeeder.
>
I have made python-sane addition a separate patch,
https://debbugs.gnu.org/cgi/bugreport.cgi?bug=46675


>
> > +(define-public python-sane
> > +    (description "Python interface to the SANE scanner and frame
> > grabber interface for Linux")
>
> We prefer to use complete sentences in the description. You can always
> make it simple:
>
> "This package provides Python interface to the SANE scanner and frame
> grabber interface for Linux."
>

changed as suggested

> > +    (license license:expat)))
>
> I looked in the repo and it doesn't look like the expat license:
>
> https://directory.fsf.org/wiki/License:Expat
>
> I'm not sure what it is? Can you do a little research? That FSF license
> directory might help.


I double checked and the FSF uses expat to refer to MIT-style license.
I put a comment in the python-sane patch to that effect.

Thanks

Message #17 received at 46393 <at> debbugs.gnu.org (full text, mbox):

From: Andy Tai <atai <at> atai.org>
To: Leo Famulari <leo <at> famulari.name>
Cc: 46393 <at> debbugs.gnu.org
Subject: Re: [bug#46393] [PATCH] gnu: Add ocrfeeder
Date: Sat, 20 Feb 2021 23:09:19 -0800

[Message part 1 (text/plain, inline)]

On Sat, Feb 20, 2021 at 4:34 PM Leo Famulari <leo <at> famulari.name> wrote:
> > * gnu/packages/gnome.scm (ocrfeeder): New variable
> > * gnu/packages/python-xyz.scm (python-sane): New variable
>
> In general, we add packages one commit at a time, so we prefer to
> receive this as two patches. First, a patch that adds python-sane, and
> then a second patch adding ocrfeeder.
>

Thus this bug now depends on the separate python-sane patch

https://debbugs.gnu.org/cgi/bugreport.cgi?bug=46675

Not sure if GNU Debbugs has a way to show dependency

> > +    (synopsis "A Complete OCR Suite")
>
> I would write, simply, "Complete OCR Suite". For some reason, the linter
> doesn't complain for me, but it should recommend against starting
> synopses with an article. That is, with "a", "an", or "the".
>

changed as suggested

> https://guix.gnu.org/manual/en/html_node/Synopses-and-Descriptions.html
>
> > +    (description "OCRFeeder is a complete Optical Character
> > Recognition and Document Analysis and Recognition program")
>
> And make sure to end the sentence with a period "."
>
>

added

[0001-gnu-Add-ocrfeeder.patch (text/x-patch, attachment)]

Message #20 received at 46393 <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Andy Tai <atai <at> atai.org>
Cc: 46393 <at> debbugs.gnu.org
Subject: Re: [bug#46393] [PATCH] gnu: Add ocrfeeder
Date: Mon, 22 Feb 2021 13:27:11 -0500

On Sat, Feb 20, 2021 at 10:37:27PM -0800, Andy Tai wrote:
> On Sat, Feb 20, 2021 at 4:34 PM Leo Famulari <leo <at> famulari.name> wrote:
> > I looked in the repo and it doesn't look like the expat license:
> >
> > https://directory.fsf.org/wiki/License:Expat
> >
> > I'm not sure what it is? Can you do a little research? That FSF license
> > directory might help.
> 
> 
> I double checked and the FSF uses expat to refer to MIT-style license.
> I put a comment in the python-sane patch to that effect.

Sorry, but this is not the expat license. It's a completely different
text.

In terms of concrete differences, at least, the requirement not to use
the author's name for "advertising" is not part of the expat license.

It's basically a variation on these:

https://www.xfree86.org/4.0.2/LICENSE3.html

I pushed a followup commit, adjusting the package to use the generic
"non-copyleft" license.

Message #23 received at 46393 <at> debbugs.gnu.org (full text, mbox):

From: Andy Tai <atai <at> atai.org>
To: Leo Famulari <leo <at> famulari.name>
Cc: 46393 <at> debbugs.gnu.org
Subject: Re: [bug#46393] [PATCH] gnu: Add ocrfeeder
Date: Mon, 22 Feb 2021 10:29:49 -0800

Thanks for clarifying the license:-)

On Mon, Feb 22, 2021 at 10:27 AM Leo Famulari <leo <at> famulari.name> wrote:
>
> On Sat, Feb 20, 2021 at 10:37:27PM -0800, Andy Tai wrote:
> > On Sat, Feb 20, 2021 at 4:34 PM Leo Famulari <leo <at> famulari.name> wrote:
> > > I looked in the repo and it doesn't look like the expat license:
> > >
> > > https://directory.fsf.org/wiki/License:Expat
> > >
> > > I'm not sure what it is? Can you do a little research? That FSF license
> > > directory might help.
> >
> >
> > I double checked and the FSF uses expat to refer to MIT-style license.
> > I put a comment in the python-sane patch to that effect.
>
> Sorry, but this is not the expat license. It's a completely different
> text.
>
> In terms of concrete differences, at least, the requirement not to use
> the author's name for "advertising" is not part of the expat license.
>
> It's basically a variation on these:
>
> https://www.xfree86.org/4.0.2/LICENSE3.html
>
> I pushed a followup commit, adjusting the package to use the generic
> "non-copyleft" license.



-- 
Andy Tai, atai <at> atai.org, Skype: licheng.tai, Line: andy_tai, WeChat: andytai1010
Year 2021 民國110年
自動的精神力是信仰與覺悟
自動的行為力是勞動與技能

Message #26 received at 46393 <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Andy Tai <atai <at> atai.org>
Cc: 46393 <at> debbugs.gnu.org
Subject: Re: [bug#46393] [PATCH] gnu: Add ocrfeeder
Date: Tue, 23 Feb 2021 15:00:40 -0500

On Sat, Feb 20, 2021 at 11:09:19PM -0800, Andy Tai wrote:
> Not sure if GNU Debbugs has a way to show dependency

Yes. You can mark certain bugs as "blocking" other from being closed.
You do it by sending email to <control <at> debbugs.gnu.org>. The control
mechanisms are described here:

https://debbugs.gnu.org/server-control.html

Message #29 received at 46393 <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Andy Tai <atai <at> atai.org>
Cc: 46393 <at> debbugs.gnu.org
Subject: Re: [bug#46393] [PATCH] gnu: Add ocrfeeder
Date: Tue, 23 Feb 2021 15:05:59 -0500

On Sat, Feb 20, 2021 at 11:09:19PM -0800, Andy Tai wrote:
> From ee945305828750c4bf6e1ee010444d705eb9334b Mon Sep 17 00:00:00 2001
> From: Andy Tai <atai <at> atai.org>
> Date: Sat, 20 Feb 2021 22:58:07 -0800
> Subject: [PATCH] gnu: Add ocrfeeder
> 
> * gnu/packages/gnome.scm (ocrfeeder): New variable
> ---
>  gnu/packages/gnome.scm      | 67 ++++++++++++++++++++++++++++++++++++-
>  gnu/packages/ocr.scm        | 32 +++++++++---------
>  gnu/packages/python-xyz.scm | 24 +++++++++++++
>  3 files changed, 106 insertions(+), 17 deletions(-)

> +(define-public ocrfeeder

Alright, the ocrfeeder package is looking good now.

> diff --git a/gnu/packages/ocr.scm b/gnu/packages/ocr.scm
> index c4e965941a..0b46f979ce 100644
> --- a/gnu/packages/ocr.scm
> +++ b/gnu/packages/ocr.scm

Did you mean to include these changes to tesseract-ocr? I just skimmed,
but they only seem to be cosmetic changes, so probably not.

> diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
> index b26fce72a9..1fb9ff60b4 100644
> --- a/gnu/packages/python-xyz.scm
> +++ b/gnu/packages/python-xyz.scm

> +(define-public python-sane

Python-sane was already added, in commit f500905ce1baf85a2407c5ccde148ee6c2ea2584

Can you send a revised patch?

Message #32 received at 46393 <at> debbugs.gnu.org (full text, mbox):

From: Andy Tai <atai <at> atai.org>
To: Leo Famulari <leo <at> famulari.name>
Cc: 46393 <at> debbugs.gnu.org
Subject: Re: [bug#46393] [PATCH] gnu: Add ocrfeeder
Date: Tue, 23 Feb 2021 12:22:51 -0800

will do

On Tue, Feb 23, 2021 at 12:06 PM Leo Famulari <leo <at> famulari.name> wrote:
> Can you send a revised patch?

Message #35 received at 46393 <at> debbugs.gnu.org (full text, mbox):

From: Andy Tai <atai <at> atai.org>
To: Leo Famulari <leo <at> famulari.name>
Cc: 46393 <at> debbugs.gnu.org
Subject: Re: [bug#46393] [PATCH] gnu: Add ocrfeeder
Date: Tue, 23 Feb 2021 17:59:58 -0800

[Message part 1 (text/plain, inline)]

as attached

> On Tue, Feb 23, 2021 at 12:06 PM Leo Famulari <leo <at> famulari.name> wrote:
> > Can you send a revised patch?

[0001-gnu-Add-ocrfeeder.patch (text/x-patch, attachment)]

Message #38 received at 46393 <at> debbugs.gnu.org (full text, mbox):

From: Andy Tai <atai <at> atai.org>
To: Leo Famulari <leo <at> famulari.name>
Cc: 46393 <at> debbugs.gnu.org
Subject: Re: [bug#46393] [PATCH] gnu: Add ocrfeeder
Date: Tue, 23 Feb 2021 18:09:59 -0800

[Message part 1 (text/plain, inline)]

sent the wrong one; here is the correct one


On Tue, Feb 23, 2021 at 5:59 PM Andy Tai <atai <at> atai.org> wrote:
>
> as attached
>
> > On Tue, Feb 23, 2021 at 12:06 PM Leo Famulari <leo <at> famulari.name> wrote:
> > > Can you send a revised patch?



-- 
Andy Tai, atai <at> atai.org, Skype: licheng.tai, Line: andy_tai, WeChat: andytai1010
Year 2021 民國110年
自動的精神力是信仰與覺悟
自動的行為力是勞動與技能

[0001-gnu-Add-ocrfeeder.patch (text/x-patch, attachment)]

Message #43 received at 46393-done <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Andy Tai <atai <at> atai.org>
Cc: 46393-done <at> debbugs.gnu.org
Subject: Re: [bug#46393] [PATCH] gnu: Add ocrfeeder
Date: Wed, 24 Feb 2021 11:08:52 -0500

On Tue, Feb 23, 2021 at 06:09:59PM -0800, Andy Tai wrote:
> From 2db7eaf5dc51df1f2546357a3a87f73bce089148 Mon Sep 17 00:00:00 2001
> From: Andy Tai <atai <at> atai.org>
> Date: Sat, 20 Feb 2021 22:58:07 -0800
> Subject: [PATCH] gnu: Add ocrfeeder
> 
> * gnu/packages/gnome.scm (ocrfeeder): New variable

Thanks! Pushed as 02e0aa255933197d6c95ab9b66251ef0885b237e

Message #46 received at 46393-done <at> debbugs.gnu.org (full text, mbox):

From: Andy Tai <atai <at> atai.org>
To: Leo Famulari <leo <at> famulari.name>
Cc: 46393-done <at> debbugs.gnu.org
Subject: Re: [bug#46393] [PATCH] gnu: Add ocrfeeder
Date: Wed, 24 Feb 2021 11:04:28 -0800

Thanks!

On Wed, Feb 24, 2021 at 8:08 AM Leo Famulari <leo <at> famulari.name> wrote:
>
> On Tue, Feb 23, 2021 at 06:09:59PM -0800, Andy Tai wrote:
> > From 2db7eaf5dc51df1f2546357a3a87f73bce089148 Mon Sep 17 00:00:00 2001
> > From: Andy Tai <atai <at> atai.org>
> > Date: Sat, 20 Feb 2021 22:58:07 -0800
> > Subject: [PATCH] gnu: Add ocrfeeder
> >
> > * gnu/packages/gnome.scm (ocrfeeder): New variable
>
> Thanks! Pushed as 02e0aa255933197d6c95ab9b66251ef0885b237e



-- 
Andy Tai, atai <at> atai.org, Skype: licheng.tai, Line: andy_tai, WeChat: andytai1010
Year 2021 民國110年
自動的精神力是信仰與覺悟
自動的行為力是勞動與技能

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.