GNU bug report logs - #46401
Typo in commit 0cc35e1431

Previous Next

Package: emacs;

Reported by: Dario Gjorgjevski <dario.gjorgjevski <at> gmail.com>

Date: Tue, 9 Feb 2021 13:00:02 UTC

Severity: normal

Tags: fixed

Fixed in version 28.1

Done: "Basil L. Contovounesios" <contovob <at> tcd.ie>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 46401 in the body.
You can then email your comments to 46401 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#46401; Package emacs. (Tue, 09 Feb 2021 13:00:02 GMT) Full text and rfc822 format available.
Acknowledgement sent to Dario Gjorgjevski <dario.gjorgjevski <at> gmail.com>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Tue, 09 Feb 2021 13:00:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Dario Gjorgjevski <dario.gjorgjevski <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: Typo in commit 0cc35e1431
Date: Tue, 09 Feb 2021 13:59:42 +0100

Hi,

There is a typo in commit 0cc35e1431:

    $ git show --oneline 0cc35e1431 lisp/progmodes/elisp-mode.el
    0cc35e1431 Move all usages of `values' to `values--store-value'
    diff --git a/lisp/progmodes/elisp-mode.el b/lisp/progmodes/elisp-mode.el
    index 9a36206bfd..0325d4ea75 100644
    --- a/lisp/progmodes/elisp-mode.el
    +++ b/lisp/progmodes/elisp-mode.el
    @@ -1268,9 +1268,8 @@ If `eval-expression-debug-on-error' is non-nil, which is the default,
     this command arranges for all errors to enter the debugger."
       (interactive "P")
       (if (null eval-expression-debug-on-error)
    -      (let ((value (elisp--eval-last-sexp eval-last-sexp-arg-internal)))
    -        (push value values)
    -        value)
    +      (values--store-values
    +       (elisp--eval-last-sexp eval-last-sexp-arg-internal))
         (let ((value
               (let ((debug-on-error elisp--eval-last-sexp-fake-value))
                 (cons (elisp--eval-last-sexp eval-last-sexp-arg-internal)

Instead of values--store-values, it should say values--store-value.

Best regards,
Dario

-- 
$ keyserver=hkps://hkps.pool.sks-keyservers.net
$ keyid=744A4F0B4F1C9371
$ gpg --keyserver $keyserver --search-keys $keyid
Added tag(s) fixed. Request was from "Basil L. Contovounesios" <contovob <at> tcd.ie> to control <at> debbugs.gnu.org. (Tue, 09 Feb 2021 13:29:01 GMT) Full text and rfc822 format available.
bug marked as fixed in version 28.1, send any further explanations to 46401 <at> debbugs.gnu.org and Dario Gjorgjevski <dario.gjorgjevski <at> gmail.com> Request was from "Basil L. Contovounesios" <contovob <at> tcd.ie> to control <at> debbugs.gnu.org. (Tue, 09 Feb 2021 13:29:01 GMT) Full text and rfc822 format available.
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#46401; Package emacs. (Tue, 09 Feb 2021 13:29:02 GMT) Full text and rfc822 format available.

Message #12 received at 46401-done <at> debbugs.gnu.org (full text, mbox):

From: "Basil L. Contovounesios" <contovob <at> tcd.ie>
To: Dario Gjorgjevski <dario.gjorgjevski <at> gmail.com>
Cc: 46401-done <at> debbugs.gnu.org
Subject: Re: bug#46401: Typo in commit 0cc35e1431
Date: Tue, 09 Feb 2021 13:28:37 +0000

tags 46401 fixed
close 46401 28.1
quit

Dario Gjorgjevski <dario.gjorgjevski <at> gmail.com> writes:

> There is a typo in commit 0cc35e1431:
[...]
> Instead of values--store-values, it should say values--store-value.

Thanks, this has already been fixed.

; Fix recent change in eval-last-sexp
8e3ace4297 2021-02-09 13:01:18 +0000
https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=8e3ace4297512d9f1a2825d332b7e70c6ae3ea15

-- 
Basil
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Wed, 10 Mar 2021 12:24:04 GMT) Full text and rfc822 format available.
This bug report was last modified 3 years and 44 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.