GNU bug report logs - #46406
28.0.50; [PATCH] Use frame monitor in frame_float

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 46406 in the body.
You can then email your comments to 46406 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Andrii Kolomoiets <andreyk.mad <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 28.0.50; [PATCH] Use frame monitor in frame_float
Date: Tue, 09 Feb 2021 19:46:53 +0200

[Message part 1 (text/plain, inline)]

To reproduce this you need at least one secondary monitor.

1. emacs -Q
2. Move the frame to the secondary monitor
3. M-: (modify-frame-parameters nil '((left . .5) (top . .5)))
   frame is moved to the main monitor
4. Move the frame to secondary monitor again
5. M-: (modify-frame-parameters nil '((width . .5) (height . .5)))
   frame size is half of the main monitor instead of the secondary one

In my case the 'display-monitor-attributes-list' function returns these
attributes:

(((geometry 0 0 1440 900) (workarea 0 25 1440 875) ...)
 ((geometry -254 900 1920 1080) (workarea -254 900 1920 1055) ...))

Attached patch make the frame position and size ratios calculations
related to the monitor on which the frame is.

[0001-Use-frame-monitor-in-frame_float.patch (text/x-patch, attachment)]

Message #8 received at 46406 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Andrii Kolomoiets <andreyk.mad <at> gmail.com>
Cc: 46406 <at> debbugs.gnu.org
Subject: Re: bug#46406: 28.0.50; [PATCH] Use frame monitor in frame_float
Date: Thu, 11 Feb 2021 10:10:01 +0100

Andrii Kolomoiets <andreyk.mad <at> gmail.com> writes:

> Attached patch make the frame position and size ratios calculations
> related to the monitor on which the frame is.

Makes sense to me, I think?  So I've now applied this to Emacs 28.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #15 received at 46406 <at> debbugs.gnu.org (full text, mbox):

From: Andrii Kolomoiets <andreyk.mad <at> gmail.com>
To: Christian Tietze <me <at> christiantietze.de>
Cc: 46406 <at> debbugs.gnu.org
Subject: Re: bug#46406: 28.0.50; [PATCH] Use frame monitor in frame_float
Date: Wed, 17 Feb 2021 12:27:34 +0200

Christian Tietze <me <at> christiantietze.de> writes:

> Hi Andrii,

Hi Christian

> Your Emacs patch for (non)retina screens and frame sizes introduced a
> very weird bug where on the non-retina screen, the contents of the
> frame are drawn in 1/4th the available drawing space. It looks fine on
> the retina screen, though.
>
> See screenshots:
> https://github.com/daviderestivo/homebrew-emacs-head/issues/92
>
> I cannot offer a fix suggestion for this, because I don't know the
> emacs source well. Maybe you know something from the top of your head?

I'll take a look.

P.S. Please keep the bug email in CC on reply.

Message #18 received at 46406 <at> debbugs.gnu.org (full text, mbox):

From: Andrii Kolomoiets <andreyk.mad <at> gmail.com>
To: Christian Tietze <me <at> christiantietze.de>
Cc: 46406 <at> debbugs.gnu.org
Subject: Re: bug#46406: 28.0.50; [PATCH] Use frame monitor in frame_float
Date: Fri, 19 Feb 2021 12:07:32 +0200

Andrii Kolomoiets <andreyk.mad <at> gmail.com> writes:

> Christian Tietze <me <at> christiantietze.de> writes:
>
>> Hi Andrii,
>
> Hi Christian
>
>> Your Emacs patch for (non)retina screens and frame sizes introduced a
>> very weird bug where on the non-retina screen, the contents of the
>> frame are drawn in 1/4th the available drawing space. It looks fine on
>> the retina screen, though.
>>
>> See screenshots:
>> https://github.com/daviderestivo/homebrew-emacs-head/issues/92
>>
>> I cannot offer a fix suggestion for this, because I don't know the
>> emacs source well. Maybe you know something from the top of your head?
>
> I'll take a look.

With the commit 0e2b123a4ef600f5b337972a7bb61c1fc4b7d0cd I have no
issue moving frame to the non-retina screen.  The issue appears for me
with the commit 68bd6f3ea9c05637501139c46f1f4304482db95f.

I suspect your issue were introduced in Bug#46155

Message #21 received at 46406 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Andrii Kolomoiets <andreyk.mad <at> gmail.com>
Cc: Alan Third <alan <at> idiocy.org>, 46406 <at> debbugs.gnu.org,
 Christian Tietze <me <at> christiantietze.de>
Subject: Re: bug#46406: 28.0.50; [PATCH] Use frame monitor in frame_float
Date: Fri, 19 Feb 2021 14:04:24 +0100

Andrii Kolomoiets <andreyk.mad <at> gmail.com> writes:

> With the commit 0e2b123a4ef600f5b337972a7bb61c1fc4b7d0cd I have no
> issue moving frame to the non-retina screen.  The issue appears for me
> with the commit 68bd6f3ea9c05637501139c46f1f4304482db95f.
>
> I suspect your issue were introduced in Bug#46155

OK; adding Alan to the CCs.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #24 received at 46406 <at> debbugs.gnu.org (full text, mbox):

From: Alan Third <alan <at> idiocy.org>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 46406 <at> debbugs.gnu.org, Christian Tietze <me <at> christiantietze.de>,
 Andrii Kolomoiets <andreyk.mad <at> gmail.com>
Subject: Re: bug#46406: 28.0.50; [PATCH] Use frame monitor in frame_float
Date: Fri, 19 Feb 2021 19:38:16 +0000

On Fri, Feb 19, 2021 at 02:04:24PM +0100, Lars Ingebrigtsen wrote:
> Andrii Kolomoiets <andreyk.mad <at> gmail.com> writes:
> 
> > With the commit 0e2b123a4ef600f5b337972a7bb61c1fc4b7d0cd I have no
> > issue moving frame to the non-retina screen.  The issue appears for me
> > with the commit 68bd6f3ea9c05637501139c46f1f4304482db95f.
> >
> > I suspect your issue were introduced in Bug#46155
> 
> OK; adding Alan to the CCs.

Fix pushed as 283f98353fe3549ac8f66a3ab8fba85d93c81a88.

-- 
Alan Third

Message #27 received at 46406 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Alan Third <alan <at> idiocy.org>
Cc: 46406 <at> debbugs.gnu.org, Christian Tietze <me <at> christiantietze.de>,
 Andrii Kolomoiets <andreyk.mad <at> gmail.com>
Subject: Re: bug#46406: 28.0.50; [PATCH] Use frame monitor in frame_float
Date: Sat, 20 Feb 2021 14:00:33 +0100

Alan Third <alan <at> idiocy.org> writes:

>> OK; adding Alan to the CCs.
>
> Fix pushed as 283f98353fe3549ac8f66a3ab8fba85d93c81a88.

Thanks.  Christian, would it be possible for you to update Emacs 28 and
confirm that this fixes the problem you were seeing?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #30 received at 46406 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Christian Tietze <me <at> christiantietze.de>
Cc: Alan Third <alan <at> idiocy.org>, 46406 <at> debbugs.gnu.org,
 Andrii Kolomoiets <andreyk.mad <at> gmail.com>
Subject: Re: bug#46406: 28.0.50; [PATCH] Use frame monitor in frame_float
Date: Mon, 22 Feb 2021 23:11:02 +0100

Christian Tietze <me <at> christiantietze.de> writes:

>> On 20. Feb 2021, at 14:00, Lars Ingebrigtsen <larsi <at> gnus.org> wrote:
>> 
>> Thanks.  Christian, would it be possible for you to update Emacs 28 and
>> confirm that this fixes the problem you were seeing?
>
> Compiled from source and it looks good on both displays! 

Thanks for checking; closing this bug report, then.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #33 received at 46406 <at> debbugs.gnu.org (full text, mbox):

From: Christian Tietze <me <at> christiantietze.de>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: Alan Third <alan <at> idiocy.org>, 46406 <at> debbugs.gnu.org,
 Andrii Kolomoiets <andreyk.mad <at> gmail.com>
Subject: Re: bug#46406: 28.0.50; [PATCH] Use frame monitor in frame_float
Date: Mon, 22 Feb 2021 23:08:28 +0100

> On 20. Feb 2021, at 14:00, Lars Ingebrigtsen <larsi <at> gnus.org> wrote:
> 
> Thanks.  Christian, would it be possible for you to update Emacs 28 and
> confirm that this fixes the problem you were seeing?

Compiled from source and it looks good on both displays! 

Thanks for the quick responses, folks.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.