GNU bug report logs - #46429
[PATCH 0/1] guix time-machine: fail when unrecognized option

Previous Next

Package: guix-patches;

Reported by: zimoun <zimon.toutoune <at> gmail.com>

Date: Wed, 10 Feb 2021 21:40:01 UTC

Severity: normal

Tags: patch

Done: Ludovic Courtès <ludo <at> gnu.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 46429 in the body.
You can then email your comments to 46429 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#46429; Package guix-patches. (Wed, 10 Feb 2021 21:40:01 GMT) Full text and rfc822 format available.

Acknowledgement sent to zimoun <zimon.toutoune <at> gmail.com>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Wed, 10 Feb 2021 21:40:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: zimoun <zimon.toutoune <at> gmail.com>
To: guix-patches <at> gnu.org
Cc: zimoun <zimon.toutoune <at> gmail.com>
Subject: [PATCH 0/1] guix time-machine: fail when unrecognized option
Date: Wed, 10 Feb 2021 22:38:50 +0100
Hi,

Currently, the command line:

--8<---------------cut here---------------start------------->8---
$ guix time-machine kikoo -- --version
guix (GNU Guix) 8f8a1485b80de707caecf6e7e29b520cd8cf611e
Copyright © 2021 les auteurs de Guix
Licence GPLv3+ : GNU GPL version 3 ou ultérieure <http://www.gnu.org/licenses/gpl.fr.html>
Ceci est un logiciel libre : vous êtes libre de le modifier et de le redistribuer.
Il n'y a AUCUNE GARANTIE, dans les limites permises par la loi.
--8<---------------cut here---------------end--------------->8---

does not fail but uses the current commit.  This leads to confusing behaviour
as described in <http://issues.guix.gnu.org/46336>, for instance:

$ guix time-machine 8e7e414aa998fe8c0de8a491c91aab8b8d9c58f4 -- graph maven

which had failed with:

--8<---------------cut here---------------start------------->8---
"453f18db343cbad1892186b85c7eb07f364b399e"; system: "x86_64-linux";
host version: "838347207cdd96de1ad0127aaf4b2c378c7c2148"; pull-version: 1).
--8<---------------cut here---------------end--------------->8---

The failure is another reason.  However the backtrace is not informative about
the real issue which is a misuse of the command line.


This trivial patch fixes it by gracefully failing.


All the best,
simon



zimoun (1):
  scripts: time-machine: Fail when unrecognized option.

 guix/scripts/time-machine.scm | 3 +++
 1 file changed, 3 insertions(+)


base-commit: 8f8a1485b80de707caecf6e7e29b520cd8cf611e
-- 
2.29.2





Information forwarded to guix-patches <at> gnu.org:
bug#46429; Package guix-patches. (Wed, 10 Feb 2021 21:49:02 GMT) Full text and rfc822 format available.

Message #8 received at 46429 <at> debbugs.gnu.org (full text, mbox):

From: zimoun <zimon.toutoune <at> gmail.com>
To: 46429 <at> debbugs.gnu.org
Cc: zimoun <zimon.toutoune <at> gmail.com>
Subject: [PATCH 1/1] scripts: time-machine: Fail when unrecognized option.
Date: Wed, 10 Feb 2021 22:48:04 +0100
* guix/scripts/time-machine (parse-args): Fail when unrecognized option.
---
 guix/scripts/time-machine.scm | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/guix/scripts/time-machine.scm b/guix/scripts/time-machine.scm
index 0d27414702..c6ab30e132 100644
--- a/guix/scripts/time-machine.scm
+++ b/guix/scripts/time-machine.scm
@@ -1,6 +1,7 @@
 ;;; GNU Guix --- Functional package management for GNU
 ;;; Copyright © 2019 Konrad Hinsen <konrad.hinsen <at> fastmail.net>
 ;;; Copyright © 2019, 2020 Ludovic Courtès <ludo <at> gnu.org>
+;;; Copyright © 2021 Simon Tournier <zimon.toutoune <at> gmail.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -118,6 +119,8 @@ Execute COMMAND ARGS... in an older version of Guix.\n"))
   (let-values (((args command) (break (cut string=? "--" <>) args)))
     (let ((opts (parse-command-line args %options
                                     (list %default-options))))
+      (when (assoc-ref opts 'argument)
+         (leave (G_ "unrecognized option~%")))
       (match command
         (() opts)
         (("--") opts)
-- 
2.29.2





Reply sent to Ludovic Courtès <ludo <at> gnu.org>:
You have taken responsibility. (Thu, 11 Mar 2021 22:26:02 GMT) Full text and rfc822 format available.

Notification sent to zimoun <zimon.toutoune <at> gmail.com>:
bug acknowledged by developer. (Thu, 11 Mar 2021 22:26:02 GMT) Full text and rfc822 format available.

Message #13 received at 46429-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: zimoun <zimon.toutoune <at> gmail.com>
Cc: 46429-done <at> debbugs.gnu.org
Subject: Re: bug#46429: [PATCH 0/1] guix time-machine: fail when
 unrecognized option
Date: Thu, 11 Mar 2021 23:25:41 +0100
Hi!

zimoun <zimon.toutoune <at> gmail.com> skribis:

> * guix/scripts/time-machine (parse-args): Fail when unrecognized option.

I tweaked the error message to be consistent with the other commands and
pushed as f1c4df15c31a81cca03a748a21ec38774e8114c0.

Thanks,
Ludo’.




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Fri, 09 Apr 2021 11:24:06 GMT) Full text and rfc822 format available.

This bug report was last modified 2 years and 354 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.