GNU bug report logs - #46433
[PATCH] gnu: gst-plugins-base: Depend on Opus for all systems.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 46433 in the body.
You can then email your comments to 46433 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: gst-plugins-base: Depend on Opus for all systems.
Date: Wed, 10 Feb 2021 19:02:18 -0500

I tested this by building gst-plugins-base for --system=i686-linux and
also building wine.

* gnu/packages/gstreamer.scm (gst-plugins-base)[inputs]: Include opus
unconditionally.
---
 gnu/packages/gstreamer.scm | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/gnu/packages/gstreamer.scm b/gnu/packages/gstreamer.scm
index b582585d75..0921e9ac9f 100644
--- a/gnu/packages/gstreamer.scm
+++ b/gnu/packages/gstreamer.scm
@@ -553,11 +553,7 @@ This package provides the core library and elements.")
        ("libXext" ,libxext)
        ("libxv" ,libxv)
        ("alsa-lib" ,alsa-lib)
-       ;; XXX Don't build with opus on 32-bit systems:
-       ;; <https://bugs.gnu.org/32360>
-       ,@(if (target-64bit?)
-             `(("opus" ,opus))
-             '())))
+       ("opus" ,opus)))
     (native-inputs
       `(("pkg-config" ,pkg-config)
         ("glib:bin" ,glib "bin")
-- 
2.30.0

Message #8 received at 46433 <at> debbugs.gnu.org (full text, mbox):

From: Leo Prikler <leo.prikler <at> student.tugraz.at>
To: Leo Famulari <leo <at> famulari.name>, 46433 <at> debbugs.gnu.org
Subject: Re: [PATCH] gnu: gst-plugins-base: Depend on Opus for all systems.
Date: Thu, 11 Feb 2021 10:43:45 +0100

Am Mittwoch, den 10.02.2021, 19:02 -0500 schrieb Leo Famulari:
> I tested this by building gst-plugins-base for --system=i686-linux
> and
> also building wine.
I tried applying this to staging and running `./pre-inst-env guix build
--system=i686-linux gst-plugins-base`, but interestingly it just
substituted from ci.guix.gnu.org.  I suppose it's probably fine to push
this to staging, but it's still an interesting result.

Regards,
Leo

Message #11 received at 46433 <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Leo Prikler <leo.prikler <at> student.tugraz.at>
Cc: 46433 <at> debbugs.gnu.org
Subject: Re: [PATCH] gnu: gst-plugins-base: Depend on Opus for all systems.
Date: Thu, 11 Feb 2021 14:13:29 -0500

On Thu, Feb 11, 2021 at 10:43:45AM +0100, Leo Prikler wrote:
> I tried applying this to staging and running `./pre-inst-env guix build
> --system=i686-linux gst-plugins-base`, but interestingly it just
> substituted from ci.guix.gnu.org.  I suppose it's probably fine to push
> this to staging, but it's still an interesting result.

You got a substitute because I built the package "by hand" on
ci.guix.gnu.org.

Thanks for your review! Pushed to staging as
ea73e829d7d061d9fd8e1f672926363fe8db2a1b

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.