GNU bug report logs - #46445
[PATCH] tests: Make the STORE test more robust in a "pure" environment.

Previous Next

Package: guix-patches;

Reported by: Leo Famulari <leo <at> famulari.name>

Date: Thu, 11 Feb 2021 20:26:01 UTC

Severity: normal

Tags: patch

Done: Leo Famulari <leo <at> famulari.name>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 46445 in the body.
You can then email your comments to 46445 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#46445; Package guix-patches. (Thu, 11 Feb 2021 20:26:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Leo Famulari <leo <at> famulari.name>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Thu, 11 Feb 2021 20:26:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: guix-patches <at> gnu.org
Subject: [PATCH] tests: Make the STORE test more robust in a "pure"
 environment.
Date: Thu, 11 Feb 2021 15:25:42 -0500
Otherwise, the test crashes (not fails) when run in `guix environment --pure guix`.

I'm not sure this is the right approach, when I look at commit
3d43017026f9995ad128915db8ca5eafe061bf75, which added this variable.

* tests/store.scm (%shell): Fallback to "/bin/sh".
---
 tests/store.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/store.scm b/tests/store.scm
index cda0e0302f..9c25adf5e9 100644
--- a/tests/store.scm
+++ b/tests/store.scm
@@ -50,7 +50,7 @@
   (open-connection-for-tests))
 
 (define %shell
-  (or (getenv "SHELL") (getenv "CONFIG_SHELL")))
+  (or (getenv "SHELL") (getenv "CONFIG_SHELL") "/bin/sh"))
 
 
 (test-begin "store")
-- 
2.30.0





Information forwarded to guix-patches <at> gnu.org:
bug#46445; Package guix-patches. (Thu, 25 Feb 2021 20:14:01 GMT) Full text and rfc822 format available.

Message #8 received at 46445 <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: 46445 <at> debbugs.gnu.org
Subject: Re: [PATCH] tests: Make the STORE test more robust in a "pure"
 environment.
Date: Thu, 25 Feb 2021 15:13:37 -0500
Ping!

Is this change correct?




Information forwarded to guix-patches <at> gnu.org:
bug#46445; Package guix-patches. (Wed, 17 Mar 2021 21:37:02 GMT) Full text and rfc822 format available.

Message #11 received at 46445 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Leo Famulari <leo <at> famulari.name>
Cc: 46445 <at> debbugs.gnu.org
Subject: Re: bug#46445: [PATCH] tests: Make the STORE test more robust in a
 "pure" environment.
Date: Wed, 17 Mar 2021 22:36:16 +0100
Leo Famulari <leo <at> famulari.name> skribis:

> Otherwise, the test crashes (not fails) when run in `guix environment --pure guix`.
>
> I'm not sure this is the right approach, when I look at commit
> 3d43017026f9995ad128915db8ca5eafe061bf75, which added this variable.
>
> * tests/store.scm (%shell): Fallback to "/bin/sh".

LGTM, thanks!

Ludo'.




Reply sent to Leo Famulari <leo <at> famulari.name>:
You have taken responsibility. (Thu, 18 Mar 2021 19:17:02 GMT) Full text and rfc822 format available.

Notification sent to Leo Famulari <leo <at> famulari.name>:
bug acknowledged by developer. (Thu, 18 Mar 2021 19:17:02 GMT) Full text and rfc822 format available.

Message #16 received at 46445-done <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 46445-done <at> debbugs.gnu.org
Subject: Re: bug#46445: [PATCH] tests: Make the STORE test more robust in a
 "pure" environment.
Date: Thu, 18 Mar 2021 15:16:43 -0400
On Wed, Mar 17, 2021 at 10:36:16PM +0100, Ludovic Courtès wrote:
> LGTM, thanks!

Thanks for your review! Pushed as
0d8d499036f632e03f63bdaf36b02861ea52b3e6




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Fri, 16 Apr 2021 11:24:06 GMT) Full text and rfc822 format available.

This bug report was last modified 2 years and 348 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.