GNU bug report logs - #46459
28.0.50; Shared keymap for Git VC dir "Branch" header?

Previous Next

Package: emacs;

Reported by: Protesilaos Stavrou <info <at> protesilaos.com>

Date: Fri, 12 Feb 2021 06:55:01 UTC

Severity: normal

Tags: wontfix

Found in version 28.0.50

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 46459 in the body.
You can then email your comments to 46459 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#46459; Package emacs. (Fri, 12 Feb 2021 06:55:01 GMT) Full text and rfc822 format available.

Acknowledgement sent to Protesilaos Stavrou <info <at> protesilaos.com>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Fri, 12 Feb 2021 06:55:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Protesilaos Stavrou <info <at> protesilaos.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 28.0.50; Shared keymap for Git VC dir "Branch" header?
Date: Fri, 12 Feb 2021 08:54:13 +0200
[Message part 1 (text/plain, inline)]
Dear maintainers,

In vc-git.el the header for vc-dir stashes is propertized with its own
keymap.  This means that while point is over the value of the "Stash:"
header, the specified keymap comes into effect, instead of the main one
for vc-dir.  The latter takes effect when point is anywhere but that
header's value.

Should this principle be applied to the value of the "Branch" header as
well?  The attached patch is a proof-of-concept to that end.

If you believe this is worth doing, what else do you think should go
into such a patch from a usability standpoint?

All the best,
Protesilaos

-- 
Protesilaos Stavrou
protesilaos.com
[0001-Add-shared-keymap-to-Git-VC-dir-Branch-header.patch (text/x-patch, attachment)]

Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#46459; Package emacs. (Fri, 12 Feb 2021 09:56:02 GMT) Full text and rfc822 format available.

Message #8 received at 46459 <at> debbugs.gnu.org (full text, mbox):

From: Robert Pluim <rpluim <at> gmail.com>
To: Protesilaos Stavrou <info <at> protesilaos.com>
Cc: 46459 <at> debbugs.gnu.org
Subject: Re: bug#46459: 28.0.50; Shared keymap for Git VC dir "Branch" header?
Date: Fri, 12 Feb 2021 10:55:05 +0100
>>>>> On Fri, 12 Feb 2021 08:54:13 +0200, Protesilaos Stavrou <info <at> protesilaos.com> said:

    Protesilaos> Dear maintainers,
    Protesilaos> In vc-git.el the header for vc-dir stashes is propertized with its own
    Protesilaos> keymap.  This means that while point is over the value of the "Stash:"
    Protesilaos> header, the specified keymap comes into effect, instead of the main one
    Protesilaos> for vc-dir.  The latter takes effect when point is anywhere but that
    Protesilaos> header's value.

    Protesilaos> Should this principle be applied to the value of the "Branch" header as
    Protesilaos> well?  The attached patch is a proof-of-concept to that end.

    Protesilaos> If you believe this is worth doing, what else do you think should go
    Protesilaos> into such a patch from a usability standpoint?

Looks good to me, although Iʼve just noticed the vc and vc-dir have
confusingly different bindings for vc-retrieve-tag and vc-create-tag
Maybe put vc-create-tag on C-x v c as well?

Robert




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#46459; Package emacs. (Sat, 13 Feb 2021 00:51:02 GMT) Full text and rfc822 format available.

Message #11 received at 46459 <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Gutov <dgutov <at> yandex.ru>
To: Protesilaos Stavrou <info <at> protesilaos.com>, 46459 <at> debbugs.gnu.org
Subject: Re: bug#46459: 28.0.50; Shared keymap for Git VC dir "Branch" header?
Date: Sat, 13 Feb 2021 02:50:41 +0200
Hi!

On 12.02.2021 08:54, Protesilaos Stavrou wrote:
> In vc-git.el the header for vc-dir stashes is propertized with its own
> keymap.  This means that while point is over the value of the "Stash:"
> header, the specified keymap comes into effect, instead of the main one
> for vc-dir.  The latter takes effect when point is anywhere but that
> header's value.
> 
> Should this principle be applied to the value of the "Branch" header as
> well?  The attached patch is a proof-of-concept to that end.
> 
> If you believe this is worth doing, what else do you think should go
> into such a patch from a usability standpoint?

It seems less obviously useful, given that the stashes list allows one 
to interact with a particular stash (whether it is to view it or delete 
it), whereas this keymap should only save the user one S-b key sequence, 
and only if they figure out to move point to the branch name. I don't 
really object, though, if people like it.

Speaking of usability, I guess something that would make this feature 
more discoverable could help, like a button on top of the branch name, 
and a menu similar to the stashes' one.




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#46459; Package emacs. (Sat, 13 Feb 2021 00:52:02 GMT) Full text and rfc822 format available.

Message #14 received at 46459 <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Gutov <dgutov <at> yandex.ru>
To: Robert Pluim <rpluim <at> gmail.com>, Protesilaos Stavrou <info <at> protesilaos.com>
Cc: 46459 <at> debbugs.gnu.org
Subject: Re: bug#46459: 28.0.50; Shared keymap for Git VC dir "Branch" header?
Date: Sat, 13 Feb 2021 02:51:16 +0200
On 12.02.2021 11:55, Robert Pluim wrote:
> Looks good to me, although Iʼve just noticed the vc and vc-dir have
> confusingly different bindings for vc-retrieve-tag and vc-create-tag
> Maybe put vc-create-tag on C-x v c as well?

The key binding space is limited, though. Perhaps we should decide on a 
key and use it in both cases.




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#46459; Package emacs. (Sat, 13 Feb 2021 18:34:02 GMT) Full text and rfc822 format available.

Message #17 received at 46459 <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> linkov.net>
To: Robert Pluim <rpluim <at> gmail.com>
Cc: Protesilaos Stavrou <info <at> protesilaos.com>, 46459 <at> debbugs.gnu.org
Subject: Re: bug#46459: 28.0.50; Shared keymap for Git VC dir "Branch" header?
Date: Sat, 13 Feb 2021 20:20:13 +0200
> Looks good to me, although Iʼve just noticed the vc and vc-dir have
> confusingly different bindings for vc-retrieve-tag and vc-create-tag
> Maybe put vc-create-tag on C-x v c as well?

Then the freed key C-x v s could be bound to vc-log-search
(mnemonically more suitable for s = search):

  C-x v c - vc-create-tag
  C-x v s - vc-log-search




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#46459; Package emacs. (Sat, 13 Feb 2021 20:07:01 GMT) Full text and rfc822 format available.

Message #20 received at 46459 <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Gutov <dgutov <at> yandex.ru>
To: Juri Linkov <juri <at> linkov.net>, Robert Pluim <rpluim <at> gmail.com>
Cc: Protesilaos Stavrou <info <at> protesilaos.com>, 46459 <at> debbugs.gnu.org
Subject: Re: bug#46459: 28.0.50; Shared keymap for Git VC dir "Branch" header?
Date: Sat, 13 Feb 2021 22:05:52 +0200
On 13.02.2021 20:20, Juri Linkov wrote:
> Then the freed key C-x v s could be bound to vc-log-search
> (mnemonically more suitable for s = search):
> 
>    C-x v c - vc-create-tag
>    C-x v s - vc-log-search

Good idea, I like that.




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#46459; Package emacs. (Sun, 14 Feb 2021 03:55:02 GMT) Full text and rfc822 format available.

Message #23 received at 46459 <at> debbugs.gnu.org (full text, mbox):

From: Protesilaos Stavrou <info <at> protesilaos.com>
To: Dmitry Gutov <dgutov <at> yandex.ru>
Cc: 46459 <at> debbugs.gnu.org
Subject: Re: bug#46459: 28.0.50; Shared keymap for Git VC dir "Branch" header?
Date: Sun, 14 Feb 2021 05:54:25 +0200
On 2021-02-13, 02:50 +0200, Dmitry Gutov <dgutov <at> yandex.ru> wrote:

> Hi!
>
> On 12.02.2021 08:54, Protesilaos Stavrou wrote:
>> In vc-git.el the header for vc-dir stashes is propertized with its own
>> keymap.  This means that while point is over the value of the "Stash:"
>> header, the specified keymap comes into effect, instead of the main one
>> for vc-dir.  The latter takes effect when point is anywhere but that
>> header's value.
>> Should this principle be applied to the value of the "Branch" header
>> as
>> well?  The attached patch is a proof-of-concept to that end.
>> If you believe this is worth doing, what else do you think should go
>> into such a patch from a usability standpoint?
>
> It seems less obviously useful, given that the stashes list allows one
> to interact with a particular stash (whether it is to view it or delete
> it), whereas this keymap should only save the user one S-b key sequence,
> and only if they figure out to move point to the branch name. I don't
> really object, though, if people like it.
>
> Speaking of usability, I guess something that would make this feature
> more discoverable could help, like a button on top of the branch name,
> and a menu similar to the stashes' one.

You are right: it does not add much value on its own.  A button is the
way to go, perhaps with its list of branches in a contracted state by
default.  That could also be accompanied by some extra branch-related
commands to make the button's list more useful.

At any rate, that is outside the scope of this bug report.  Please feel
free to close it---sorry for the noise.

-- 
Protesilaos Stavrou
protesilaos.com




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#46459; Package emacs. (Sun, 14 Feb 2021 13:57:01 GMT) Full text and rfc822 format available.

Message #26 received at 46459 <at> debbugs.gnu.org (full text, mbox):

From: Robert Pluim <rpluim <at> gmail.com>
To: Dmitry Gutov <dgutov <at> yandex.ru>
Cc: Protesilaos Stavrou <info <at> protesilaos.com>, 46459 <at> debbugs.gnu.org,
 Juri Linkov <juri <at> linkov.net>
Subject: Re: bug#46459: 28.0.50; Shared keymap for Git VC dir "Branch" header?
Date: Sun, 14 Feb 2021 14:56:20 +0100
>>>>> On Sat, 13 Feb 2021 22:05:52 +0200, Dmitry Gutov <dgutov <at> yandex.ru> said:

    Dmitry> On 13.02.2021 20:20, Juri Linkov wrote:
    >> Then the freed key C-x v s could be bound to vc-log-search
    >> (mnemonically more suitable for s = search):
    >> C-x v c - vc-create-tag
    >> C-x v s - vc-log-search

    Dmitry> Good idea, I like that.

Works for me, but Iʼve used up my "change default behaviour" commit
bit for the week :-)

Although what do we do with vc-retrieve-tag in vc-dir (itʼs on B s)?
Move it to B r to mirror C-x v r?

Robert




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#46459; Package emacs. (Fri, 17 Jun 2022 12:55:02 GMT) Full text and rfc822 format available.

Message #29 received at 46459 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Protesilaos Stavrou <info <at> protesilaos.com>
Cc: 46459 <at> debbugs.gnu.org, Dmitry Gutov <dgutov <at> yandex.ru>
Subject: Re: bug#46459: 28.0.50; Shared keymap for Git VC dir "Branch" header?
Date: Fri, 17 Jun 2022 14:53:53 +0200
Protesilaos Stavrou <info <at> protesilaos.com> writes:

> At any rate, that is outside the scope of this bug report.  Please feel
> free to close it---sorry for the noise.

I think the conclusion here was that we don't want to add a keymap on
the Branch header, so I'm closing this bug report.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no




Added tag(s) wontfix. Request was from Lars Ingebrigtsen <larsi <at> gnus.org> to control <at> debbugs.gnu.org. (Fri, 17 Jun 2022 12:55:02 GMT) Full text and rfc822 format available.

bug closed, send any further explanations to 46459 <at> debbugs.gnu.org and Protesilaos Stavrou <info <at> protesilaos.com> Request was from Lars Ingebrigtsen <larsi <at> gnus.org> to control <at> debbugs.gnu.org. (Fri, 17 Jun 2022 12:55:03 GMT) Full text and rfc822 format available.

bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Sat, 16 Jul 2022 11:24:10 GMT) Full text and rfc822 format available.

This bug report was last modified 1 year and 256 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.