GNU bug report logs - #46506
[PATCH] system: hurd: Have the static networking provision 'networking.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 46506 in the body.
You can then email your comments to 46506 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: guix-patches <at> gnu.org
Subject: [PATCH] system: hurd: Have the static networking provision
 'networking.
Date: Sun, 14 Feb 2021 10:58:27 +0000

Some services require networking, I'm looking at the Guix Build Coordinator
agent.  Networking seems to work in the childhurd VM, so I think this change
makes sense.

* gnu/system/hurd.scm (%base-services/hurd): Add 'networking to the provision
parameter for the static-networking service.
---
 gnu/system/hurd.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/system/hurd.scm b/gnu/system/hurd.scm
index 8b46e65e31..8f3a27834b 100644
--- a/gnu/system/hurd.scm
+++ b/gnu/system/hurd.scm
@@ -79,7 +79,7 @@
                  (list (static-networking (interface "lo")
                                           (ip "127.0.0.1")
                                           (requirement '())
-                                          (provision '(loopback))
+                                          (provision '(loopback networking))
                                           (name-servers '("10.0.2.3")))))
         (syslog-service)
         (service guix-service-type
-- 
2.30.0

Message #8 received at 46506 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Christopher Baines <mail <at> cbaines.net>
Cc: 46506 <at> debbugs.gnu.org
Subject: Re: bug#46506: [PATCH] system: hurd: Have the static networking
 provision 'networking.
Date: Mon, 22 Feb 2021 11:06:35 +0100

Hi Chris,

Christopher Baines <mail <at> cbaines.net> skribis:

> Some services require networking, I'm looking at the Guix Build Coordinator
> agent.  Networking seems to work in the childhurd VM, so I think this change
> makes sense.
>
> * gnu/system/hurd.scm (%base-services/hurd): Add 'networking to the provision
> parameter for the static-networking service.

LGTM, thanks!

Ludo’.

Message #13 received at 46506-done <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 46506-done <at> debbugs.gnu.org
Subject: Re: bug#46506: [PATCH] system: hurd: Have the static networking
 provision 'networking.
Date: Mon, 22 Feb 2021 22:22:03 +0000

[Message part 1 (text/plain, inline)]

Ludovic Courtès <ludo <at> gnu.org> writes:

> Hi Chris,
>
> Christopher Baines <mail <at> cbaines.net> skribis:
>
>> Some services require networking, I'm looking at the Guix Build Coordinator
>> agent.  Networking seems to work in the childhurd VM, so I think this change
>> makes sense.
>>
>> * gnu/system/hurd.scm (%base-services/hurd): Add 'networking to the provision
>> parameter for the static-networking service.
>
> LGTM, thanks!

Thanks for taking a look, pushed as
5c7874adb00c834e55e58a9b964ebc5fd1bb872c.

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.