GNU bug report logs - #46536
Fix build of materialdecoration.

Previous Next

Package: guix-patches;

Reported by: Raghav Gururajan <rg <at> raghavgururajan.name>

Date: Mon, 15 Feb 2021 16:36:02 UTC

Severity: normal

Done: Leo Prikler <leo.prikler <at> student.tugraz.at>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 46536 in the body.
You can then email your comments to 46536 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#46536; Package guix-patches. (Mon, 15 Feb 2021 16:36:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Raghav Gururajan <rg <at> raghavgururajan.name>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Mon, 15 Feb 2021 16:36:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Raghav Gururajan <rg <at> raghavgururajan.name>
To: guix-patches <at> gnu.org
Cc: Leo Prikler <leo.prikler <at> student.tugraz.at>
Subject: Fix build of materialdecoration.
Date: Mon, 15 Feb 2021 11:35:09 -0500
[Message part 1 (text/plain, inline)]

[0001-gnu-cmake-shared-Update-to-1.1.0-32.patch (text/x-patch, attachment)]
[0002-gnu-materialdecoration-Update-to-1.1.0-9.patch (text/x-patch, attachment)]
[OpenPGP_signature (application/pgp-signature, attachment)]

Information forwarded to guix-patches <at> gnu.org:
bug#46536; Package guix-patches. (Mon, 15 Feb 2021 17:08:02 GMT) Full text and rfc822 format available.

Message #8 received at 46536 <at> debbugs.gnu.org (full text, mbox):

From: Leo Prikler <leo.prikler <at> student.tugraz.at>
To: Raghav Gururajan <rg <at> raghavgururajan.name>, 46536 <at> debbugs.gnu.org
Subject: Re: Fix build of materialdecoration.
Date: Mon, 15 Feb 2021 18:07:47 +0100
Hi Raghav,

> * gnu/packages/cmake.scm (cmake-shared) [git-version]: Update to
> 1.1.0-32.
The git-version field doesn't actually change.  You could annotate
[commit] and [revision] separately, but it usually makes sense to just
say "update to <commit hash>".

* gnu/packages/qt.scm (materialdecoration) [git-version]: Update to
> 1.1.0-9.
Same here.

> [arguments]<#:phases>['remove-3rdparty]: New phase.
Should that be a snippet instead?

> <#:phases>['remove-3rdparty]: New phase.
As above.

> [arguments]<#:configure-flags>[-DCMAKE_CXX_FLAGS]: New flag.
That's a bit too much nesting.
"[arguments]<#:configure-flags: Add -DCMAKE_CXX_FLAGS"
is probably a better choice.

Otherwise LGTM.

Regards,
Leo





Information forwarded to guix-patches <at> gnu.org:
bug#46536; Package guix-patches. (Mon, 15 Feb 2021 17:42:01 GMT) Full text and rfc822 format available.

Message #11 received at 46536 <at> debbugs.gnu.org (full text, mbox):

From: Raghav Gururajan <rg <at> raghavgururajan.name>
To: Leo Prikler <leo.prikler <at> student.tugraz.at>, 46536 <at> debbugs.gnu.org
Subject: Re: Fix build of materialdecoration.
Date: Mon, 15 Feb 2021 12:41:07 -0500
[Message part 1 (text/plain, inline)]
Hi Leo!

>> * gnu/packages/cmake.scm (cmake-shared) [git-version]: Update to
>> 1.1.0-32.
> The git-version field doesn't actually change.  You could annotate
> [commit] and [revision] separately, but it usually makes sense to just
> say "update to <commit hash>".
> 
> * gnu/packages/qt.scm (materialdecoration) [git-version]: Update to
>> 1.1.0-9.
> Same here.
> 
>> [arguments]<#:phases>['remove-3rdparty]: New phase.
> Should that be a snippet instead?
> 
>> <#:phases>['remove-3rdparty]: New phase.
> As above.
> 
>> [arguments]<#:configure-flags>[-DCMAKE_CXX_FLAGS]: New flag.
> That's a bit too much nesting.
> "[arguments]<#:configure-flags: Add -DCMAKE_CXX_FLAGS"
> is probably a better choice.
> 
> Otherwise LGTM.

Thanks for the review. I have attached revised patches.

Regards,
RG.
[0001-gnu-cmake-shared-Update-to-1.1.0-32.patch (text/x-patch, attachment)]
[0002-gnu-materialdecoration-Update-to-1.1.0-9.patch (text/x-patch, attachment)]
[OpenPGP_signature (application/pgp-signature, attachment)]

Reply sent to Leo Prikler <leo.prikler <at> student.tugraz.at>:
You have taken responsibility. (Mon, 15 Feb 2021 18:09:02 GMT) Full text and rfc822 format available.

Notification sent to Raghav Gururajan <rg <at> raghavgururajan.name>:
bug acknowledged by developer. (Mon, 15 Feb 2021 18:09:02 GMT) Full text and rfc822 format available.

Message #16 received at 46536-done <at> debbugs.gnu.org (full text, mbox):

From: Leo Prikler <leo.prikler <at> student.tugraz.at>
To: Raghav Gururajan <rg <at> raghavgururajan.name>, 46536-done <at> debbugs.gnu.org, 
 46314-done <at> debbugs.gnu.org
Subject: Re: Fix build of materialdecoration.
Date: Mon, 15 Feb 2021 19:08:39 +0100
Hi Raghav,

Am Montag, den 15.02.2021, 12:41 -0500 schrieb Raghav Gururajan:
> Thanks for the review. I have attached revised patches.
Thanks for the patches.  I've pushed them upstream, so I'll be closing
this and 46314.

Regards,
Leo





Information forwarded to guix-patches <at> gnu.org:
bug#46536; Package guix-patches. (Mon, 15 Feb 2021 18:10:03 GMT) Full text and rfc822 format available.

Message #19 received at 46536-done <at> debbugs.gnu.org (full text, mbox):

From: Raghav Gururajan <rg <at> raghavgururajan.name>
To: Leo Prikler <leo.prikler <at> student.tugraz.at>, 46536-done <at> debbugs.gnu.org,
 46314-done <at> debbugs.gnu.org
Subject: Re: Fix build of materialdecoration.
Date: Mon, 15 Feb 2021 13:09:24 -0500
[Message part 1 (text/plain, inline)]
Hi Leo!

> Thanks for the patches.  I've pushed them upstream, so I'll be closing
> this and 46314.

Thank you!

Regards,
RG.

[OpenPGP_signature (application/pgp-signature, attachment)]

bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Tue, 16 Mar 2021 11:24:06 GMT) Full text and rfc822 format available.

This bug report was last modified 3 years and 14 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.