GNU bug report logs - #46541
[PATCH] gnu: Add ttyload.

Previous Next

Package: guix-patches;

Reported by: Stefan Reichör <stefan <at> xsteve.at>

Date: Mon, 15 Feb 2021 19:29:01 UTC

Severity: normal

Tags: patch

Done: 宋文武 <iyzsong <at> outlook.com>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 46541 in the body.
You can then email your comments to 46541 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#46541; Package guix-patches. (Mon, 15 Feb 2021 19:29:01 GMT) Full text and rfc822 format available.

Acknowledgement sent to Stefan Reichör <stefan <at> xsteve.at>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Mon, 15 Feb 2021 19:29:01 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Stefan Reichör <stefan <at> xsteve.at>
To: guix-patches <at> gnu.org
Cc: Stefan Reichör <stefan <at> xsteve.at>
Subject: [PATCH] gnu: Add ttyload.
Date: Mon, 15 Feb 2021 20:28:25 +0100
* gnu/packages/admin.scm (ttyload): New variable.
---
 gnu/packages/admin.scm | 35 +++++++++++++++++++++++++++++++++++
 1 file changed, 35 insertions(+)

diff --git a/gnu/packages/admin.scm b/gnu/packages/admin.scm
index 77386d6033..f1b398c39a 100644
--- a/gnu/packages/admin.scm
+++ b/gnu/packages/admin.scm
@@ -36,6 +36,7 @@
 ;;; Copyright © 2020 Vincent Legoll <vincent.legoll <at> gmail.com>
 ;;; Copyright © 2020 Morgan Smith <Morgan.J.Smith <at> outlook.com>
 ;;; Copyright © 2021 Zheng Junjie <873216071 <at> qq.com>
+;;; Copyright © 2021 Stefan Reichör <stefan <at> xsteve.at>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -527,6 +528,40 @@ or via the @code{facter} Ruby library.")
     (home-page "https://github.com/puppetlabs/facter-ng")
     (license license:expat)))
 
+(define-public ttyload
+  (let ((revision "1")
+        (commit "f9495372801ce4b4dad98ad854203e694c31c1eb"))
+    (package
+      (name "ttyload")
+      (version (git-version "0.5.3" revision commit))
+      (source
+       (origin
+         (method git-fetch)
+         (uri (git-reference
+               (url "https://github.com/lindes/ttyload")
+               (commit commit)))
+         (file-name (git-file-name name version))
+         (sha256
+          (base32 "0ldb7a13b9v876c6cbrs78pkizj64drnqx95z5shfbwgpwfhr4im"))))
+      (build-system gnu-build-system)
+      (arguments
+       `(#:tests? #f      ; no tests
+         #:make-flags
+         (list (string-append "CC=" ,(cc-for-target)))
+         #:phases
+         (modify-phases %standard-phases
+           (delete 'configure)
+           (replace 'install
+             (lambda* (#:key outputs #:allow-other-keys)
+               (let* ((out (assoc-ref outputs "out"))
+                      (bin (string-append out "/bin")))
+                 (install-file "ttyload" bin)))))))
+      (home-page "https://www.daveltd.com/src/util/ttyload/")
+      (synopsis "Console based color-coded graphs of CPU load average")
+      (description
+       "Show graphs for 1 minute, 5 minute, 15 minute load averages on the console.")
+      (license license:expat))))
+
 (define-public htop
   (package
     (name "htop")
-- 
2.25.1





Information forwarded to guix-patches <at> gnu.org:
bug#46541; Package guix-patches. (Tue, 16 Feb 2021 08:31:01 GMT) Full text and rfc822 format available.

Message #8 received at 46541 <at> debbugs.gnu.org (full text, mbox):

From: 宋文武 <iyzsong <at> outlook.com>
To: Stefan Reichör <stefan <at> xsteve.at>
Cc: 46541 <at> debbugs.gnu.org
Subject: Re: bug#46541: [PATCH] gnu: Add ttyload.
Date: Tue, 16 Feb 2021 16:32:29 +0800
Hello!

Stefan Reichör <stefan <at> xsteve.at> writes:
> [...]
> * gnu/packages/admin.scm (ttyload): New variable.
> +      (home-page "https://www.daveltd.com/src/util/ttyload/")
> +      (synopsis "Console based color-coded graphs of CPU load average")
> +      (description
> +       "Show graphs for 1 minute, 5 minute, 15 minute load averages on the console.")
Better limit lines under 80 characters.

> +      (license license:expat))))
It's a modified "ISC License", I think it should be (fsf-free "file://LICENSE").




Information forwarded to guix-patches <at> gnu.org:
bug#46541; Package guix-patches. (Tue, 16 Feb 2021 19:53:02 GMT) Full text and rfc822 format available.

Message #11 received at 46541 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Reichör <stefan <at> xsteve.at>
To: 宋文武 <iyzsong <at> outlook.com>
Cc: 46541 <at> debbugs.gnu.org
Subject: Re: bug#46541: [PATCH] gnu: Add ttyload.
Date: Tue, 16 Feb 2021 20:52:35 +0100
[Message part 1 (text/plain, inline)]
Hi 宋文武,

thanks for reviewing my patch.

I hope that I do the correct thing in replying to this message (I have
never done this before ;-))

Stefan.

> Hello!
>
> Stefan Reichör <stefan <at> xsteve.at> writes:
>> [...]
>> * gnu/packages/admin.scm (ttyload): New variable.
>> +      (home-page "https://www.daveltd.com/src/util/ttyload/")
>> +      (synopsis "Console based color-coded graphs of CPU load average")
>> +      (description
>> +       "Show graphs for 1 minute, 5 minute, 15 minute load averages on the console.")
> Better limit lines under 80 characters.
>
>> +      (license license:expat))))
> It's a modified "ISC License", I think it should be (fsf-free "file://LICENSE").

[gnu-add-ttyload.patch (text/x-diff, inline)]
gnu: Add ttyload.

From: Stefan Reichör <stefan <at> xsteve.at>

* gnu/packages/admin.scm (ttyload): New variable.
---
 gnu/packages/admin.scm |   36 ++++++++++++++++++++++++++++++++++++
 1 file changed, 36 insertions(+)

diff --git a/gnu/packages/admin.scm b/gnu/packages/admin.scm
index 77386d6033..f2cf28367f 100644
--- a/gnu/packages/admin.scm
+++ b/gnu/packages/admin.scm
@@ -36,6 +36,7 @@
 ;;; Copyright © 2020 Vincent Legoll <vincent.legoll <at> gmail.com>
 ;;; Copyright © 2020 Morgan Smith <Morgan.J.Smith <at> outlook.com>
 ;;; Copyright © 2021 Zheng Junjie <873216071 <at> qq.com>
+;;; Copyright © 2021 Stefan Reichör <stefan <at> xsteve.at>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -527,6 +528,41 @@ or via the @code{facter} Ruby library.")
     (home-page "https://github.com/puppetlabs/facter-ng")
     (license license:expat)))
 
+(define-public ttyload
+  (let ((revision "1")
+        (commit "f9495372801ce4b4dad98ad854203e694c31c1eb"))
+    (package
+      (name "ttyload")
+      (version (git-version "0.5.3" revision commit))
+      (source
+       (origin
+         (method git-fetch)
+         (uri (git-reference
+               (url "https://github.com/lindes/ttyload")
+               (commit commit)))
+         (file-name (git-file-name name version))
+         (sha256
+          (base32 "0ldb7a13b9v876c6cbrs78pkizj64drnqx95z5shfbwgpwfhr4im"))))
+      (build-system gnu-build-system)
+      (arguments
+       `(#:tests? #f      ; no tests
+         #:make-flags
+         (list (string-append "CC=" ,(cc-for-target)))
+         #:phases
+         (modify-phases %standard-phases
+           (delete 'configure)
+           (replace 'install
+             (lambda* (#:key outputs #:allow-other-keys)
+               (let* ((out (assoc-ref outputs "out"))
+                      (bin (string-append out "/bin")))
+                 (install-file "ttyload" bin)))))))
+      (home-page "https://www.daveltd.com/src/util/ttyload/")
+      (synopsis "Console based color-coded graphs of CPU load average")
+      (description
+       "Show graphs for 1 minute, 5 minute, 15 minute load averages on the
+console.")
+      (license (license:fsf-free "file://LICENSE")))))
+
 (define-public htop
   (package
     (name "htop")

Reply sent to 宋文武 <iyzsong <at> outlook.com>:
You have taken responsibility. (Wed, 17 Feb 2021 02:03:02 GMT) Full text and rfc822 format available.

Notification sent to Stefan Reichör <stefan <at> xsteve.at>:
bug acknowledged by developer. (Wed, 17 Feb 2021 02:03:02 GMT) Full text and rfc822 format available.

Message #16 received at 46541-done <at> debbugs.gnu.org (full text, mbox):

From: 宋文武 <iyzsong <at> outlook.com>
To: Stefan Reichör <stefan <at> xsteve.at>
Cc: 46541-done <at> debbugs.gnu.org
Subject: Re: bug#46541: [PATCH] gnu: Add ttyload.
Date: Wed, 17 Feb 2021 10:04:21 +0800
Stefan Reichör <stefan <at> xsteve.at> writes:

> Hi 宋文武,
>
> thanks for reviewing my patch.
>
> I hope that I do the correct thing in replying to this message (I have
> never done this before ;-))

LGTM, pushed, thank you!  (I changed the license to non-copyleft, as
suggested by dftxbs3e in #guix).




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Wed, 17 Mar 2021 11:24:06 GMT) Full text and rfc822 format available.

This bug report was last modified 3 years and 33 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.