GNU bug report logs - #46558
Interaction between font-lock-extend-region-wholelines and font-lock-extend-region-multiline

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 46558 in the body.
You can then email your comments to 46558 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Sébastien Miquel <sebastien.miquel <at> posteo.eu>
To: bug-gnu-emacs <at> gnu.org
Subject: Interaction between font-lock-extend-region-wholelines and
 font-lock-extend-region-multiline
Date: Tue, 16 Feb 2021 13:13:17 +0100

Hi,

In org-mode, blocks are fontified with the font-lock-multiline
property. When editing the line right before a block, the whole block
is needlessly refontified (use highlight-refontification-mode to
check).

This is because the font-lock-extend-region-wholelines extends the
region to the beginning of the next line, which has the
font-lock-multiline property. Then font-lock-extend-region-multiline
extends the region to the end of the block.

If a second block follows the first one, with no empty line between,
it is refontified as well.

Maybe font-lock-extend-region-multiline should check if the char
right before font-lock-end has the font-lock-multiline property as
well before extending the region. I've tried it, and haven't found any
issue in this use case.

-- 
Sébastien Miquel

Message #8 received at 46558 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Sébastien Miquel <sebastien.miquel <at> posteo.eu>
Cc: 46558 <at> debbugs.gnu.org
Subject: Re: bug#46558: Interaction between
 font-lock-extend-region-wholelines and font-lock-extend-region-multiline
Date: Fri, 17 Jun 2022 17:19:52 +0200

Sébastien Miquel <sebastien.miquel <at> posteo.eu> writes:

> Maybe font-lock-extend-region-multiline should check if the char
> right before font-lock-end has the font-lock-multiline property as
> well before extending the region. I've tried it, and haven't found any
> issue in this use case.

(I'm going through old bug reports that unfortunately weren't resolved
at the time.)

Do you have a patch to propose here, by any chance?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #13 received at 46558 <at> debbugs.gnu.org (full text, mbox):

From: Sébastien Miquel <sebastien.miquel <at> posteo.eu>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 46558 <at> debbugs.gnu.org
Subject: Re: bug#46558: Interaction between font-lock-extend-region-wholelines
 and font-lock-extend-region-multiline
Date: Sun, 19 Jun 2022 12:56:24 +0000

[Message part 1 (text/plain, inline)]

Hi,

Lars Ingebrigtsen writes:
> Do you have a patch to propose here, by any chance?

Here's what I had in mind.

-- 
Sébastien Miquel

[0001-Small-fix-in-font-lock-extend-region-multiline-Bug-4.patch (text/x-patch, attachment)]

Message #16 received at 46558 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Sébastien Miquel <sebastien.miquel <at> posteo.eu>
Cc: 46558 <at> debbugs.gnu.org
Subject: Re: bug#46558: Interaction between
 font-lock-extend-region-wholelines and font-lock-extend-region-multiline
Date: Sun, 19 Jun 2022 15:13:01 +0200

Sébastien Miquel <sebastien.miquel <at> posteo.eu> writes:

>> Do you have a patch to propose here, by any chance?
>
> Here's what I had in mind.

Thanks; pushed to Emacs 29.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.