GNU bug report logs - #46587
[PATCH] gnu: Add libretro-lowresnx.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 46587 in the body.
You can then email your comments to 46587 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: iyzsong <at> outlook.com
To: guix-patches <at> gnu.org
Cc: 宋文武 <iyzsong <at> member.fsf.org>
Subject: [PATCH] gnu: Add libretro-lowresnx.
Date: Wed, 17 Feb 2021 18:47:56 +0800

From: 宋文武 <iyzsong <at> member.fsf.org>

* gnu/packages/emulators.scm (libretro-lowresnx): New variable.
---
 gnu/packages/emulators.scm | 42 +++++++++++++++++++++++++++++++++++++-
 1 file changed, 41 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/emulators.scm b/gnu/packages/emulators.scm
index 05cd0d65c5..eca003f738 100644
--- a/gnu/packages/emulators.scm
+++ b/gnu/packages/emulators.scm
@@ -1,7 +1,7 @@
 ;;; GNU Guix --- Functional package management for GNU
 ;;; Copyright © 2015 Mark H Weaver <mhw <at> netris.org>
 ;;; Copyright © 2015 Paul van der Walt <paul <at> denknerd.org>
-;;; Copyright © 2015, 2016 Sou Bunnbu <iyzsong <at> gmail.com>
+;;; Copyright © 2015, 2016, 2021 Sou Bunnbu <iyzsong <at> member.fsf.org>
 ;;; Copyright © 2015, 2016 Taylan Ulrich Bayırlı/Kammer <taylanbayirli <at> gmail.com>
 ;;; Copyright © 2015, 2018 David Thompson <dthompson2 <at> worcester.edu>
 ;;; Copyright © 2016 Manolis Fragkiskos Ragkousis <manolis837 <at> gmail.com>
@@ -36,6 +36,7 @@
   #:use-module (guix download)
   #:use-module (guix git-download)
   #:use-module (guix svn-download)
+  #:use-module (guix utils)
   #:use-module (gnu packages)
   #:use-module (gnu packages algebra)
   #:use-module (gnu packages assembly)
@@ -1231,6 +1232,45 @@ System (NES/Famicom) emulator Nestopia, with enhancements from members of the
 emulation community.  It provides highly accurate emulation.")
     (license license:gpl2+)))
 
+(define-public libretro-lowresnx
+  (let ((commit "743ab43a6c4a13e0d5363b0d25ac12c7511c6581")
+        (revision "1"))
+    (package
+      (name "libretro-lowresnx")
+      (version (git-version "1.1" revision commit))
+      (source (origin
+                (method git-fetch)
+                (uri (git-reference
+                      (url "https://github.com/timoinutilis/lowres-nx")
+                      (commit commit)))
+                (file-name (git-file-name name version))
+                (sha256
+                 (base32
+                  "0r15kb5p5s2jwky6zy4v1j9i95i4rz36p9wxg0g6xdjksf04b5cf"))))
+      (build-system gnu-build-system)
+      (arguments
+       `(#:tests? #f                    ; no tests
+         #:phases
+         (modify-phases %standard-phases
+           (delete 'configure)          ; no configure script
+           (replace 'build
+             (lambda _
+               (invoke "make" "-C" "platform/LibRetro"
+                       (string-append "CC=" ,(cc-for-target)))))
+           (replace 'install
+             (lambda* (#:key outputs #:allow-other-keys)
+               (let* ((out (assoc-ref outputs "out"))
+                      (libretrodir (string-append out "/lib/libretro")))
+                 (install-file "platform/LibRetro/lowresnx_libretro.so"
+                               libretrodir)))))))
+      (home-page "https://lowresnx.inutilis.com/")
+      (synopsis "Libretro core for LowRES NX")
+      (description "LowRES NX is a simulated retro game console, which can be
+programmed in the classic BASIC language.  This package provides a libretro
+core allowing the lowRES NX programs to be used with libretro frontends such
+as RetroArch.")
+      (license license:zlib))))
+
 (define-public retroarch
   (package
     (name "retroarch")
-- 
2.30.0

Message #8 received at 46587 <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: iyzsong <at> outlook.com
Cc: 宋文武 <iyzsong <at> member.fsf.org>, 46587 <at> debbugs.gnu.org
Subject: Re: [bug#46587] [PATCH] gnu: Add libretro-lowresnx.
Date: Thu, 18 Feb 2021 13:52:36 -0500

On Wed, Feb 17, 2021 at 06:47:56PM +0800, iyzsong <at> outlook.com wrote:
> From: 宋文武 <iyzsong <at> member.fsf.org>
> 
> * gnu/packages/emulators.scm (libretro-lowresnx): New variable.

Thanks for the patch!

> +           (replace 'build
> +             (lambda _
> +               (invoke "make" "-C" "platform/LibRetro"
> +                       (string-append "CC=" ,(cc-for-target)))))

I think it's more idiomatic for Guix to use #:make-flags, maybe like
this (untested!):

(#:make-flags
  (list "-C" "platform/LibRetro"
        (string-append "CC=" ,(cc-for-target))))

... but either way is fine.

Message #13 received at 46587-done <at> debbugs.gnu.org (full text, mbox):

From: 宋文武 <iyzsong <at> outlook.com>
To: Leo Famulari <leo <at> famulari.name>
Cc: 宋文武 <iyzsong <at> member.fsf.org>,
 46587-done <at> debbugs.gnu.org
Subject: Re: bug#46587: [PATCH] gnu: Add libretro-lowresnx.
Date: Sat, 20 Feb 2021 19:54:35 +0800

Leo Famulari <leo <at> famulari.name> writes:

> On Wed, Feb 17, 2021 at 06:47:56PM +0800, iyzsong <at> outlook.com wrote:
>> From: 宋文武 <iyzsong <at> member.fsf.org>
>> 
>> * gnu/packages/emulators.scm (libretro-lowresnx): New variable.
>
> Thanks for the patch!
>
>> +           (replace 'build
>> +             (lambda _
>> +               (invoke "make" "-C" "platform/LibRetro"
>> +                       (string-append "CC=" ,(cc-for-target)))))
>
> I think it's more idiomatic for Guix to use #:make-flags, maybe like
> this (untested!):
>

It works, pushed, thank you!

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.