GNU bug report logs - #46598
[PATCH] gnu: Add vitetris.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 46598 in the body.
You can then email your comments to 46598 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Stefan Reichör <stefan <at> xsteve.at>
To: guix-patches <at> gnu.org
Cc: Stefan Reichör <stefan <at> xsteve.at>
Subject: [PATCH] gnu: Add vitetris.
Date: Wed, 17 Feb 2021 21:08:53 +0100

* gnu/packages/games.scm (vitetris): New variable.
---
 gnu/packages/games.scm | 34 ++++++++++++++++++++++++++++++++++
 1 file changed, 34 insertions(+)

diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm
index d8c98a9a2f..9683e1cbb7 100644
--- a/gnu/packages/games.scm
+++ b/gnu/packages/games.scm
@@ -57,6 +57,7 @@
 ;;; Copyright © 2020 Lu hux <luhux <at> outlook.com>
 ;;; Copyright © 2020 Tomás Ortín Fernández <tomasortin <at> mailbox.org>
 ;;; Copyright © 2021 Olivier Rojon <o.rojon <at> posteo.net>
+;;; Copyright © 2021 Stefan Reichör <stefan <at> xsteve.at>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -545,6 +546,39 @@ Playing bastet can be a painful experience, especially if you usually make
 canyons and wait for the long I-shaped block to clear four rows at a time.")
     (license license:gpl3+)))
 
+(define-public vitetris
+  (package
+    (name "vitetris")
+    (version "v0.59.1")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/vicgeralds/vitetris")
+             (commit version)))
+       (sha256
+        (base32 "1ah1c5g7abksif0n8v5rb7r4pn2az20c3mkp4ak13vgs23ddmds5"))
+       (file-name (git-file-name name version))))
+    (build-system gnu-build-system)
+    (arguments
+     `(#:phases (modify-phases %standard-phases
+                  (replace 'configure
+                    (lambda _
+                      ;; the non standard configure script does not accept
+                      ;; standard parameters -> invoke configure by hand
+                      (invoke "./configure")
+                      ;; src/src-conf.mk must be writable for the build step
+                      (chmod "src/src-conf.mk" #o666)
+                      #t)))
+       #:tests? #f   ; no test
+       #:make-flags
+       (list ,(string-append "CC=" (cc-for-target))
+             (string-append "DESTDIR=" (assoc-ref %outputs "out")))))
+    (home-page "http://victornils.net/tetris/")
+    (synopsis "Terminal-based tetris clone")
+    (description "Classic multiplayer tetris for the terminal.")
+    (license license:bsd-2)))
+
 (define-public blobwars
   (package
     (name "blobwars")
-- 
2.25.1

Message #8 received at 46598 <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Stefan Reichör <stefan <at> xsteve.at>
Cc: 46598 <at> debbugs.gnu.org
Subject: Re: [bug#46598] [PATCH] gnu: Add vitetris.
Date: Thu, 18 Feb 2021 11:47:55 +0100

Hello,

Stefan Reichör <stefan <at> xsteve.at> writes:

> * gnu/packages/games.scm (vitetris): New variable.

Thank you! Some comments follow.


> +    (version "v0.59.1")

You're mixing the version and the tag name. The version should be
"0.59.1"...

> +    (source
> +     (origin
> +       (method git-fetch)
> +       (uri (git-reference
> +             (url "https://github.com/vicgeralds/vitetris")
> +             (commit version)))

... and the commit should be (string-append "v" version).

> +                      ;; src/src-conf.mk must be writable for the build step
> +                      (chmod "src/src-conf.mk" #o666)

I suggest (make-file-writeable "src/src-conf.mk")

> +                      #t)))

You can omit it.

> +       #:tests? #f   ; no test
> +       #:make-flags
> +       (list ,(string-append "CC=" (cc-for-target))
> +             (string-append "DESTDIR=" (assoc-ref %outputs "out")))))

There is an issue here.  The install script does not install executable
in %out/bin, but in %out/usr/local/bin.

> +    (home-page "http://victornils.net/tetris/")
> +    (synopsis "Terminal-based tetris clone")

tetris -> Tetris

> +    (description "Classic multiplayer tetris for the terminal.")

I suggest:

  Vitetris is a classic multiplayer Tetris clone for the terminal.


Could you send an updated patch?

Regards,
-- 
Nicolas Goaziou

Message #11 received at 46598 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Reichör <stefan <at> xsteve.at>
To: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Cc: 46598 <at> debbugs.gnu.org
Subject: Re: [bug#46598] [PATCH] gnu: Add vitetris.
Date: Thu, 18 Feb 2021 21:26:06 +0100

[Message part 1 (text/plain, inline)]

Hi Nicolas,

thanks for the detailed review of my patch.

I didn't think that I am able to produce a patch with that many little
shortcomings ;-)

Your help is highly appreciated!

> Hello,
>
> Stefan Reichör <stefan <at> xsteve.at> writes:
>
>> * gnu/packages/games.scm (vitetris): New variable.
>
> Thank you! Some comments follow.
>
>
>> +    (version "v0.59.1")
>
> You're mixing the version and the tag name. The version should be
> "0.59.1"...
>
>> +    (source
>> +     (origin
>> +       (method git-fetch)
>> +       (uri (git-reference
>> +             (url "https://github.com/vicgeralds/vitetris")
>> +             (commit version)))
>
> ... and the commit should be (string-append "v" version).
>
>> +                      ;; src/src-conf.mk must be writable for the build step
>> +                      (chmod "src/src-conf.mk" #o666)
>
> I suggest (make-file-writeable "src/src-conf.mk")
>
>> +                      #t)))
>
> You can omit it.
>
>> +       #:tests? #f   ; no test
>> +       #:make-flags
>> +       (list ,(string-append "CC=" (cc-for-target))
>> +             (string-append "DESTDIR=" (assoc-ref %outputs "out")))))
>
> There is an issue here.  The install script does not install executable
> in %out/bin, but in %out/usr/local/bin.
>
>> +    (home-page "http://victornils.net/tetris/")
>> +    (synopsis "Terminal-based tetris clone")
>
> tetris -> Tetris
>
>> +    (description "Classic multiplayer tetris for the terminal.")
>
> I suggest:
>
>   Vitetris is a classic multiplayer Tetris clone for the terminal.
>
>
> Could you send an updated patch?

Of course - I hope that I have addressed all the issues.

> Regards,

[gnu-add-vitetris.patch (text/x-diff, inline)]

gnu: Add vitetris.

From: Stefan Reichör <stefan <at> xsteve.at>

* gnu/packages/games.scm (vitetris): New variable.
---
 gnu/packages/games.scm |   34 ++++++++++++++++++++++++++++++++++
 1 file changed, 34 insertions(+)

diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm
index d8c98a9a2f..bab2714c0d 100644
--- a/gnu/packages/games.scm
+++ b/gnu/packages/games.scm
@@ -57,6 +57,7 @@
 ;;; Copyright © 2020 Lu hux <luhux <at> outlook.com>
 ;;; Copyright © 2020 Tomás Ortín Fernández <tomasortin <at> mailbox.org>
 ;;; Copyright © 2021 Olivier Rojon <o.rojon <at> posteo.net>
+;;; Copyright © 2021 Stefan Reichör <stefan <at> xsteve.at>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -545,6 +546,39 @@ Playing bastet can be a painful experience, especially if you usually make
 canyons and wait for the long I-shaped block to clear four rows at a time.")
     (license license:gpl3+)))
 
+(define-public vitetris
+  (package
+    (name "vitetris")
+    (version "0.59.1")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/vicgeralds/vitetris")
+             (commit (string-append "v" version))))
+       (sha256
+        (base32 "1ah1c5g7abksif0n8v5rb7r4pn2az20c3mkp4ak13vgs23ddmds5"))
+       (file-name (git-file-name name version))))
+    (build-system gnu-build-system)
+    (arguments
+     `(#:phases (modify-phases %standard-phases
+                  (replace 'configure
+                    (lambda _
+                      ;; the non standard configure script does not accept
+                      ;; standard parameters -> invoke configure by hand
+                      (invoke "./configure" "prefix=")
+                      ;; src/src-conf.mk must be writable for the build step
+                      (make-file-writable "src/src-conf.mk"))))
+       #:tests? #f   ; no test
+       #:make-flags
+       (list ,(string-append "CC=" (cc-for-target))
+             (string-append "DESTDIR=" (assoc-ref %outputs "out")))))
+    (home-page "http://victornils.net/tetris/")
+    (synopsis "Terminal-based Tetris clone")
+    (description "Vitetris is a classic multiplayer Tetris clone for the
+terminal.")
+    (license license:bsd-2)))
+
 (define-public blobwars
   (package
     (name "blobwars")

Message #16 received at 46598-done <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Stefan Reichör <stefan <at> xsteve.at>
Cc: 46598-done <at> debbugs.gnu.org
Subject: Re: [bug#46598] [PATCH] gnu: Add vitetris.
Date: Thu, 18 Feb 2021 22:44:08 +0100

Stefan Reichör <stefan <at> xsteve.at> writes:

> I didn't think that I am able to produce a patch with that many little
> shortcomings ;-)

Heh :)

> Of course - I hope that I have addressed all the issues.

Perfect! Applied. Thank you!

Regards,

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.