GNU bug report logs - #46619
[PATCH] Make assert-valid-graph public

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 46619 in the body.
You can then email your comments to 46619 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Andrew Tropin <andrew <at> trop.in>
To: guix-patches <at> gnu.org
Subject: Fwd: [PATCH] Make assert-valid-graph public
Date: Thu, 18 Feb 2021 21:19:54 +0300

[Message part 1 (text/plain, inline)]

I would like to reuse assert-valid-graph function for home-shepherd-service
for `guix home` I'm currently implementing. It seems reasonable to make this
function public instead of copying or reimplementing it.

-- 
Best regards,
Andrew Tropin

[0001-gnu-services-shepherd-Make-assert-valid-graph-public.patch (application/x-patch, attachment)]

Message #12 received at 46619-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Andrew Tropin <andrew <at> trop.in>
Cc: 46619-done <at> debbugs.gnu.org
Subject: Re: bug#46619: [PATCH] Make assert-valid-graph public
Date: Wed, 03 Mar 2021 14:22:32 +0100

Hi Andrew,

Andrew Tropin <andrew <at> trop.in> skribis:

> From ffc244f5845996bf4b0365024ac866c86cef81df Mon Sep 17 00:00:00 2001
> From: Andrew Tropin <andrew <at> trop.in>
> Date: Thu, 18 Feb 2021 13:30:22 +0300
> Subject: [PATCH] gnu: services: shepherd: Make assert-valid-graph public
>
> ---
>  gnu/services/shepherd.scm | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)

I added a commit log and pushed as
63bee8f0addc95c81426199c9fbf1d0bcf7f1450.

As mentioned on IRC, note that this kind of procedure doesn’t make for a
great API, which is why it’s usually kept private.  Second, if a
procedure like this one doesn’t have any user in Guix proper, it could
well be removed or changed incompatibly, so beware.

In this case, I think it’s acceptable to make it public though.

Thanks and apologies for the delay!

Ludo’.

Message #15 received at 46619-done <at> debbugs.gnu.org (full text, mbox):

From: Andrew Tropin <andrew <at> trop.in>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 46619-done <at> debbugs.gnu.org
Subject: Re: bug#46619: [PATCH] Make assert-valid-graph public
Date: Wed, 3 Mar 2021 17:40:25 +0300

> As mentioned on IRC, note that this kind of procedure doesn\u2019t make for a
> great API, which is why it's usually kept private. Second, if a
> procedure like this one doesn't have any user in Guix proper, it could
> well be removed or changed incompatibly, so beware.

Took into account. Hope, it will be used by one small guix's module
someday) Plan to propose to include `guix home` in guix
repo. https://git.sr.ht/~abcdw/rde/tree/master/item/gnu

>
> In this case, I think it's acceptable to make it public though.
>
> Thanks and apologies for the delay!
>
> Ludo'.

Thank you for all your work!

-- 
Best regards,
Andrew Tropin

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.