GNU bug report logs - #46660
[PATCH] 28.0.50; Support for PKGBUILD files on Arch Linux

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 46660 in the body.
You can then email your comments to 46660 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Utkarsh Singh <utkarsh190601 <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] 28.0.50; Support for PKGBUILD files on Arch Linux
Date: Sat, 20 Feb 2021 11:06:04 +0530

[Message part 1 (text/plain, inline)]

Hi,

Can we add support for PKGBUILD(1) files for Emacs which are used to
install packages from AUR(Arch User Repository).

PKGBUILD are just normal shell script files, so we just have to add
sh mode to it:
diff --git a/lisp/files.el b/lisp/files.el
index 68e883513c..7d01938144 100644
--- a/lisp/files.el
+++ b/lisp/files.el
@@ -2723,6 +2723,7 @@ auto-mode-alist
      ("\\.scm\\.[0-9]*\\'" . scheme-mode)
      ("\\.[ckz]?sh\\'\\|\\.shar\\'\\|/\\.z?profile\\'" . sh-mode)
      ("\\.bash\\'" . sh-mode)
+     ("PKGBUILD$" . sh-mode)
      ("\\(/\\|\\`\\)\\.\\(bash_\\(profile\\|history\\|log\\(in\\|out\\)\\)\\|z?log\\(in\\|out\\)\\)\\'" . sh-mode)
      ("\\(/\\|\\`\\)\\.\\(shrc\\|zshrc\\|m?kshrc\\|bashrc\\|t?cshrc\\|esrc\\)\\'" . sh-mode)
      ("\\(/\\|\\`\\)\\.\\([kz]shenv\\|xinitrc\\|startxrc\\|xsession\\)\\'" . sh-mode)

There is also a special pkgbuild-mode(2) for editing these files which
is also an derivation of sh-mode.

[1]: https://wiki.archlinux.org/index.php/PKGBUILD
[2]: https://github.com/juergenhoetzel/pkgbuild-mode
-- 
Utkarsh Singh

[signature.asc (application/pgp-signature, inline)]

Message #8 received at 46660 <at> debbugs.gnu.org (full text, mbox):

From: Andreas Schwab <schwab <at> linux-m68k.org>
To: Utkarsh Singh <utkarsh190601 <at> gmail.com>
Cc: 46660 <at> debbugs.gnu.org
Subject: Re: bug#46660: [PATCH] 28.0.50; Support for PKGBUILD files on Arch
 Linux
Date: Sat, 20 Feb 2021 09:42:13 +0100

On Feb 20 2021, Utkarsh Singh wrote:

> diff --git a/lisp/files.el b/lisp/files.el
> index 68e883513c..7d01938144 100644
> --- a/lisp/files.el
> +++ b/lisp/files.el
> @@ -2723,6 +2723,7 @@ auto-mode-alist
>       ("\\.scm\\.[0-9]*\\'" . scheme-mode)
>       ("\\.[ckz]?sh\\'\\|\\.shar\\'\\|/\\.z?profile\\'" . sh-mode)
>       ("\\.bash\\'" . sh-mode)
> +     ("PKGBUILD$" . sh-mode)

Use "\\'" instead of "$".  Is this supposed to match "fooPKGBUILD"?

Andreas.

-- 
Andreas Schwab, schwab <at> linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510  2552 DF73 E780 A9DA AEC1
"And now for something completely different."

Message #11 received at 46660 <at> debbugs.gnu.org (full text, mbox):

From: Utkarsh Singh <utkarsh190601 <at> gmail.com>
To: 46660 <at> debbugs.gnu.org
Subject: [Andreas Schwab] Re: bug#46660: [PATCH] 28.0.50; Support for
 PKGBUILD files on Arch Linux
Date: Sat, 20 Feb 2021 17:46:06 +0530

[Message part 1 (text/plain, inline)]

Andreas Schwab <schwab <at> linux-m68k.org> writes:

> Use "\\'" instead of "$".  Is this supposed to match "fooPKGBUILD"?

Thanks I was unaware of this particular regex!

diff --git a/lisp/files.el b/lisp/files.el
index 68e883513c..393b3472f7 100644
--- a/lisp/files.el
+++ b/lisp/files.el
@@ -2723,6 +2723,7 @@ auto-mode-alist
("\\.scm\\.[0-9]*\\'" . scheme-mode)
("\\.[ckz]?sh\\'\\|\\.shar\\'\\|/\\.z?profile\\'" . sh-mode)
("\\.bash\\'" . sh-mode)
+     ("PKGBUILD\\'" . sh-mode)
("\\(/\\|\\`\\)\\.\\(bash_\\(profile\\|history\\|log\\(in\\|out\\)\\)\\|z?log\\(in\\|out\\)\\)\\'" .
sh-mode)
("\\(/\\|\\`\\)\\.\\(shrc\\|zshrc\\|m?kshrc\\|bashrc\\|t?cshrc\\|esrc\\)\\'" . sh-mode)
	("\\(/\\|\\`\\)\\.\\([kz]shenv\\|xinitrc\\|startxrc\\|xsession\\)\\'" . sh-mode)
-- 
Utkarsh Singh

[signature.asc (application/pgp-signature, inline)]

Message #14 received at 46660 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Utkarsh Singh <utkarsh190601 <at> gmail.com>
Cc: 46660 <at> debbugs.gnu.org
Subject: Re: bug#46660: [PATCH] 28.0.50; Support for PKGBUILD files on Arch
 Linux
Date: Mon, 22 Feb 2021 16:08:41 +0100

Utkarsh Singh <utkarsh190601 <at> gmail.com> writes:

> Andreas Schwab <schwab <at> linux-m68k.org> writes:
>
>> Use "\\'" instead of "$".  Is this supposed to match "fooPKGBUILD"?
>
> Thanks I was unaware of this particular regex!

[...]

> +     ("PKGBUILD\\'" . sh-mode)

Thanks, but this will still match "fooPKGBUILD".  Is that the intention,
or are these files called only "PKGBUILD" without any prefix?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #17 received at 46660 <at> debbugs.gnu.org (full text, mbox):

From: Utkarsh Singh <utkarsh190601 <at> gmail.com>
To: 46660 <at> debbugs.gnu.org
Subject: [Utkarsh Singh] Re: bug#46660: [PATCH] 28.0.50; Support for
 PKGBUILD files on Arch Linux
Date: Tue, 23 Feb 2021 10:01:02 +0530

> Thanks, but this will still match "fooPKGBUILD".  Is that the intention,
> or are these files called only "PKGBUILD" without any prefix?

Yes, these file are only called PKGBUILD without any post-fix.

For prefix shouldn't they match the file path for ex:
'/home/user/emacs/PKGBUILD' or is file path ignored in this case?
-- 
Utkarsh Singh

Message #20 received at 46660 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Utkarsh Singh <utkarsh190601 <at> gmail.com>
Cc: 46660 <at> debbugs.gnu.org
Subject: Re: bug#46660: [Utkarsh Singh] Re: bug#46660: [PATCH] 28.0.50;
 Support for PKGBUILD files on Arch Linux
Date: Tue, 23 Feb 2021 16:43:02 +0100

Utkarsh Singh <utkarsh190601 <at> gmail.com> writes:

>> Thanks, but this will still match "fooPKGBUILD".  Is that the intention,
>> or are these files called only "PKGBUILD" without any prefix?
>
> Yes, these file are only called PKGBUILD without any post-fix.
>
> For prefix shouldn't they match the file path for ex:
> '/home/user/emacs/PKGBUILD' or is file path ignored in this case?

I interpret this to mean that the files are called "PKGBUILD", with no
prefix, and I've committed your patch (with a change to match exactly
that) to Emacs 28.  (The fix is to add a "/" to the start of the regexp,
since we're matching on the entire file name.)

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.