GNU bug report logs - #46680
[PATCH] gnu: Add midicomp.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 46680 in the body.
You can then email your comments to 46680 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Alexandros Theodotou <alex <at> zrythm.org>
To: guix-patches <at> gnu.org
Cc: Alexandros Theodotou <alex <at> zrythm.org>
Subject: [PATCH] gnu: Add midicomp.
Date: Sun, 21 Feb 2021 10:21:37 +0000

* gnu/packages/audio.scm (midicomp): New variable.
---
 gnu/packages/audio.scm | 31 +++++++++++++++++++++++++++++++
 1 file changed, 31 insertions(+)

diff --git a/gnu/packages/audio.scm b/gnu/packages/audio.scm
index 16e0eec418..e910c314fd 100644
--- a/gnu/packages/audio.scm
+++ b/gnu/packages/audio.scm
@@ -1223,6 +1223,37 @@ object library.")
 language and software synthesizer.")
     (license license:lgpl2.1+)))
 
+(define-public midicomp
+  ;; The latest tagged release is 9 years old and there have been
+  ;; unreleased fixes, so we take the last commit.
+  (let ((commit "70f76963cb0cdb3cbe03ec6e7246b1fb885d3c68")
+        (revision "1"))
+    (package
+      (name "midicomp")
+      (version (string-append "0.0.6-" revision "." (string-take commit 7)))
+      (source
+        (origin
+          (method git-fetch)
+          (uri (git-reference
+                 (url "https://github.com/markc/midicomp")
+                 (commit commit)))
+          (file-name (git-file-name name version))
+          (sha256
+           (base32
+            "12zh247c6v88ssy4l8v7yirh4bl2jcc1ch7f4gdry79a82kai1gf"))))
+     (build-system cmake-build-system)
+     (arguments
+      `(#:tests? #f))  ; no "check" target
+      (synopsis "MIDI compiler")
+      (description
+       "midicomp can manipulate SMF (Standard MIDI File) files.  It can both
+  read and write SMF files in 0 or format 1 and also read and write its own
+  plain text format.  This means a SMF file can be turned into easily
+  parseable text, edited with any text editor or filtered through any script
+  language, and recompiled back into a binary SMF file.")
+      (home-page "https://github.com/markc/midicomp")
+      (license license:agpl3))))
+
 (define-public clalsadrv
   (package
     (name "clalsadrv")
-- 
2.30.0

Message #8 received at 46680 <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Alexandros Theodotou <alex <at> zrythm.org>
Cc: 46680 <at> debbugs.gnu.org
Subject: Re: [bug#46680] [PATCH] gnu: Add midicomp.
Date: Tue, 23 Feb 2021 18:47:05 +0100

Hello,

Alexandros Theodotou <alex <at> zrythm.org> writes:

> * gnu/packages/audio.scm (midicomp): New variable.

Thank you. Some comments follow.

> +    (package
> +      (name "midicomp")
> +      (version (string-append "0.0.6-" revision "." (string-take commit 7)))

According to the README, the last version is 0.0.8. Also, the above
should be written more compactly

  (version (git-version "0.0.8" revision commit))

> +      (synopsis "MIDI compiler")

I suggest "Convert SMF MIDI files to and from plain text", which may be
more explicit.

> +      (license license:agpl3))))

I think there is an issue here. The repository has no LICENSE file, and
source code files have no license header. The only reference to AGPL3.0
is in the README.md. I'm not sure this is sufficient.

WDYT?

Regards,
-- 
Nicolas Goaziou

Message #11 received at 46680 <at> debbugs.gnu.org (full text, mbox):

From: Alexandros Theodotou <alex <at> zrythm.org>
To: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Cc: 46680 <at> debbugs.gnu.org
Subject: Re: [bug#46680] [PATCH] gnu: Add midicomp.
Date: Tue, 23 Feb 2021 18:56:13 +0000

[Message part 1 (text/plain, inline)]

Hi,

Thanks for the feedback, I updated the patch (attached).

I saw the conversation on IRC and I believe we should take the word of
the author if it's explicitly mentioned in the README.

>I think there is an issue here. The repository has no LICENSE file,
> and
> source code files have no license header. The only reference to
> AGPL3.0
> is in the README.md. I'm not sure this is sufficient.

Thanks,
Alex

[0001-gnu-Add-midicomp.patch (text/x-patch, attachment)]

Message #16 received at 46680-done <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Alexandros Theodotou <alex <at> zrythm.org>
Cc: 46680-done <at> debbugs.gnu.org
Subject: Re: [bug#46680] [PATCH] gnu: Add midicomp.
Date: Tue, 23 Feb 2021 20:07:50 +0100

Alexandros Theodotou <alex <at> zrythm.org> writes:

> Thanks for the feedback, I updated the patch (attached).

Thank you.

> I saw the conversation on IRC and I believe we should take the word of
> the author if it's explicitly mentioned in the README.

Indeed. I applied your patch with a minor fix.

> +      (version (git-version "0.0.8-" revision commit))

"0.0.8-"  -> "0.0.8"

Regards,

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.