GNU bug report logs - #46686
[PATCH] gnu: add libucl

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 46686 in the body.
You can then email your comments to 46686 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: qblade <qblade <at> protonmail.com>
To: "guix-patches <at> gnu.org" <guix-patches <at> gnu.org>
Subject: [PATCH] gnu: add libucl
Date: Sun, 21 Feb 2021 07:21:15 +0000

[Message part 1 (text/plain, inline)]

Empty Message

[0001-gnu-add-libucl.patch (text/x-patch, attachment)]

Message #8 received at 46686 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: qblade <qblade <at> protonmail.com>
Cc: 46686 <at> debbugs.gnu.org
Subject: Re: bug#46686: [PATCH] gnu: add libucl
Date: Sat, 06 Mar 2021 11:32:51 +0100

Hi,

qblade <qblade <at> protonmail.com> skribis:

> From aae95593f1cfd48c50578bec83927c870afc6bce Mon Sep 17 00:00:00 2001
> From: qblade <qblade <at> protonmail.com>
> Date: Sun, 21 Feb 2021 06:48:18 +0000
> Subject: [PATCH] gnu: add libucl
>
> * gnu/packages/config-lang.scm (libucl): New variable.

Thanks for the patch!  It looks good to me, modulo the minor issues
below.

>  gnu/packages/config-lang.scm | 54 ++++++++++++++++++++++++++++++++++++

Could you perhaps find another file to add it to, so we don’t have a
module for a single package?  That said, I don’t have a good suggestion,
since ‘iniparser’ for instance is in samba.scm.

> +    (synopsis "Universal configuration language")
> +    (description "Universal configuration language.
> +fully compatible with JSON format and is able to parse json files")

Could you reword the description with full sentences, along the lines of:

  https://guix.gnu.org/manual/en/html_node/Synopses-and-Descriptions.html

Make sure to capitalize acronyms like JSON.

TIA,
Ludo’.

Message #11 received at 46686 <at> debbugs.gnu.org (full text, mbox):

From: qblade <qblade <at> protonmail.com>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: "46686 <at> debbugs.gnu.org" <46686 <at> debbugs.gnu.org>
Subject: 回复： Re: bug#46686: [PATCH] gnu: add libucl
Date: Sun, 07 Mar 2021 03:08:09 +0000

[Message part 1 (text/plain, inline)]

Hello, I submitted a new patch, because libucl is currently only used in hikari (I will submit its package definition later) I decided to put it in gnu/packages/wm.scm

hikari's home pager: https://hikari.acmelabs.space/

[0001-gnu-add-libucl.patch (text/x-patch, attachment)]

Message #16 received at 46686-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: qblade <qblade <at> protonmail.com>
Cc: "46686 <at> debbugs.gnu.org" <46686-done <at> debbugs.gnu.org>
Subject: Re: bug#46686: [PATCH] gnu: add libucl
Date: Wed, 17 Mar 2021 22:24:52 +0100

Hi,

qblade <qblade <at> protonmail.com> skribis:

> From f80bb9ea8d4161e351b30b6154d25cbfca8095fd Mon Sep 17 00:00:00 2001
> From: qblade <qblade <at> protonmail.com>
> Date: Sun, 7 Mar 2021 02:31:07 +0000
> Subject: [PATCH] gnu: add libucl
>
> * gnu/packages/wm.scm (libucl): New variable.

Applied with minor tweaks to the description.

Thanks,
Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.