GNU bug report logs - #46697
[PATCH] Added capstone 4.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 46697 in the body.
You can then email your comments to 46697 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Gerd Heber <gerd.heber <at> gmail.com>
To: guix-patches <at> gnu.org
Cc: Gerd Heber <gheber <at> hdfgroup.org>
Subject: [PATCH] Added capstone 4.
Date: Sun, 21 Feb 2021 16:35:21 -0600

---
 gnu/packages/engineering.scm | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)

diff --git a/gnu/packages/engineering.scm b/gnu/packages/engineering.scm
index 034dabc3f9..4987377840 100644
--- a/gnu/packages/engineering.scm
+++ b/gnu/packages/engineering.scm
@@ -1495,6 +1495,31 @@ such as x86, x86_64, arm, arm64, mips, ppc, sparc, sysz and xcore.  It provides
 bindings for Python, Java, OCaml and more.")
     (license license:bsd-3)))
 
+(define-public capstone
+  (package
+   (name "capstone")
+   (version "4.0.2")
+   (source
+    (origin
+     (method url-fetch)
+     (uri (string-append "https://github.com/aquynh/capstone"
+                         "/archive/" version ".tar.gz"))
+     (sha256
+      (base32
+       "0sjjbqps48az4map0kmai7j7dak3gy0xcq0sgx8fg09g0acdg0bw"))))
+   (build-system cmake-build-system)
+   (arguments
+    `(#:build-type "Release"
+      #:tests? #t))
+   (home-page "https://www.capstone-engine.org")
+   (synopsis "Lightweight multi-platform, multi-architecture disassembly framework")
+   (description
+    "Capstone is a lightweight multi-platform, multi-architecture disassembly
+framework. Capstone can disassemble machine code for many supported
+architectures such as x86, x86_64, arm, arm64, mips, ppc, sparc, sysz and
+xcore. It provides bindings for Python, Java, OCaml and more.")
+   (license license:bsd-3)))
+
 ;; FIXME: This package has a timestamp embedded in
 ;; lib/python3.5/site-packages/capstone/__pycache__/__iti__.cpython-35.pyc
 (define-public python-capstone
-- 
2.30.1

Message #8 received at 46697 <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Gerd Heber <gerd.heber <at> gmail.com>
Cc: 46697 <at> debbugs.gnu.org, Gerd Heber <gheber <at> hdfgroup.org>
Subject: Re: [bug#46697] [PATCH] Added capstone 4.
Date: Tue, 23 Feb 2021 14:09:15 +0100

Hello,

Gerd Heber <gerd.heber <at> gmail.com> writes:

>  gnu/packages/engineering.scm | 25 +++++++++++++++++++++++++
>  1 file changed, 25 insertions(+)

Thank you for your patch! Some comments follow.

First, there is already a capstone package in Guix, at version 3.5. Is
there a particular reason for not updating it instead of creating a new
variable?

> +     (uri (string-append "https://github.com/aquynh/capstone"
> +                         "/archive/" version ".tar.gz"))

This URI is unstable. We prefer using tagged commits instead. See for
example already defined capstone package.

> +      #:tests? #t))

This is the default, so it can be omitted.

> +   (home-page "https://www.capstone-engine.org")
> +   (synopsis "Lightweight multi-platform, multi-architecture disassembly framework")

Nitpick: I would remove multi-platform, since it makes little sense from
Guix POV.

> +   (description
> +    "Capstone is a lightweight multi-platform, multi-architecture disassembly

Ditto.

> +framework. Capstone can disassemble machine code for many supported

You need to add two spaces after full stops.

> +architectures such as x86, x86_64, arm, arm64, mips, ppc, sparc, sysz and
> +xcore. It provides bindings for Python, Java, OCaml and more.")

Also, could you provide a proper commit message, for example

    gnu: capstone: Update to 4.0.2.

    * gnu/packages/engineering.scm (capstone): Update to 4.0.2.

Could you send an updated patch?

Regards,
-- 
Nicolas Goaziou

Message #13 received at 46697-done <at> debbugs.gnu.org (full text, mbox):

From: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
To: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>, Gerd Heber <gerd.heber <at> gmail.com>
Cc: Gerd Heber <gheber <at> hdfgroup.org>, 46697-done <at> debbugs.gnu.org
Subject: Re: [bug#46697] [PATCH] Added capstone 4.
Date: Sat, 18 Mar 2023 10:32:15 +0100

Am Dienstag, dem 23.02.2021 um 14:09 +0100 schrieb Nicolas Goaziou:
> Also, could you provide a proper commit message, for example
> 
>     gnu: capstone: Update to 4.0.2.
> 
>     * gnu/packages/engineering.scm (capstone): Update to 4.0.2.
> 
> Could you send an updated patch?
Given that capstone 4.0.2 currently exists in Guix, I suppose that is
no longer necessary.

Cheers

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.