Received: (at 46697-done) by debbugs.gnu.org; 18 Mar 2023 09:32:26 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sat Mar 18 05:32:26 2023 Received: from localhost ([127.0.0.1]:46206 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1pdSvK-0006Ve-05 for submit <at> debbugs.gnu.org; Sat, 18 Mar 2023 05:32:26 -0400 Received: from mail-ed1-f65.google.com ([209.85.208.65]:40867) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <liliana.prikler@HIDDEN>) id 1pdSvI-0006VP-1C for 46697-done <at> debbugs.gnu.org; Sat, 18 Mar 2023 05:32:24 -0400 Received: by mail-ed1-f65.google.com with SMTP id fd5so29024820edb.7 for <46697-done <at> debbugs.gnu.org>; Sat, 18 Mar 2023 02:32:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679131937; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=gkju59Lczj+r5fN9T+D1pgae6oSdA1sd/IlUgXRiySc=; b=AKyJjPD0QFrKWHwDGCEbwXfpzp+Vernlmn2pZrvMQCMwQ0FtaKjriLVktSm3saZbQv momWfjbiI+aDBZOTB/SzNvl+G8LHzMfLB3YnIfumf60Xpz6bGlu1QAsDleMf5o0t65b5 26EvjSlgMe7SLKsadTsPMVOGamJkpkEa6yTmyGCCcTjctmdInDZy1XCM44eaH7G2B1Q/ tvzspev2yOzLvX9pzbVu/J53laRzvH2Zy0usam7xM990TMXmnmRHHGazg6QXB+49smGh SkRVo909pfuea+ygQJeB5n8mq7MgmFLgxwrj/Ugco/sXqtS2lsIIyBOPgbTQYF5OAeHp jwcg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679131937; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=gkju59Lczj+r5fN9T+D1pgae6oSdA1sd/IlUgXRiySc=; b=182Dkpi7c8ptjSlYrS1n9SIX+U0qsgbm8X2kdn3aAzlg9U/BV9pcTX4vMpLPzPJG1s fsbEGZ+GKPZ+sfTgJlfIwhuTAQv8cF7fFhn8Wb5IhhXcdbDsyQhmeTpFz1zvIhT7NDHH UDUbYz68b5/nmQ9o9ROe8dcIK1YXHUePmAs5gPc76FT/8HQJ3lDg0qTLWtCPAmTWiqgI tPUvKmtMI6XxGb7h7qYzjEl+dYrf0CqK3VRKdSq1720b/NQsE19WtHJ5DVwtosUlIqP0 zBrLbtIJnVLZoWDyZAE773lPfGLleeaWN3AiX/ZxsRKDWRcjj/4AhBgNr+TL1eFThzSD oe9g== X-Gm-Message-State: AO0yUKVXeyNkWiNWdX/NUU3iYzDhwx2kciGX9t8K4xsgo4DDy9ECR/wp 9yTlzRxPlFywS9E1c9C/bmw= X-Google-Smtp-Source: AK7set9OpfiP3VLwIV9VMAv5hLqXfFWzL52k0w4po0dP040g2+yqARDmxnjyEvgKw3DAxFDJOaEGDw== X-Received: by 2002:aa7:c517:0:b0:500:2c4f:3f5 with SMTP id o23-20020aa7c517000000b005002c4f03f5mr5340925edq.12.1679131936880; Sat, 18 Mar 2023 02:32:16 -0700 (PDT) Received: from lumine.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id 8-20020a170906300800b008e2dfc6382asm1960924ejz.125.2023.03.18.02.32.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 18 Mar 2023 02:32:16 -0700 (PDT) Message-ID: <09ffb5a9166bc3ea2c65b4db50aa664b0c0f5fe1.camel@HIDDEN> Subject: Re: [bug#46697] [PATCH] Added capstone 4. From: Liliana Marie Prikler <liliana.prikler@HIDDEN> To: Nicolas Goaziou <mail@HIDDEN>, Gerd Heber <gerd.heber@HIDDEN> Date: Sat, 18 Mar 2023 10:32:15 +0100 In-Reply-To: <87y2ffx75w.fsf@HIDDEN> References: <20210221223521.6116-1-gheber@HIDDEN> <87y2ffx75w.fsf@HIDDEN> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.0 MIME-Version: 1.0 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 46697-done Cc: Gerd Heber <gheber@HIDDEN>, 46697-done <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Am Dienstag, dem 23.02.2021 um 14:09 +0100 schrieb Nicolas Goaziou: > Also, could you provide a proper commit message, for example >=20 > =C2=A0=C2=A0=C2=A0 gnu: capstone: Update to 4.0.2. >=20 > =C2=A0=C2=A0=C2=A0 * gnu/packages/engineering.scm (capstone): Update to 4= .0.2. >=20 > Could you send an updated patch? Given that capstone 4.0.2 currently exists in Guix, I suppose that is no longer necessary. Cheers
Gerd Heber <gerd.heber@HIDDEN>:Liliana Marie Prikler <liliana.prikler@HIDDEN>:
Received: (at 46697) by debbugs.gnu.org; 23 Feb 2021 13:09:25 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Feb 23 08:09:25 2021
Received: from localhost ([127.0.0.1]:58533 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1lEXRN-000339-AP
for submit <at> debbugs.gnu.org; Tue, 23 Feb 2021 08:09:25 -0500
Received: from relay5-d.mail.gandi.net ([217.70.183.197]:46591)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <mail@HIDDEN>) id 1lEXRL-00032t-GQ
for 46697 <at> debbugs.gnu.org; Tue, 23 Feb 2021 08:09:24 -0500
X-Originating-IP: 185.131.40.67
Received: from localhost (40-67.ipv4.commingeshautdebit.fr [185.131.40.67])
(Authenticated sender: admin@HIDDEN)
by relay5-d.mail.gandi.net (Postfix) with ESMTPSA id 6532D1C000C;
Tue, 23 Feb 2021 13:09:16 +0000 (UTC)
From: Nicolas Goaziou <mail@HIDDEN>
To: Gerd Heber <gerd.heber@HIDDEN>
Subject: Re: [bug#46697] [PATCH] Added capstone 4.
References: <20210221223521.6116-1-gheber@HIDDEN>
Date: Tue, 23 Feb 2021 14:09:15 +0100
In-Reply-To: <20210221223521.6116-1-gheber@HIDDEN> (Gerd Heber's message
of "Sun, 21 Feb 2021 16:35:21 -0600")
Message-ID: <87y2ffx75w.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 46697
Cc: 46697 <at> debbugs.gnu.org, Gerd Heber <gheber@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)
Hello,
Gerd Heber <gerd.heber@HIDDEN> writes:
> gnu/packages/engineering.scm | 25 +++++++++++++++++++++++++
> 1 file changed, 25 insertions(+)
Thank you for your patch! Some comments follow.
First, there is already a capstone package in Guix, at version 3.5. Is
there a particular reason for not updating it instead of creating a new
variable?
> + (uri (string-append "https://github.com/aquynh/capstone"
> + "/archive/" version ".tar.gz"))
This URI is unstable. We prefer using tagged commits instead. See for
example already defined capstone package.
> + #:tests? #t))
This is the default, so it can be omitted.
> + (home-page "https://www.capstone-engine.org")
> + (synopsis "Lightweight multi-platform, multi-architecture disassembly framework")
Nitpick: I would remove multi-platform, since it makes little sense from
Guix POV.
> + (description
> + "Capstone is a lightweight multi-platform, multi-architecture disassembly
Ditto.
> +framework. Capstone can disassemble machine code for many supported
You need to add two spaces after full stops.
> +architectures such as x86, x86_64, arm, arm64, mips, ppc, sparc, sysz and
> +xcore. It provides bindings for Python, Java, OCaml and more.")
Also, could you provide a proper commit message, for example
gnu: capstone: Update to 4.0.2.
* gnu/packages/engineering.scm (capstone): Update to 4.0.2.
Could you send an updated patch?
Regards,
--
Nicolas Goaziou
guix-patches@HIDDEN:bug#46697; Package guix-patches.
Full text available.
Received: (at submit) by debbugs.gnu.org; 22 Feb 2021 02:39:52 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Feb 21 21:39:52 2021
Received: from localhost ([127.0.0.1]:55313 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1lE18Y-0001sM-I1
for submit <at> debbugs.gnu.org; Sun, 21 Feb 2021 21:39:52 -0500
Received: from lists.gnu.org ([209.51.188.17]:45446)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <gerd.heber@HIDDEN>) id 1lDxKD-0004aR-Oy
for submit <at> debbugs.gnu.org; Sun, 21 Feb 2021 17:35:38 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10]:34046)
by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <gerd.heber@HIDDEN>)
id 1lDxKC-000430-PG
for guix-patches@HIDDEN; Sun, 21 Feb 2021 17:35:37 -0500
Received: from mail-io1-xd2e.google.com ([2607:f8b0:4864:20::d2e]:37216)
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
(Exim 4.90_1) (envelope-from <gerd.heber@HIDDEN>)
id 1lDxK7-00088h-9e
for guix-patches@HIDDEN; Sun, 21 Feb 2021 17:35:36 -0500
Received: by mail-io1-xd2e.google.com with SMTP id d15so3114695ioe.4
for <guix-patches@HIDDEN>; Sun, 21 Feb 2021 14:35:30 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
h=from:to:cc:subject:date:message-id:mime-version
:content-transfer-encoding;
bh=1OxAuEasmHZhUux1msHY3uENcGWS4ld/w1aHm/iLaqw=;
b=PkARI2uVJZjfLzR6bxIvv6icFf+Hlr8EMa0qzC9tNBderdUp1sI+nioRtT/eHyhNDm
bCwZY1535oX7woGtx83YK1ykcdIzb+uq88rMypHjOYF/paj+MbL7vDit+kNuxu9eDMDV
XGKcRumcPVt3ICqcyWVvLlmaHWDkru+n57BYGXw2UW/ipRPZjo/k/6jQR1HeT8UKzHa5
2VKyommy332rMn3snmf813dCeB+6Tx1Pk2hfvdBaecGwyWdeBLFHll0nbG9gP23FtrJ7
eqDVMN47CxMGHY3JnUc0/i7fdttaZTAS5NmRDZzcYBK7TY/nRy5HhIibQeLBzf6z1M2j
PO8Q==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20161025;
h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version
:content-transfer-encoding;
bh=1OxAuEasmHZhUux1msHY3uENcGWS4ld/w1aHm/iLaqw=;
b=qTXGZi0+KEcC1Gy5URhf/3OMc8QrIWfIK747hEoFdtBfuXALA8sFuJh1buWNhOd/qo
9TnHOAa3Lm/gCtHPIsJxSegfS/8Av6e2EmCezQSDW8m440CME7zuENU1R0VeT/Qdj99J
/FW+bwu+bH8UNj4oQeda4tL3+rVL5BXJFHM88fm2VuIyOkBk/c4h1WbElydzJ3LXvLnE
KOHHH5udbXp9gbWOhjxvAa/SnwZJdFc0QEaoxKUtvz9qX2LJs2r7KqCjnQM3irlpgXP9
PTp2Uoaa4n0cCuKONOGoSUZiaE183W6SrTEUKRa5ndD0tuQqaalVCPQD1DXRRYEcEfu/
+6Ug==
X-Gm-Message-State: AOAM530SXsDV3aKaajPMscjZlqtcLd/nmT7QwhqPoN3lVQQLCWFMSlei
gs7Y7puDUNUYU3oj7na5QinxEZQ1PJYuwQ==
X-Google-Smtp-Source: ABdhPJxq2FvOw7m71z4eLy1WrPrESuu+U+iGen7pX0Ld7y4eM7nETc5n9dDz0kirwzvKLJECSOm8ow==
X-Received: by 2002:a02:390a:: with SMTP id l10mr19235106jaa.88.1613946929446;
Sun, 21 Feb 2021 14:35:29 -0800 (PST)
Received: from guix.attlocal.net ([2600:1702:30b0:1f50:c567:9d5f:23a4:7f67])
by smtp.gmail.com with ESMTPSA id i8sm10114010ilv.57.2021.02.21.14.35.28
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Sun, 21 Feb 2021 14:35:28 -0800 (PST)
From: Gerd Heber <gerd.heber@HIDDEN>
X-Google-Original-From: Gerd Heber <gheber@HIDDEN>
To: guix-patches@HIDDEN
Subject: [PATCH] Added capstone 4.
Date: Sun, 21 Feb 2021 16:35:21 -0600
Message-Id: <20210221223521.6116-1-gheber@HIDDEN>
X-Mailer: git-send-email 2.30.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Received-SPF: pass client-ip=2607:f8b0:4864:20::d2e;
envelope-from=gerd.heber@HIDDEN; helo=mail-io1-xd2e.google.com
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,
RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,
SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -1.3 (-)
X-Debbugs-Envelope-To: submit
X-Mailman-Approved-At: Sun, 21 Feb 2021 21:39:49 -0500
Cc: Gerd Heber <gheber@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.3 (--)
---
gnu/packages/engineering.scm | 25 +++++++++++++++++++++++++
1 file changed, 25 insertions(+)
diff --git a/gnu/packages/engineering.scm b/gnu/packages/engineering.scm
index 034dabc3f9..4987377840 100644
--- a/gnu/packages/engineering.scm
+++ b/gnu/packages/engineering.scm
@@ -1495,6 +1495,31 @@ such as x86, x86_64, arm, arm64, mips, ppc, sparc, sysz and xcore. It provides
bindings for Python, Java, OCaml and more.")
(license license:bsd-3)))
+(define-public capstone
+ (package
+ (name "capstone")
+ (version "4.0.2")
+ (source
+ (origin
+ (method url-fetch)
+ (uri (string-append "https://github.com/aquynh/capstone"
+ "/archive/" version ".tar.gz"))
+ (sha256
+ (base32
+ "0sjjbqps48az4map0kmai7j7dak3gy0xcq0sgx8fg09g0acdg0bw"))))
+ (build-system cmake-build-system)
+ (arguments
+ `(#:build-type "Release"
+ #:tests? #t))
+ (home-page "https://www.capstone-engine.org")
+ (synopsis "Lightweight multi-platform, multi-architecture disassembly framework")
+ (description
+ "Capstone is a lightweight multi-platform, multi-architecture disassembly
+framework. Capstone can disassemble machine code for many supported
+architectures such as x86, x86_64, arm, arm64, mips, ppc, sparc, sysz and
+xcore. It provides bindings for Python, Java, OCaml and more.")
+ (license license:bsd-3)))
+
;; FIXME: This package has a timestamp embedded in
;; lib/python3.5/site-packages/capstone/__pycache__/__iti__.cpython-35.pyc
(define-public python-capstone
--
2.30.1
Gerd Heber <gerd.heber@HIDDEN>:guix-patches@HIDDEN.
Full text available.guix-patches@HIDDEN:bug#46697; Package guix-patches.
Full text available.
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.