GNU bug report logs - #46699
[PATCH] gnu: mumble: Update to 1.3.4.

Previous Next

Package: guix-patches;

Reported by: "jgart" <jgart <at> dismail.de>

Date: Mon, 22 Feb 2021 02:40:03 UTC

Severity: normal

Tags: patch

Done: Leo Prikler <leo.prikler <at> student.tugraz.at>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 46699 in the body.
You can then email your comments to 46699 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#46699; Package guix-patches. (Mon, 22 Feb 2021 02:40:03 GMT) Full text and rfc822 format available.

Acknowledgement sent to "jgart" <jgart <at> dismail.de>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Mon, 22 Feb 2021 02:40:03 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: "jgart" <jgart <at> dismail.de>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: mumble: Update to 1.3.4.
Date: Mon, 22 Feb 2021 00:59:56 +0000
[Message part 1 (text/plain, inline)]
Hi Guix,

Raghav Gururajan and I updated mumble to 1.3.4. The patch is attached. 

Thank you,

jgart

libremiami.org
search.libremiami.org
[0001-gnu-mumble-Update-to-1.3.4.patch (application/octet-stream, attachment)]

Information forwarded to guix-patches <at> gnu.org:
bug#46699; Package guix-patches. (Mon, 22 Feb 2021 16:19:02 GMT) Full text and rfc822 format available.

Message #8 received at 46699 <at> debbugs.gnu.org (full text, mbox):

From: Leo Prikler <leo.prikler <at> student.tugraz.at>
To: jgart <jgart <at> dismail.de>, 46699 <at> debbugs.gnu.org
Cc: rg <at> raghavgururajan.name, LibreMiami <packaging-guix <at> libremiami.org>
Subject: Re: [PATCH] gnu: mumble: Update to 1.3.4.
Date: Mon, 22 Feb 2021 17:18:29 +0100
Hi jgart and all the others listening from LibreMiami,

Am Montag, den 22.02.2021, 00:59 +0000 schrieb jgart:
> Co-author: jgart <jgart <at> dismail.de>
> Co-author: Raghav Gururajan <rg <at> raghavgururajan.name>
IIRC, the correct tag would be Co-authored-by.

> * gnu/packages/telephony.scm (mumble): Update to 1.3.4.
This is not enough of a ChangeLog for the changes made here.

> -     `(#:tests? #f  ; no "check" target
> +     `(#:tests? #f                      ; no "check" target

> -                                           "no-oss" ; use pulse
> -                                           "no-alsa" ; use pulse
> +                                           "no-oss"       ; use
> pulse
> +                                           "no-alsa"      ; use
> pulse

> -              (with-output-to-file "scripts/mumble-overlay"
> -                (lambda ()
> -                  (format #t "#!~a~%" (which "bash"))
> -                  (format #t "export LD_PRELOAD=\"~a
> $LD_PRELOAD\"~%"
> -                          (string-append (assoc-ref outputs "out")
> -                                         "/lib/mumble/libmumble.so.1
> "))
> -                  (format #t "exec \"${@}\"")))
> -              #t))
> +             (with-output-to-file "scripts/mumble-overlay"
> +               (lambda ()
> +                 (format #t "#!~a~%" (which "bash"))
> +                 (format #t "export LD_PRELOAD=\"~a $LD_PRELOAD\"~%"
> +                         (string-append (assoc-ref outputs "out")
> +                                        "/lib/mumble/libmumble.so.1"
> ))
> +                 (format #t "exec \"${@}\"")))
> +             #t))

> -         (replace 'install ; install phase does not exist
> +         (replace 'install              ; install phase does not
> exist

> -       ("mesa" ,mesa) ; avoid bundled
> +       ("mesa" ,mesa)                   ; avoid bundled
>         ("openssl" ,openssl)
> -       ("opus" ,opus) ; avoid bundled
> +       ("opus" ,opus)                   ; avoid bundled

> -       ("speex" ,speex) ; avoid bundled
> -       ("speexdsp" ,speexdsp))) ; avoid bundled
> +       ("speex" ,speex)                 ; avoid bundled
> +       ("speexdsp" ,speexdsp)))         ; avoid bundled
These lines appear to be noise, some of them definitely are. 

> -     `(("pkg-config" ,pkg-config)
> -       ("python" ,python)
> -       ("qttools" ,qttools)))
> +     `(("perl" ,perl)
> +       ("pkg-config" ,pkg-config)
> +       ("python" ,python-wrapper)
> +       ("qttools" ,qttools)
> +       ("ruby" ,ruby)))
Are perl and ruby really required?  If so, what for?

Regards,
Leo





Information forwarded to guix-patches <at> gnu.org:
bug#46699; Package guix-patches. (Mon, 22 Feb 2021 19:29:01 GMT) Full text and rfc822 format available.

Message #11 received at 46699 <at> debbugs.gnu.org (full text, mbox):

From: Leo Prikler <leo.prikler <at> student.tugraz.at>
To: jgart <jgart <at> dismail.de>, 46699 <at> debbugs.gnu.org
Cc: rg <at> raghavgururajan.name, LibreMiami <packaging-guix <at> libremiami.org>
Subject: Re: [PATCH] gnu: mumble: Update to 1.3.4.
Date: Mon, 22 Feb 2021 20:28:37 +0100
Hi jgart,

Am Montag, den 22.02.2021, 19:09 +0000 schrieb jgart:
> Hi Leo,
> 
> > IIRC, the correct tag would be Co-authored-by.
> 
> I attached the updated patch with your suggestions.
> 
> > These lines appear to be noise, some of them definitely are.
> 
> Raghav thinks these might have been introduced by indent.el
> 
> How would you suggest to remove them?
You can select the lines you actually wish to commit through `git
commit -p` or use any other tool to do the trick (e.g. Magit or gitg). 
indent.el is a bit of a hammer.  If you don't actively edit code, that
has wrong indentation, it's wiser to just indent your portions with
Emacs.

> > Are perl and ruby really required? If so, what for?
> 
> They are for the 'patch-shebangs phase.
And why do you care about those shebangs?  Are any of those programs
patched by that phase run at any point during build?

Regards,
Leo





Information forwarded to guix-patches <at> gnu.org:
bug#46699; Package guix-patches. (Mon, 22 Feb 2021 20:09:02 GMT) Full text and rfc822 format available.

Message #14 received at 46699 <at> debbugs.gnu.org (full text, mbox):

From: "jgart" <jgart <at> dismail.de>
To: "Leo Prikler" <leo.prikler <at> student.tugraz.at>, 46699 <at> debbugs.gnu.org
Cc: rg <at> raghavgururajan.name, packaging-guix <at> libremiami.org
Subject: Re: [PATCH] gnu: mumble: Update to 1.3.4.
Date: Mon, 22 Feb 2021 19:09:09 +0000
[Message part 1 (text/plain, inline)]
Hi Leo,

> IIRC, the correct tag would be Co-authored-by.

I attached the updated patch with your suggestions.

> These lines appear to be noise, some of them definitely are.

Raghav thinks these might have been introduced by indent.el

How would you suggest to remove them?

> Are perl and ruby really required? If so, what for?

They are for the 'patch-shebangs phase.

Thank you for taking the time to review these patches,

jgart

libremiami.org
search.libremiami.org




February 22, 2021 11:18 AM, "Leo Prikler" <leo.prikler <at> student.tugraz.at> wrote:

> Hi jgart and all the others listening from LibreMiami,
> 
> Am Montag, den 22.02.2021, 00:59 +0000 schrieb jgart:
> 
>> Co-author: jgart <jgart <at> dismail.de>
>> Co-author: Raghav Gururajan <rg <at> raghavgururajan.name>
> 
> 
>> * gnu/packages/telephony.scm (mumble): Update to 1.3.4.
> 
> This is not enough of a ChangeLog for the changes made here.
> 
>> - `(#:tests? #f ; no "check" target
>> + `(#:tests? #f ; no "check" target
>> 
>> - "no-oss" ; use pulse
>> - "no-alsa" ; use pulse
>> + "no-oss" ; use
>> pulse
>> + "no-alsa" ; use
>> pulse
>> 
>> - (with-output-to-file "scripts/mumble-overlay"
>> - (lambda ()
>> - (format #t "#!~a~%" (which "bash"))
>> - (format #t "export LD_PRELOAD=\"~a
>> $LD_PRELOAD\"~%"
>> - (string-append (assoc-ref outputs "out")
>> - "/lib/mumble/libmumble.so.1
>> "))
>> - (format #t "exec \"${@}\"")))
>> - #t))
>> + (with-output-to-file "scripts/mumble-overlay"
>> + (lambda ()
>> + (format #t "#!~a~%" (which "bash"))
>> + (format #t "export LD_PRELOAD=\"~a $LD_PRELOAD\"~%"
>> + (string-append (assoc-ref outputs "out")
>> + "/lib/mumble/libmumble.so.1"
>> ))
>> + (format #t "exec \"${@}\"")))
>> + #t))
>> 
>> - (replace 'install ; install phase does not exist
>> + (replace 'install ; install phase does not
>> exist
>> 
>> - ("mesa" ,mesa) ; avoid bundled
>> + ("mesa" ,mesa) ; avoid bundled
>> ("openssl" ,openssl)
>> - ("opus" ,opus) ; avoid bundled
>> + ("opus" ,opus) ; avoid bundled
>> 
>> - ("speex" ,speex) ; avoid bundled
>> - ("speexdsp" ,speexdsp))) ; avoid bundled
>> + ("speex" ,speex) ; avoid bundled
>> + ("speexdsp" ,speexdsp))) ; avoid bundled
> 
> These lines appear to be noise, some of them definitely are.
> 
>> - `(("pkg-config" ,pkg-config)
>> - ("python" ,python)
>> - ("qttools" ,qttools)))
>> + `(("perl" ,perl)
>> + ("pkg-config" ,pkg-config)
>> + ("python" ,python-wrapper)
>> + ("qttools" ,qttools)
>> + ("ruby" ,ruby)))
> 
> 
> Regards,
> Leo
[0001-gnu-mumble-Update-to-1.3.4.patch (application/octet-stream, attachment)]

Information forwarded to guix-patches <at> gnu.org:
bug#46699; Package guix-patches. (Sat, 06 Mar 2021 16:23:01 GMT) Full text and rfc822 format available.

Message #17 received at 46699 <at> debbugs.gnu.org (full text, mbox):

From: "jgart" <jgart <at> dismail.de>
To: "Leo Prikler" <leo.prikler <at> student.tugraz.at>, 46699 <at> debbugs.gnu.org
Cc: rg <at> raghavgururajan.name, LibreMiami <packaging-guix <at> libremiami.org>
Subject: Re: [PATCH 1/2] gnu: mumble: Update to 1.3.4.
Date: Sat, 06 Mar 2021 16:22:14 +0000
[Message part 1 (text/plain, inline)]
Hi Leo,

These two patches change the logic in the snippet block from list of directories to delete to list of directories to keep as well as add indentation to the mumble package. This is an addition to commit ea13b3a14cb079e33b59cf60cdabf500ecc51cf1.

best regards,

jgart

February 22, 2021 2:09 PM, "jgart" <jgart <at> dismail.de> wrote:

> Hi Leo,
> 
>> IIRC, the correct tag would be Co-authored-by.
> 
> I attached the updated patch with your suggestions.
> 
>> These lines appear to be noise, some of them definitely are.
> 
> Raghav thinks these might have been introduced by indent.el
> 
> How would you suggest to remove them?
> 
>> Are perl and ruby really required? If so, what for?
> 
> They are for the 'patch-shebangs phase.
> 
> Thank you for taking the time to review these patches,
> 
> jgart
> 
> libremiami.org
> search.libremiami.org
> 
> February 22, 2021 11:18 AM, "Leo Prikler" <leo.prikler <at> student.tugraz.at> wrote:
> 
>> Hi jgart and all the others listening from LibreMiami,
>> 
>> Am Montag, den 22.02.2021, 00:59 +0000 schrieb jgart:
>> 
>>> Co-author: jgart <jgart <at> dismail.de>
>>> Co-author: Raghav Gururajan <rg <at> raghavgururajan.name>
>> 
>>> * gnu/packages/telephony.scm (mumble): Update to 1.3.4.
>> 
>> This is not enough of a ChangeLog for the changes made here.
>> 
>>> - `(#:tests? #f ; no "check" target
>>> + `(#:tests? #f ; no "check" target
>>> 
>>> - "no-oss" ; use pulse
>>> - "no-alsa" ; use pulse
>>> + "no-oss" ; use
>>> pulse
>>> + "no-alsa" ; use
>>> pulse
>>> 
>>> - (with-output-to-file "scripts/mumble-overlay"
>>> - (lambda ()
>>> - (format #t "#!~a~%" (which "bash"))
>>> - (format #t "export LD_PRELOAD=\"~a
>>> $LD_PRELOAD\"~%"
>>> - (string-append (assoc-ref outputs "out")
>>> - "/lib/mumble/libmumble.so.1
>>> "))
>>> - (format #t "exec \"${@}\"")))
>>> - #t))
>>> + (with-output-to-file "scripts/mumble-overlay"
>>> + (lambda ()
>>> + (format #t "#!~a~%" (which "bash"))
>>> + (format #t "export LD_PRELOAD=\"~a $LD_PRELOAD\"~%"
>>> + (string-append (assoc-ref outputs "out")
>>> + "/lib/mumble/libmumble.so.1"
>>> ))
>>> + (format #t "exec \"${@}\"")))
>>> + #t))
>>> 
>>> - (replace 'install ; install phase does not exist
>>> + (replace 'install ; install phase does not
>>> exist
>>> 
>>> - ("mesa" ,mesa) ; avoid bundled
>>> + ("mesa" ,mesa) ; avoid bundled
>>> ("openssl" ,openssl)
>>> - ("opus" ,opus) ; avoid bundled
>>> + ("opus" ,opus) ; avoid bundled
>>> 
>>> - ("speex" ,speex) ; avoid bundled
>>> - ("speexdsp" ,speexdsp))) ; avoid bundled
>>> + ("speex" ,speex) ; avoid bundled
>>> + ("speexdsp" ,speexdsp))) ; avoid bundled
>> 
>> These lines appear to be noise, some of them definitely are.
>> 
>>> - `(("pkg-config" ,pkg-config)
>>> - ("python" ,python)
>>> - ("qttools" ,qttools)))
>>> + `(("perl" ,perl)
>>> + ("pkg-config" ,pkg-config)
>>> + ("python" ,python-wrapper)
>>> + ("qttools" ,qttools)
>>> + ("ruby" ,ruby)))
>> 
>> Regards,
>> Leo
[0001-gnu-mumble-Indent-package-definition.patch (application/octet-stream, attachment)]
[0002-gnu-mumble-Modify-snippet.patch (application/octet-stream, attachment)]

Information forwarded to guix-patches <at> gnu.org:
bug#46699; Package guix-patches. (Sat, 06 Mar 2021 16:36:01 GMT) Full text and rfc822 format available.

Message #20 received at 46699 <at> debbugs.gnu.org (full text, mbox):

From: Leo Prikler <leo.prikler <at> student.tugraz.at>
To: jgart <jgart <at> dismail.de>, 46699 <at> debbugs.gnu.org
Cc: rg <at> raghavgururajan.name, LibreMiami <packaging-guix <at> libremiami.org>
Subject: Re: [PATCH 1/2] gnu: mumble: Update to 1.3.4.
Date: Sat, 06 Mar 2021 17:35:12 +0100
Am Samstag, den 06.03.2021, 16:22 +0000 schrieb jgart:
> Hi Leo,
> 
> These two patches change the logic in the snippet block from list of
> directories to delete to list of directories to keep as well as add
> indentation to the mumble package. This is an addition to commit
> ea13b3a14cb079e33b59cf60cdabf500ecc51cf1.
> 
> best regards,
> 
> jgart
Hi jgart,

0001 suffers from similar issues as your previous patch set.  In
particular, it adds a spurious level of indentation in arguments!
0002 LGTM, I'll push it after some testing.  On that note, could
someone investigate why we keep ancient versions of CELT around?  It
seems newer ones have been merged into opus.

Regards,
Leo





Information forwarded to guix-patches <at> gnu.org:
bug#46699; Package guix-patches. (Sat, 06 Mar 2021 17:39:02 GMT) Full text and rfc822 format available.

Message #23 received at 46699 <at> debbugs.gnu.org (full text, mbox):

From: Leo Prikler <leo.prikler <at> student.tugraz.at>
To: jgart <jgart <at> dismail.de>, 46699 <at> debbugs.gnu.org
Cc: rg <at> raghavgururajan.name, LibreMiami <packaging-guix <at> libremiami.org>
Subject: Re: [PATCH 1/2] gnu: mumble: Update to 1.3.4.
Date: Sat, 06 Mar 2021 18:38:28 +0100
Am Samstag, den 06.03.2021, 17:35 +0100 schrieb Leo Prikler:
> Am Samstag, den 06.03.2021, 16:22 +0000 schrieb jgart:
> > Hi Leo,
> > 
> > These two patches change the logic in the snippet block from list
> > of
> > directories to delete to list of directories to keep as well as add
> > indentation to the mumble package. This is an addition to commit
> > ea13b3a14cb079e33b59cf60cdabf500ecc51cf1.
> > 
> > best regards,
> > 
> > jgart
> Hi jgart,
> 
> 0001 suffers from similar issues as your previous patch set.  In
> particular, it adds a spurious level of indentation in arguments!
> 0002 LGTM, I'll push it after some testing.  On that note, could
> someone investigate why we keep ancient versions of CELT around?  It
> seems newer ones have been merged into opus.
> 
> Regards,
> Leo
I've now pushed 0002.  As far as keeping ancient CELT, it seems version
1.4.0 will at least drop 0.11, while keeping 0.7 for backwards
compatibility.

Do you want to keep this bug open for more indentation adjustments or
is it fine to close?

Regards,
Leo





Information forwarded to guix-patches <at> gnu.org:
bug#46699; Package guix-patches. (Sun, 07 Mar 2021 04:23:02 GMT) Full text and rfc822 format available.

Message #26 received at 46699 <at> debbugs.gnu.org (full text, mbox):

From: "jgart" <jgart <at> dismail.de>
To: "Leo Prikler" <leo.prikler <at> student.tugraz.at>, 46699 <at> debbugs.gnu.org
Cc: rg <at> raghavgururajan.name, LibreMiami <packaging-guix <at> libremiami.org>
Subject: Re: [PATCH 1/2] gnu: mumble: Update to 1.3.4.
Date: Sun, 07 Mar 2021 04:22:36 +0000
Hi Leo,

It is fine to close this bug.

Thank you for taking the time to review these changes and for merging the other patch. 

We'll keep CELT in mind going forward. Thank you for pointing that out.

all the best,

jgart

libremiami.org

March 6, 2021 12:38 PM, "Leo Prikler" <leo.prikler <at> student.tugraz.at> wrote:

> Am Samstag, den 06.03.2021, 17:35 +0100 schrieb Leo Prikler:
> 
>> Am Samstag, den 06.03.2021, 16:22 +0000 schrieb jgart:
>> Hi Leo,
>> 
>> These two patches change the logic in the snippet block from list
>> of
>> directories to delete to list of directories to keep as well as add
>> indentation to the mumble package. This is an addition to commit
>> ea13b3a14cb079e33b59cf60cdabf500ecc51cf1.
>> 
>> best regards,
>> 
>> jgart
>> Hi jgart,
>> 
>> 0001 suffers from similar issues as your previous patch set. In
>> particular, it adds a spurious level of indentation in arguments!
>> 0002 LGTM, I'll push it after some testing. On that note, could
>> someone investigate why we keep ancient versions of CELT around? It
>> seems newer ones have been merged into opus.
>> 
>> Regards,
>> Leo
> 
> I've now pushed 0002. As far as keeping ancient CELT, it seems version
> 1.4.0 will at least drop 0.11, while keeping 0.7 for backwards
> compatibility.
> 
> Do you want to keep this bug open for more indentation adjustments or
> is it fine to close?
> 
> Regards,
> Leo




Reply sent to Leo Prikler <leo.prikler <at> student.tugraz.at>:
You have taken responsibility. (Sun, 07 Mar 2021 08:10:02 GMT) Full text and rfc822 format available.

Notification sent to "jgart" <jgart <at> dismail.de>:
bug acknowledged by developer. (Sun, 07 Mar 2021 08:10:02 GMT) Full text and rfc822 format available.

Message #31 received at 46699-done <at> debbugs.gnu.org (full text, mbox):

From: Leo Prikler <leo.prikler <at> student.tugraz.at>
To: jgart <jgart <at> dismail.de>, 46699-done <at> debbugs.gnu.org
Cc: rg <at> raghavgururajan.name, LibreMiami <packaging-guix <at> libremiami.org>
Subject: Re: [PATCH 1/2] gnu: mumble: Update to 1.3.4.
Date: Sun, 07 Mar 2021 09:09:47 +0100
Hi jgart,

Am Sonntag, den 07.03.2021, 04:22 +0000 schrieb jgart:
> Hi Leo,
> 
> It is fine to close this bug.
Very well, doing so.

> Thank you for taking the time to review these changes and for merging
> the other patch. 
> 
> We'll keep CELT in mind going forward. Thank you for pointing that
> out.
Thank you for submitting the patches.

Regards,
Leo





bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Sun, 04 Apr 2021 11:24:08 GMT) Full text and rfc822 format available.

This bug report was last modified 2 years and 360 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.