GNU bug report logs - #46703
[PATCH] gnu: add bmake

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 46703 in the body.
You can then email your comments to 46703 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: qblade <qblade <at> protonmail.com>
To: "guix-patches <at> gnu.org" <guix-patches <at> gnu.org>
Subject: [PATCH] gnu: add bmake
Date: Mon, 22 Feb 2021 06:33:57 +0000

[Message part 1 (text/plain, inline)]

Empty Message

[0001-gnu-add-bmake.patch (text/x-patch, attachment)]

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: qblade via Guix-patches via <guix-patches <at> gnu.org>
Cc: qblade <qblade <at> protonmail.com>, 46703 <at> debbugs.gnu.org
Subject: Re: [bug#46703] [PATCH] gnu: add bmake
Date: Sat, 27 Feb 2021 15:15:25 +0100

Hello,

qblade via Guix-patches via <guix-patches <at> gnu.org> writes:

> * gnu/packages/build-tools.scm (bmake): New variable.

Thank you. Some comments follow.

> +    (name "bmake")
> +    (version "20200902")

There is a newer version available. Could you provide it instead?

I tried to quickly update it (hash
"07n9avzdg6gifrzyddnyzada5s5rzklvbqfpv5drljpxcgpqpvwg") but there are
additional failing tests.

> +    (arguments
> +     `(#:tests? #f ;; test in build

You need a single semicolon for end-of-line comments. Also (nitpick),
I find ";test during build" clearer.

> +       #:phases
> +       (modify-phases %standard-phases
> +         (add-after 'configure 'fix-test ;; fix from nixpkgs

See above for comment syntax.

> +    (description "Program designed to simplify the maintenance of
> +other programs.")

I suggest:

    "bmake is a program designed to simplify the maintenance of other
    programs.  Its input is a list of specifications as to the files upon which
    programs and other files depend."

Could you send an updated patch?

Regards,
-- 
Nicolas Goaziou

Message #14 received at submit <at> debbugs.gnu.org (full text, mbox):

From: qblade <qblade <at> protonmail.com>
To: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Cc: "46703 <at> debbugs.gnu.org" <46703 <at> debbugs.gnu.org>,
 qblade via Guix-patches via <guix-patches <at> gnu.org>
Subject: 回复： Re: [bug#46703] [PATCH] gnu: add bmake
Date: Sun, 28 Feb 2021 04:27:43 +0000

[Message part 1 (text/plain, inline)]

OK

[0001-gnu-Add-bmake.patch (text/x-patch, attachment)]

Message #20 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: qblade <qblade <at> protonmail.com>
Cc: qblade via Guix-patches via <guix-patches <at> gnu.org>,
 "46703 <at> debbugs.gnu.org" <46703-done <at> debbugs.gnu.org>
Subject: Re: 回复： Re: [bug#46703] [PATCH] gnu: add bmake
Date: Tue, 02 Mar 2021 11:58:05 +0100

Hello,

qblade <qblade <at> protonmail.com> writes:

> Subject: [PATCH] gnu: Add bmake

Applied. Thank you.

> +         (add-after 'configure 'remove-fail-tests ;; need fix
> +           (lambda _
> +             (substitute* "unit-tests/Makefile"
> +               (("cmd-interrupt")
> +                ""))
> +             (substitute* "unit-tests/Makefile"
> +               (("varmod-localtime")
> +                "")))))

I merged the two substitutions within the same substitute* call.

Regards,
-- 
Nicolas Goaziou

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.