GNU bug report logs - #46715
[PATCH] guix import: Fixing detection of Fortran files.

Previous Next

Package: guix-patches;

Reported by: Mădălin Ionel Patrașcu <madalinionel.patrascu <at> mdc-berlin.de>

Date: Tue, 23 Feb 2021 11:02:02 UTC

Severity: normal

Tags: patch

Done: Ricardo Wurmus <rekado <at> elephly.net>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 46715 in the body.
You can then email your comments to 46715 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#46715; Package guix-patches. (Tue, 23 Feb 2021 11:02:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Mădălin Ionel Patrașcu <madalinionel.patrascu <at> mdc-berlin.de>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Tue, 23 Feb 2021 11:02:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Mădălin Ionel Patrașcu
 <madalinionel.patrascu <at> mdc-berlin.de>
To: <guix-patches <at> gnu.org>
Cc: rekado <at> elephly.net, Mădălin Ionel Patrașcu
 <madalinionel.patrascu <at> mdc-berlin.de>
Subject: [PATCH] guix import: Fixing detection of Fortran files.
Date: Tue, 23 Feb 2021 12:00:21 +0100
This fixes a bug whereby Guix importer considers files like .f.*
being Fortran's files.

(find-files dir "\\.f(90|95)?")

would consider a lot of files with an extension starting with f
being a Fortran file. The right way is to consider only files
ending with .f90 or .f95.

*guix/import/cran.scm: changing pattern of the detection for
Fortran's files to .f(90|95)$.

Co-authored-by: Ricardo Wurmus <rekado <at> elephly.net>
---
 guix/import/cran.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/guix/import/cran.scm b/guix/import/cran.scm
index e8caf080fd..dbc858cb84 100644
--- a/guix/import/cran.scm
+++ b/guix/import/cran.scm
@@ -361,7 +361,7 @@ empty list when the FIELD cannot be found."
 
 (define (directory-needs-fortran? dir)
   "Check if the directory DIR contains Fortran source files."
-  (match (find-files dir "\\.f(90|95)?")
+  (match (find-files dir "\\.f(90|95)$")
     (() #f)
     (_ #t)))
 
-- 
2.30.1





Reply sent to Ricardo Wurmus <rekado <at> elephly.net>:
You have taken responsibility. (Mon, 01 Mar 2021 21:48:01 GMT) Full text and rfc822 format available.

Notification sent to Mădălin Ionel Patrașcu <madalinionel.patrascu <at> mdc-berlin.de>:
bug acknowledged by developer. (Mon, 01 Mar 2021 21:48:02 GMT) Full text and rfc822 format available.

Message #10 received at 46715-done <at> debbugs.gnu.org (full text, mbox):

From: Ricardo Wurmus <rekado <at> elephly.net>
To: Mădălin Ionel Patrașcu
 <madalinionel.patrascu <at> mdc-berlin.de>
Cc: 46715-done <at> debbugs.gnu.org
Subject: Re: [PATCH] guix import: Fixing detection of Fortran files.
Date: Mon, 01 Mar 2021 22:47:46 +0100
Hi Mădălin,

Thanks!  I applied this with a few changes in the commit message.
(Commit 35814292b6.)

-- 
Ricardo




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Tue, 30 Mar 2021 11:24:06 GMT) Full text and rfc822 format available.

This bug report was last modified 4 years and 102 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.