GNU bug report logs - #46741
[PATCH] gnu: Return appropriate defconfig for ppc64 (non-LE)

Previous Next

Package: guix-patches;

Reported by: Carl Dong <contact <at> carldong.me>

Date: Wed, 24 Feb 2021 03:04:02 UTC

Severity: normal

Tags: patch

Done: Carl Dong <contact <at> carldong.me>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 46741 in the body.
You can then email your comments to 46741 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to guix-patches <at> gnu.org:
bug#46741; Package guix-patches. (Wed, 24 Feb 2021 03:04:02 GMT) Full text and rfc822 format available.
Acknowledgement sent to Carl Dong <contact <at> carldong.me>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Wed, 24 Feb 2021 03:04:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Carl Dong <contact <at> carldong.me>
To: guix-patches <at> gnu.org
Cc: Carl Dong <contact <at> carldong.me>
Subject: [PATCH] gnu: Return appropriate defconfig for ppc64 (non-LE)
Date: Tue, 23 Feb 2021 22:03:12 -0500

* gnu/packages/linux.scm (system->defconfig): Add "powerpc64-" prefix.
---
 gnu/packages/linux.scm | 1 +
 1 file changed, 1 insertion(+)

diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
index c87c5ffb09..30cbebf849 100644
--- a/gnu/packages/linux.scm
+++ b/gnu/packages/linux.scm
@@ -181,6 +181,7 @@
 defconfig.  Return the appropriate make target if applicable, otherwise return
 \"defconfig\"."
   (cond ((string-prefix? "powerpc-" system) "pmac32_defconfig")
+        ((string-prefix? "powerpc64-" system) "ppc64_defconfig")
         ((string-prefix? "powerpc64le-" system) "ppc64_defconfig")
         (else "defconfig")))
 
-- 
2.30.1
Information forwarded to guix-patches <at> gnu.org:
bug#46741; Package guix-patches. (Wed, 24 Feb 2021 08:19:02 GMT) Full text and rfc822 format available.

Message #8 received at 46741 <at> debbugs.gnu.org (full text, mbox):

From: Efraim Flashner <efraim <at> flashner.co.il>
To: Carl Dong <contact <at> carldong.me>
Cc: 46741 <at> debbugs.gnu.org
Subject: Re: [bug#46741] [PATCH] gnu: Return appropriate defconfig for ppc64
 (non-LE)
Date: Wed, 24 Feb 2021 10:17:26 +0200

[Message part 1 (text/plain, inline)]
On Tue, Feb 23, 2021 at 10:03:12PM -0500, Carl Dong wrote:
> * gnu/packages/linux.scm (system->defconfig): Add "powerpc64-" prefix.
> ---
>  gnu/packages/linux.scm | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
> index c87c5ffb09..30cbebf849 100644
> --- a/gnu/packages/linux.scm
> +++ b/gnu/packages/linux.scm
> @@ -181,6 +181,7 @@
>  defconfig.  Return the appropriate make target if applicable, otherwise return
>  \"defconfig\"."
>    (cond ((string-prefix? "powerpc-" system) "pmac32_defconfig")
> +        ((string-prefix? "powerpc64-" system) "ppc64_defconfig")
>          ((string-prefix? "powerpc64le-" system) "ppc64_defconfig")

would it make more sense to change it to "powerpc64" or "powerpc(64)?-"?

>          (else "defconfig")))
>  
> -- 
> 2.30.1
> 
> 
> 
> 

-- 
Efraim Flashner   <efraim <at> flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[signature.asc (application/pgp-signature, inline)]
Information forwarded to guix-patches <at> gnu.org:
bug#46741; Package guix-patches. (Wed, 24 Feb 2021 20:31:01 GMT) Full text and rfc822 format available.

Message #11 received at 46741 <at> debbugs.gnu.org (full text, mbox):

From: Carl Dong <contact <at> carldong.me>
To: Efraim Flashner <efraim <at> flashner.co.il>
Cc: 46741 <at> debbugs.gnu.org
Subject: Re: [bug#46741] [PATCH] gnu: Return appropriate defconfig for ppc64
 (non-LE)
Date: Wed, 24 Feb 2021 15:30:00 -0500

[Message part 1 (text/plain, inline)]
Hmmm does string-prefix? accept regex? And if so perhaps it should be "powerpc64(le)?-“?

Carl Dong
contact <at> carldong.me
"I fight for the users"

> On Feb 24, 2021, at 3:17 AM, Efraim Flashner <efraim <at> flashner.co.il> wrote:
> 
> On Tue, Feb 23, 2021 at 10:03:12PM -0500, Carl Dong wrote:
>> * gnu/packages/linux.scm (system->defconfig): Add "powerpc64-" prefix.
>> ---
>> gnu/packages/linux.scm | 1 +
>> 1 file changed, 1 insertion(+)
>> 
>> diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
>> index c87c5ffb09..30cbebf849 100644
>> --- a/gnu/packages/linux.scm
>> +++ b/gnu/packages/linux.scm
>> @@ -181,6 +181,7 @@
>> defconfig.  Return the appropriate make target if applicable, otherwise return
>> \"defconfig\"."
>>   (cond ((string-prefix? "powerpc-" system) "pmac32_defconfig")
>> +        ((string-prefix? "powerpc64-" system) "ppc64_defconfig")
>>         ((string-prefix? "powerpc64le-" system) "ppc64_defconfig")
> 
> would it make more sense to change it to "powerpc64" or "powerpc(64)?-"?
> 
>>         (else "defconfig")))
>> 
>> --
>> 2.30.1
>> 
>> 
>> 
>> 
> 
> --
> Efraim Flashner   <efraim <at> flashner.co.il>   אפרים פלשנר
> GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
> Confidentiality cannot be guaranteed on emails sent or received unencrypted


[signature.asc (application/pgp-signature, attachment)]
Information forwarded to guix-patches <at> gnu.org:
bug#46741; Package guix-patches. (Thu, 25 Feb 2021 06:11:02 GMT) Full text and rfc822 format available.

Message #14 received at 46741 <at> debbugs.gnu.org (full text, mbox):

From: Efraim Flashner <efraim <at> flashner.co.il>
To: Carl Dong <contact <at> carldong.me>
Cc: 46741 <at> debbugs.gnu.org
Subject: Re: [bug#46741] [PATCH] gnu: Return appropriate defconfig for ppc64
 (non-LE)
Date: Thu, 25 Feb 2021 08:09:39 +0200

[Message part 1 (text/plain, inline)]
On Wed, Feb 24, 2021 at 03:30:00PM -0500, Carl Dong wrote:
> Hmmm does string-prefix? accept regex? And if so perhaps it should be "powerpc64(le)?-“?

Definitely what I meant to write

> 
> Carl Dong
> contact <at> carldong.me
> "I fight for the users"
> 
> > On Feb 24, 2021, at 3:17 AM, Efraim Flashner <efraim <at> flashner.co.il> wrote:
> > 
> > On Tue, Feb 23, 2021 at 10:03:12PM -0500, Carl Dong wrote:
> >> * gnu/packages/linux.scm (system->defconfig): Add "powerpc64-" prefix.
> >> ---
> >> gnu/packages/linux.scm | 1 +
> >> 1 file changed, 1 insertion(+)
> >> 
> >> diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
> >> index c87c5ffb09..30cbebf849 100644
> >> --- a/gnu/packages/linux.scm
> >> +++ b/gnu/packages/linux.scm
> >> @@ -181,6 +181,7 @@
> >> defconfig.  Return the appropriate make target if applicable, otherwise return
> >> \"defconfig\"."
> >>   (cond ((string-prefix? "powerpc-" system) "pmac32_defconfig")
> >> +        ((string-prefix? "powerpc64-" system) "ppc64_defconfig")
> >>         ((string-prefix? "powerpc64le-" system) "ppc64_defconfig")
> > 
> > would it make more sense to change it to "powerpc64" or "powerpc(64)?-"?
> > 
> >>         (else "defconfig")))
> >> 
> >> --
> >> 2.30.1
> >> 
> >> 
> 



-- 
Efraim Flashner   <efraim <at> flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[signature.asc (application/pgp-signature, inline)]
Information forwarded to guix-patches <at> gnu.org:
bug#46741; Package guix-patches. (Thu, 25 Feb 2021 10:24:01 GMT) Full text and rfc822 format available.

Message #17 received at 46741 <at> debbugs.gnu.org (full text, mbox):

From: Efraim Flashner <efraim <at> flashner.co.il>
To: Carl Dong <contact <at> carldong.me>
Cc: 46741 <at> debbugs.gnu.org
Subject: Re: [bug#46741] [PATCH] gnu: Return appropriate defconfig for ppc64
 (non-LE)
Date: Thu, 25 Feb 2021 12:22:34 +0200

[Message part 1 (text/plain, inline)]
I did some quick testing from the guile repl and it looks like it
doesn't take a regex. I have no preference between two entries for
'powerpc64-' and 'powerpc64le-' vs 'powerpc64'.

On Wed, Feb 24, 2021 at 03:30:00PM -0500, Carl Dong wrote:
> Hmmm does string-prefix? accept regex? And if so perhaps it should be "powerpc64(le)?-“?
> 
> Carl Dong
> contact <at> carldong.me
> "I fight for the users"
> 
> > On Feb 24, 2021, at 3:17 AM, Efraim Flashner <efraim <at> flashner.co.il> wrote:
> > 
> > On Tue, Feb 23, 2021 at 10:03:12PM -0500, Carl Dong wrote:
> >> * gnu/packages/linux.scm (system->defconfig): Add "powerpc64-" prefix.
> >> ---
> >> gnu/packages/linux.scm | 1 +
> >> 1 file changed, 1 insertion(+)
> >> 
> >> diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
> >> index c87c5ffb09..30cbebf849 100644
> >> --- a/gnu/packages/linux.scm
> >> +++ b/gnu/packages/linux.scm
> >> @@ -181,6 +181,7 @@
> >> defconfig.  Return the appropriate make target if applicable, otherwise return
> >> \"defconfig\"."
> >>   (cond ((string-prefix? "powerpc-" system) "pmac32_defconfig")
> >> +        ((string-prefix? "powerpc64-" system) "ppc64_defconfig")
> >>         ((string-prefix? "powerpc64le-" system) "ppc64_defconfig")
> > 
> > would it make more sense to change it to "powerpc64" or "powerpc(64)?-"?
> > 
> >>         (else "defconfig")))
> >> 
> >> --
> >> 2.30.1
> >> 
> >> 
> >> 
> >> 
> > 
> > --
> > Efraim Flashner   <efraim <at> flashner.co.il>   אפרים פלשנר
> > GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
> > Confidentiality cannot be guaranteed on emails sent or received unencrypted
> 



-- 
Efraim Flashner   <efraim <at> flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[signature.asc (application/pgp-signature, inline)]
bug closed, send any further explanations to 46741 <at> debbugs.gnu.org and Carl Dong <contact <at> carldong.me> Request was from Carl Dong <contact <at> carldong.me> to control <at> debbugs.gnu.org. (Fri, 26 Feb 2021 17:04:02 GMT) Full text and rfc822 format available.
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Sat, 27 Mar 2021 11:24:06 GMT) Full text and rfc822 format available.
This bug report was last modified 3 years and 30 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.