GNU bug report logs - #46746
[PATCH] gnu: add python-esptool

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 46746 in the body.
You can then email your comments to 46746 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: qblade <qblade <at> protonmail.com>
To: "guix-patches <at> gnu.org" <guix-patches <at> gnu.org>
Subject: [PATCH] gnu: add python-esptool
Date: Wed, 24 Feb 2021 11:41:34 +0000

[Message part 1 (text/plain, inline)]

Empty Message

[0001-gnu-add-python-esptool.patch (text/x-patch, attachment)]

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: qblade via Guix-patches via <guix-patches <at> gnu.org>
Cc: qblade <qblade <at> protonmail.com>, 46746-done <at> debbugs.gnu.org
Subject: Re: [bug#46746] [PATCH] gnu: add python-esptool
Date: Thu, 25 Feb 2021 10:46:54 +0100

Hello,

Thank you. I applied the patch with minor modifications.

qblade via Guix-patches via <guix-patches <at> gnu.org> writes:

> +    (arguments
> +     `(#:tests? #f))

I added a comment explaining why the tests were skipped. In this case,
we do not provide python-reedsolo library yet.

> +    (synopsis
> +     "Serial utility to communicate & flash code to
> +Espressif ESP8266 & ESP32 chips")

I shortened the synopsis.

> +    (description
> +     "Python-based, open source, platform independent,
> +utility to communicate with the ROM bootloader
> +in Espressif ESP8266 & ESP32 series chips.")

I wrote a full sentence, and remove "open source", and "platform
independant" from it.

Regards,
-- 
Nicolas Goaziou

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.