GNU bug report logs - #46805
[PATCH] guix: ui: Improved error reporting when user file eval fails

Previous Next

To reply to this bug, email your comments to 46805 AT debbugs.gnu.org.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Rovanion Luckey <rovanion.luckey <at> gmail.com>
To: guix-patches <at> gnu.org
Subject: [PATCH] guix: ui: Improved error reporting when user file eval fails
Date: Fri, 26 Feb 2021 23:36:46 +0100

[Message part 1 (text/plain, inline)]

Added a specific error message for when the user provided scheme file being
evaluated in turn fails to load another file. Also clearified the error
message given on generic system errors, to make it clear where the error
originates from.

See attached patch.

[Message part 2 (text/html, inline)]

[0001-guix-ui-Improved-error-reporting-when-user-file-eval.patch (text/x-patch, attachment)]

Message #8 received at 46805 <at> debbugs.gnu.org (full text, mbox):

From: Xinglu Chen <public <at> yoctocell.xyz>
To: Rovanion Luckey <rovanion.luckey <at> gmail.com>, 46805 <at> debbugs.gnu.org
Subject: Re: [bug#46805] [PATCH] guix: ui: Improved error reporting when
 user file eval fails
Date: Tue, 23 Mar 2021 14:18:19 +0100

On Fri, Feb 26 2021, Rovanion Luckey wrote:

> Added a specific error message for when the user provided scheme file being
> evaluated in turn fails to load another file. Also clearified the error
> message given on generic system errors, to make it clear where the error
> originates from.

Great, much better than just saying "error: VAR unbound variable".

> Added a specific error message for when the user provided scheme file
> being evaluated in turn fails to load another file. Also clearified

Typo fix, s/clearified/clarified

Message #11 received at 46805 <at> debbugs.gnu.org (full text, mbox):

From: Rovanion Luckey <rovanion.luckey <at> gmail.com>
To: 46805 <at> debbugs.gnu.org
Cc: Xinglu Chen <public <at> yoctocell.xyz>
Subject: Re: [bug#46805] [PATCH] guix: ui: Improved error reporting when user
 file eval fails
Date: Wed, 24 Mar 2021 14:36:02 +0100

[Message part 1 (text/plain, inline)]

Fixed the typo in the attached patch.

[Message part 2 (text/html, inline)]

[0001-guix-ui-Improved-error-reporting-when-user-file-eval.patch (text/x-patch, attachment)]

Message #14 received at 46805 <at> debbugs.gnu.org (full text, mbox):

From: Rovanion Luckey <rovanion.luckey <at> gmail.com>
To: 46805 <at> debbugs.gnu.org
Subject: [PATCH] guix: ui: Improved error reporting when user file eval fails
Date: Tue, 12 Oct 2021 20:14:05 +0200

[Message part 1 (text/plain, inline)]

I should pattern match instead of using that long (car (cdr (car))) line
like something along the lines of (let ((which-file-failed (match rest ((_
_ file) file)))) ...). This will need the module (ice-9 match).

[Message part 2 (text/html, inline)]

Message #17 received at 46805 <at> debbugs.gnu.org (full text, mbox):

From: Rovanion Luckey <rovanion.luckey <at> gmail.com>
To: 46805 <at> debbugs.gnu.org
Subject: [PATCH] guix: ui: Improved error reporting when user file eval fails
Date: Tue, 12 Oct 2021 20:16:25 +0200

[Message part 1 (text/plain, inline)]

Or maybe even better, I could do that on the args match: ('system-error
"open-file" . rest) becomes ('system-error "open-file" _ which-file-failed
. rest).

Both these suggestions should be credited to roptat.

[Message part 2 (text/html, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.