GNU bug report logs - #46817
update python grammar

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 46817 in the body.
You can then email your comments to 46817 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Martin Puttke <martinstefanputtke <at> posteo.de>
To: bug-gnu-emacs <at> gnu.org
Subject: update python grammar
Date: Sat, 27 Feb 2021 19:04:53 +0100

[Message part 1 (text/plain, inline)]

Hi out there,

I made some fixes to enhance the python grammar file to enable it 
to understand python type hints and have non-trivial base classes. 
Please feel free to include my changes into emacs.

please find my patches attached.

All the best

Martin

[0001-add-python-grammar-for-type-hints-in-variable-defini.patch (text/x-diff, attachment)]

[0002-add-python-grammar-for-type-hints-for-function-retur.patch (text/x-diff, attachment)]

[0003-generalize-type-definition-and-apply-it-to-parent-cl.patch (text/x-diff, attachment)]

[Message part 5 (text/plain, inline)]

-- 
Composed with Spacemacs (www.spacemacs.org)

Message #8 received at 46817 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Martin Puttke <martinstefanputtke <at> posteo.de>
Cc: 46817 <at> debbugs.gnu.org
Subject: Re: bug#46817: update python grammar
Date: Sun, 28 Feb 2021 15:22:59 +0100

Martin Puttke <martinstefanputtke <at> posteo.de> writes:

> I made some fixes to enhance the python grammar file to enable it to
> understand python type hints and have non-trivial base classes. Please
> feel free to include my changes into emacs.

Thanks; I'm not a Python or Wisent expert, but if I read the patch
correctly, it looks good to me, and I've applied your patch to Emacs 28.

This change was small enough to apply without assigning copyright to the
FSF, but for future patches you want to submit, it might make sense to
get the paperwork started now, so that subsequent patches can be applied
speedily. Would you be willing to sign such paperwork?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #15 received at 46817 <at> debbugs.gnu.org (full text, mbox):

From: Martin Puttke <martinstefanputtke <at> posteo.de>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 46817 <at> debbugs.gnu.org
Subject: Re: bug#46817: update python grammar
Date: Tue, 02 Mar 2021 19:08:51 +0100

Hi Lars,

thank you for your offer to do the FSF paperwork. But at the 
moment I have no plans to submit another patch to emacs. It may 
come, but I prefer to do it when needed.

All the best
Martin

Lars Ingebrigtsen <larsi <at> gnus.org> writes:

> Martin Puttke <martinstefanputtke <at> posteo.de> writes:
>
>> I made some fixes to enhance the python grammar file to enable 
>> it to
>> understand python type hints and have non-trivial base classes. 
>> Please
>> feel free to include my changes into emacs.
>
> Thanks; I'm not a Python or Wisent expert, but if I read the 
> patch
> correctly, it looks good to me, and I've applied your patch to 
> Emacs 28.
>
> This change was small enough to apply without assigning 
> copyright to the
> FSF, but for future patches you want to submit, it might make 
> sense to
> get the paperwork started now, so that subsequent patches can be 
> applied
> speedily. Would you be willing to sign such paperwork?


-- 
Composed with Spacemacs (www.spacemacs.org)

Message #18 received at 46817 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Martin Puttke <martinstefanputtke <at> posteo.de>
Cc: 46817 <at> debbugs.gnu.org
Subject: Re: bug#46817: update python grammar
Date: Wed, 03 Mar 2021 15:52:18 +0100

Martin Puttke <martinstefanputtke <at> posteo.de> writes:

> thank you for your offer to do the FSF paperwork. But at the moment I
> have no plans to submit another patch to emacs. It may come, but I
> prefer to do it when needed.

Sure; that's fine.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.