GNU bug report logs - #46826
(guix scripts environment) fails to build with Guile 2.2

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 46826 in the body.
You can then email your comments to 46826 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: cage <cage-dev <at> twistfold.it>
To: bug-guix <at> gnu.org
Subject: [debian] compilation from git fails
Date: Sun, 28 Feb 2021 09:03:02 +0100

Hi!

i tried to compile guix from git but the compilation fails with a syntax error, details below:

- OS Debian testing (bullseye)
- guix commit hash 8ef1f24f16354e08f23dfabf11396527b0417638 (master)
- $ guile --version
    guile (GNU Guile) 2.2.7

The error is:

$ make

[...]

guix/scripts/environment.scm:752:12: error: (define manifest (if profile (profile-manifest profile) manifest-from-opts)): definition in expression context, where definitions are not allowed,
make[2]: *** [Makefile:6246: make-go] Error 1


A    kind     user    suggested    to    comment     the    form    in
guix/scripts/environment.scm starting at line 178:

------------
(when (and profile
  (> (length (manifest-entries manifest-from-opts)) 0))
   (leave (G_ "'--profile' cannot be used with package options~%")))
-----------

After commenting the form above, the compilation works flawless.

Hope this help!
Bye!
C.

Message #8 received at 46826 <at> debbugs.gnu.org (full text, mbox):

From: cage <cage-dev <at> twistfold.it>
To: 46826 <at> debbugs.gnu.org
Subject: [debian] compilation from git fails
Date: Sun, 28 Feb 2021 10:04:56 +0100

Errata:

> guix/scripts/environment.scm starting at line 178:

line 748 actually.

Bye!
C.

Message #11 received at 46826 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: cage <cage-dev <at> twistfold.it>, 46826 <at> debbugs.gnu.org
Subject: Re: bug#46826: [debian] compilation from git fails
Date: Mon, 01 Mar 2021 12:42:08 +0100

[Message part 1 (text/plain, inline)]

On Sun, 2021-02-28 at 09:03 +0100, cage wrote:

> [...]
> A    kind     user    suggested    to    comment     the    form    in
> guix/scripts/environment.scm starting at line 178:
> 
> ------------
> (when (and profile
>   (> (length (manifest-entries manifest-from-opts)) 0))
>    (leave (G_ "'--profile' cannot be used with package options~%")))
> -----------
> 
> After commenting the form above, the compilation works flawless.

The guile2.2-bytestructures dependency of guile2.2-guix is broken currently
(see https://issues.guix.gnu.org/46844), which makes my proposal somewhat annoying
to test ...

Perhaps replace (when COND STUFF) with (define _ (when COND STUFF))? That should
be ok for both guile2.2 and guile3.0.  It's not very aesthetical, but if the
alternative is putting everything below (when COND STUFF) in a let form
(leading to more indentation), perhaps that's ok.

cage, could you verify whether this patch works for you?

Greetings,
Maxime.
-- 
Maxime Devos <maximedevos <at> telenet.be>
PGP Key: C1F3 3EE2 0C52 8FDB 7DD7  011F 49E3 EE22 1917 25EE
Freenode handle: mdevos

[0001-scripts-environment-Replace-expression-with-definiti.patch (text/x-patch, attachment)]

[signature.asc (application/pgp-signature, inline)]

Message #14 received at 46826 <at> debbugs.gnu.org (full text, mbox):

From: cage <cage-dev <at> twistfold.it>
To: Maxime Devos <maximedevos <at> telenet.be>
Cc: 46826 <at> debbugs.gnu.org, cage <cage-dev <at> twistfold.it>
Subject: Re: bug#46826: [debian] compilation from git fails
Date: Mon, 1 Mar 2021 14:12:24 +0100

On Mon, Mar 01, 2021 at 12:42:08PM +0100, Maxime Devos wrote:

Hi!

>
> Perhaps replace (when COND STUFF) with (define _ (when COND STUFF))? That should
> be ok for both guile2.2 and guile3.0.  It's not very aesthetical, but if the
> alternative is putting everything below (when COND STUFF) in a let form
> (leading to more indentation), perhaps that's ok.
>
> cage, could you verify whether this patch works for you?

I wrapped that form in a (define _ ...) and I was able to compile guix
without errors.

Bye!
C.

Message #19 received at 46826-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: cage <cage-dev <at> twistfold.it>
Cc: 46826-done <at> debbugs.gnu.org, Maxime Devos <maximedevos <at> telenet.be>
Subject: Re: bug#46826: [debian] compilation from git fails
Date: Mon, 01 Mar 2021 21:40:33 +0100

Hi!

I pushed a slightly different fix as
9ce78f27a02b3a5fcaea2f0633404b940795989a.

Thanks,
Ludo’.

Message #24 received at 46826-done <at> debbugs.gnu.org (full text, mbox):

From: cage <cage-dev <at> twistfold.it>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 46826-done <at> debbugs.gnu.org, Maxime Devos <maximedevos <at> telenet.be>,
 cage <cage-dev <at> twistfold.it>
Subject: Re: bug#46826: [debian] compilation from git fails
Date: Tue, 2 Mar 2021 20:39:11 +0100

On Mon, Mar 01, 2021 at 09:40:33PM +0100, Ludovic Courtès wrote:
> Hi!

Hi!

>
> I pushed a slightly different fix as
> 9ce78f27a02b3a5fcaea2f0633404b940795989a.

FWIW the compilation works just fine! :)

> Thanks,

You're welcome!
C.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.