GNU bug report logs - #46833
[PATCH v2] import: hackage: Accept optional version parameter.

Previous Next

Package: guix-patches;

Reported by: Xinglu Chen <public <at> yoctocell.xyz>

Date: Sun, 28 Feb 2021 17:37:02 UTC

Severity: normal

Tags: patch

Merged with 46832

Done: Ludovic Courtès <ludo <at> gnu.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 46833 in the body.
You can then email your comments to 46833 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to guix-patches <at> gnu.org:
bug#46833; Package guix-patches. (Sun, 28 Feb 2021 17:37:02 GMT) Full text and rfc822 format available.
Acknowledgement sent to Xinglu Chen <public <at> yoctocell.xyz>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Sun, 28 Feb 2021 17:37:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Xinglu Chen <public <at> yoctocell.xyz>
To: guix-patches <at> gnu.org
Subject: [PATCH v2] import: hackage: Accept optional version parameter.
Date: Sun, 28 Feb 2021 17:18:34 +0100

* guix/import/hackage.scm (hackage-recursive-import): Add the VERSION key.
  Make REPO a key.
---
Ugh, made a typo in the commit summary.

 guix/import/hackage.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/guix/import/hackage.scm b/guix/import/hackage.scm
index 6ca4f65cb0..9f992ffe8e 100644
--- a/guix/import/hackage.scm
+++ b/guix/import/hackage.scm
@@ -344,8 +344,8 @@ respectively."
   (memoize hackage->guix-package))
 
 (define* (hackage-recursive-import package-name . args)
-  (recursive-import package-name #f
-                    #:repo->guix-package (lambda (name repo)
+  (recursive-import package-name
+                    #:repo->guix-package (lambda* (name #:key repo version)
                                            (apply hackage->guix-package/m
                                                   (cons name args)))
                     #:guix-name hackage-name->package-name))
-- 
2.30.0
Merged 46832 46833. Request was from Ludovic Courtès <ludo <at> gnu.org> to control <at> debbugs.gnu.org. (Mon, 01 Mar 2021 16:00:03 GMT) Full text and rfc822 format available.
Reply sent to Ludovic Courtès <ludo <at> gnu.org>:
You have taken responsibility. (Mon, 01 Mar 2021 16:03:02 GMT) Full text and rfc822 format available.
Notification sent to Xinglu Chen <public <at> yoctocell.xyz>:
bug acknowledged by developer. (Mon, 01 Mar 2021 16:03:02 GMT) Full text and rfc822 format available.

Message #12 received at 46833-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Xinglu Chen <public <at> yoctocell.xyz>
Cc: 46833-done <at> debbugs.gnu.org
Subject: Re: bug#46833: [PATCH v2] import: hackage: Accept optional version
 parameter.
Date: Mon, 01 Mar 2021 17:02:13 +0100

Hi,

Xinglu Chen <public <at> yoctocell.xyz> skribis:

> * guix/import/hackage.scm (hackage-recursive-import): Add the VERSION key.
>   Make REPO a key.

Applied, thanks!

Ludo’.
Reply sent to Ludovic Courtès <ludo <at> gnu.org>:
You have taken responsibility. (Mon, 01 Mar 2021 16:03:02 GMT) Full text and rfc822 format available.
Notification sent to Xinglu Chen <public <at> yoctocell.xyz>:
bug acknowledged by developer. (Mon, 01 Mar 2021 16:03:02 GMT) Full text and rfc822 format available.
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Tue, 30 Mar 2021 11:24:07 GMT) Full text and rfc822 format available.
This bug report was last modified 3 years and 26 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.