GNU bug report logs - #46994
[PATCH] gnu: polkit.scm: Add missing copyright headers.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 46994 in the body.
You can then email your comments to 46994 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Morgan.J.Smith <at> outlook.com
To: guix-patches <at> gnu.org
Cc: Morgan Smith <Morgan.J.Smith <at> outlook.com>
Subject: [PATCH] gnu: polkit.scm: Add missing copyright headers.
Date: Sun,  7 Mar 2021 16:08:56 -0500

From: Morgan Smith <Morgan.J.Smith <at> outlook.com>

* gnu/packages/polkit.scm: Add missing copyright headers.
---

I don't know if this is usually done. I just noticed that the file I was
working on had very few copyright lines so I filled it in with info from the
git history.

---
 gnu/packages/polkit.scm | 14 ++++++++++----
 1 file changed, 10 insertions(+), 4 deletions(-)

diff --git a/gnu/packages/polkit.scm b/gnu/packages/polkit.scm
index d868aceec2..7c7fc58bb6 100644
--- a/gnu/packages/polkit.scm
+++ b/gnu/packages/polkit.scm
@@ -1,11 +1,17 @@
 ;;; GNU Guix --- Functional package management for GNU
 ;;; Copyright © 2014 Andreas Enge <andreas <at> enge.fr>
-;;; Copyright © 2015 Andy Wingo <wingo <at> igalia.com>
-;;; Copyright © 2015 Mark H Weaver <mhw <at> netris.org>
-;;; Copyright © 2016 Efraim Flashner <efraim <at> flashner.co.il>
+;;; Copyright © 2015 Sou Bunnbu <iyzsong <at> gmail.com>
+;;; Copyright © 2015, 2018, 2019 Ludovic Courtès <ludo <at> gnu.org>
+;;; Copyright © 2015, 2016 Andy Wingo <wingo <at> igalia.com>
+;;; Copyright © 2015, 2016 Mark H Weaver <mhw <at> netris.org>
+;;; Copyright © 2016, 2019 Efraim Flashner <efraim <at> flashner.co.il>
+;;; Copyright © 2016 Alex Kost <alezost <at> gmail.com>
+;;; Copyright © 2016 David Craven <david <at> craven.ch>
 ;;; Copyright © 2017 Huang Ying <huang.ying.caritas <at> gmail.com>
 ;;; Copyright © 2018 Tobias Geerinckx-Rice <me <at> tobias.gr>
-;;; Copyright © 2018 Ricardo Wurmus <rekado <at> elephly.net>
+;;; Copyright © 2018, 2019 Ricardo Wurmus <rekado <at> elephly.net>
+;;; Copyright © 2018 Leo Famulari <leo <at> famulari.name>
+;;; Copyright © 2019 Marius Bakke <mbakke <at> fastmail.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
-- 
2.30.1

Message #8 received at 46994 <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Morgan.J.Smith <at> outlook.com
Cc: 46994 <at> debbugs.gnu.org
Subject: Re: bug#46994: [PATCH] gnu: polkit.scm: Add missing copyright headers.
Date: Fri, 08 Oct 2021 11:45:36 -0400

Hello,

Morgan.J.Smith <at> outlook.com writes:

> From: Morgan Smith <Morgan.J.Smith <at> outlook.com>
>
> * gnu/packages/polkit.scm: Add missing copyright headers.
> ---
>
> I don't know if this is usually done. I just noticed that the file I was
> working on had very few copyright lines so I filled it in with info from the
> git history.

This could be done if, for example, the packages got move but their
copyright attribution forgotten.  In which case careful review should be
done to make sure the copyrights are moved or copied, accordingly.

Also, code removal and trivial edits (such as updating < 10 lines, for
example by bumping the version string and the hash of a package) are not
usually considered significant enough to be copyrighted, so this may
explain the discrepancy.

Were the changes in the git history copyright-worthy?

Thanks,

Maxim

Message #11 received at 46994 <at> debbugs.gnu.org (full text, mbox):

From: Morgan Smith <Morgan.J.Smith <at> outlook.com>
To: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Cc: 46994 <at> debbugs.gnu.org
Subject: Re: bug#46994: [PATCH] gnu: polkit.scm: Add missing copyright headers.
Date: Fri, 8 Oct 2021 14:30:13 -0400

> Also, code removal and trivial edits (such as updating < 10 lines, for
> example by bumping the version string and the hash of a package) are not
> usually considered significant enough to be copyrighted, so this may
> explain the discrepancy.
> 
> Were the changes in the git history copyright-worthy?

Most of these are trivial and do not deserve copyright. I was unaware of 
these exceptions.

I believe the following copyright should be added:
Ludo 2015 for cb151c68bf and 222e3319bd

Neither of those two changes are greater than 10 lines but I'd call them 
non-trivial.

Feel free to close this bug after you've decided if you'll add that one 
copyright. Had I known what I know now I wouldn't have opened this bug.

Thanks,

Morgan

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.