GNU bug report logs - #47069
[PATCH] etc: Run pre-push make in guix environment.

Previous Next

To reply to this bug, email your comments to 47069 AT debbugs.gnu.org.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Tobias Geerinckx-Rice <me <at> tobias.gr>
To: guix-patches <at> gnu.org
Subject: [PATCH] etc: Run pre-push make in guix environment.
Date: Thu, 11 Mar 2021 15:42:57 +0100

* etc/git/pre-push: Exec make in a guix development environment.
---

Guix,

The pre-push assumes you have make installed, which I didn't.

Now it assumes that Guix developers have a vaguely up-to-date guix
command, which seems reasonable.

Kind regards,

T G-R

 etc/git/pre-push | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/etc/git/pre-push b/etc/git/pre-push
index 59671b0d58..372c7dece0 100755
--- a/etc/git/pre-push
+++ b/etc/git/pre-push
@@ -32,7 +32,7 @@ do
 		# Only use the hook when pushing to Savannah.
 		case "$2" in
 		    *.gnu.org*)
-			exec make authenticate check-channel-news
+			exec guix environment guix -- make authenticate check-channel-news
 			exit 127
 			;;
 		    *)
-- 
2.30.1

Message #8 received at 47069 <at> debbugs.gnu.org (full text, mbox):

From: zimoun <zimon.toutoune <at> gmail.com>
To: Tobias Geerinckx-Rice <me <at> tobias.gr>
Cc: 47069 <at> debbugs.gnu.org
Subject: Re: [bug#47069] [PATCH] etc: Run pre-push make in guix environment.
Date: Fri, 26 Mar 2021 09:20:17 +0100

Hi Tobias,

On Thu, 11 Mar 2021 at 15:42, Tobias Geerinckx-Rice <me <at> tobias.gr> wrote:
> * etc/git/pre-push: Exec make in a guix development environment.
> ---

> The pre-push assumes you have make installed, which I didn't.

How do you rebuild Guix before pushing?


Cheers,
simon

Message #11 received at 47069 <at> debbugs.gnu.org (full text, mbox):

From: Leo Prikler <leo.prikler <at> student.tugraz.at>
To: zimoun <zimon.toutoune <at> gmail.com>, Tobias Geerinckx-Rice <me <at> tobias.gr>
Cc: 47069 <at> debbugs.gnu.org
Subject: Re: [bug#47069] [PATCH] etc: Run pre-push make in guix environment.
Date: Fri, 26 Mar 2021 11:11:59 +0100

Am Freitag, den 26.03.2021, 09:20 +0100 schrieb zimoun:
> Hi Tobias,
> 
> On Thu, 11 Mar 2021 at 15:42, Tobias Geerinckx-Rice <me <at> tobias.gr>
> wrote:
> > * etc/git/pre-push: Exec make in a guix development environment.
> > ---
> > The pre-push assumes you have make installed, which I didn't.
> 
> How do you rebuild Guix before pushing?
If that's a problem for the script, you could add an explicit 'all'
target.  

That said, I think, that many developers (myself included), who would
suffer from the problem mentioned by Tobias already run 'git push'
inside a guix environment.  I know I do.  
@Tobias: would it make sense to detect that case (via GUIX_ENVIRONMENT)
and only optionally construct the guix environment?

Regards,
Leo

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.