GNU bug report logs - #47088
org-w3m: handle w3m-image link information

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 47088 in the body.
You can then email your comments to 47088 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Boruch Baum <boruch_baum <at> gmx.com>
To: Emacs Bug Reporting <bug-gnu-emacs <at> gnu.org>
Subject: org-w3m: handle w3m-image link information
Date: Fri, 12 Mar 2021 01:26:14 -0500

[Message part 1 (text/plain, inline)]

Attached is a patch that adds to function `org-w3m-copy-for-org-mode'
support for w3m-image links. Note that because function
`org-make-link-string' is used for constructing the buffer substring to
be copied, w3m's special face to distinguish an image link is not
transfered.

--
hkp://keys.gnupg.net
CA45 09B5 5351 7C11 A9D1  7286 0036 9E45 1595 8BC0

[image.patch (text/x-diff, attachment)]

Message #8 received at 47088 <at> debbugs.gnu.org (full text, mbox):

From: Bastien <bzg <at> gnu.org>
To: Boruch Baum <boruch_baum <at> gmx.com>
Cc: 47088 <at> debbugs.gnu.org
Subject: Re: bug#47088: org-w3m: handle w3m-image link information
Date: Wed, 05 May 2021 10:16:48 +0200

Boruch Baum <boruch_baum <at> gmx.com> writes:

> Attached is a patch that adds to function `org-w3m-copy-for-org-mode'
> support for w3m-image links. Note that because function
> `org-make-link-string' is used for constructing the buffer substring to
> be copied, w3m's special face to distinguish an image link is not
> transfered.

Thanks, it looks good.

Can you try updating the patch against Org's upstream repository at
https://code.orgmode.org/bzg/org-mode/?

Note that the file is lisp/ol-w3m.el there.

-- 
 Bastien

Message #11 received at 47088 <at> debbugs.gnu.org (full text, mbox):

From: Boruch Baum <boruch_baum <at> gmx.com>
To: Bastien <bzg <at> gnu.org>
Cc: 47088 <at> debbugs.gnu.org
Subject: Re: bug#47088: org-w3m: handle w3m-image link information
Date: Thu, 6 May 2021 18:05:15 -0400

[Message part 1 (text/plain, inline)]

On 2021-05-05 10:16, Bastien wrote:
> Thanks, it looks good.
>
> Can you try updating the patch against Org's upstream repository at
> https://code.orgmode.org/bzg/org-mode/?
>
> Note that the file is lisp/ol-w3m.el there.

1] Attached.

2] Here's a commit message in the Changelog style:

   2021-05-06  Boruch Baum  <boruch_baum <at> gmx.com>

	* ol-w3m.el (org-w3m-copy-for-org-mode)
	(org-w3m-get-next-link-start, org-w3m-get-prev-link-start):
	Account for w3m-img links.
	(org-w3m-get-anchor-start, org-w3m-get-prev-link-start)
	(org-w3m-no-prev-link-p): Unused function notes.
	(org-w3m-get-image-end): New function, for w3m-img links.

3] As mentioned in the patch, and in the commit message, there seem to
   be several functioned unused in the code base that could be
   candidates for removal...

        org-w3m-get-anchor-start
        org-w3m-no-prev-link-p
        org-w3m-get-prev-link-start

4] Additionally, in performing the merge I came across function
   org-string-nw-p, which seems to be an unnecessary duplicate of the
   emacs core function string-blank-p. It may be that historically you
   once needed your own home-made functions/macros, but now that emacs
   core has them, you may want to consider a refactor.

--
hkp://keys.gnupg.net
CA45 09B5 5351 7C11 A9D1  7286 0036 9E45 1595 8BC0

[ol-w3m.patch (text/x-diff, attachment)]

Message #16 received at 47088-done <at> debbugs.gnu.org (full text, mbox):

From: Bastien <bzg <at> gnu.org>
To: Boruch Baum <boruch_baum <at> gmx.com>
Cc: 47088-done <at> debbugs.gnu.org
Subject: Re: bug#47088: org-w3m: handle w3m-image link information
Date: Sun, 09 May 2021 08:50:01 +0200

I'm closing this report as the patch has been applied upstream.

-- 
 Bastien

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.