Received: (at 47269) by debbugs.gnu.org; 20 Mar 2021 10:59:02 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sat Mar 20 06:59:02 2021 Received: from localhost ([127.0.0.1]:51607 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1lNZJt-0006sp-Td for submit <at> debbugs.gnu.org; Sat, 20 Mar 2021 06:59:02 -0400 Received: from lepiller.eu ([89.234.186.109]:41562) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <julien@HIDDEN>) id 1lNZJq-0006se-Nd for 47269 <at> debbugs.gnu.org; Sat, 20 Mar 2021 06:59:01 -0400 Received: from lepiller.eu (localhost [127.0.0.1]) by lepiller.eu (OpenSMTPD) with ESMTP id 95ef9563; Sat, 20 Mar 2021 10:58:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=lepiller.eu; h=date :in-reply-to:references:mime-version:content-type :content-transfer-encoding:subject:to:from:message-id; s=dkim; bh=ECNsDieqgDCC5Gr3Q9WVQZy6zo+txNeNT1vAh2gf6KI=; b=UvFvSI5A6QwV FfywzfINz0NduwgnMSsXeMMByCbHfUhBnxn1rKGDc3iYXP91VUSnVM57d0jQngN8 cIwnINftwc/voSboaDMsVATNDQi5WSm8NvY+00CiR1b3T/mBkqQ2ck+CCI71bNeM knz5dEPdSlsnm3iZudjBu2Uoeae17hv96NBSIsH9Lu8FbVWy1thr2rQ2kOM1wZrz QTtVC+9GdTlh8khoM+Jdpur/PcACxAjiqptcvG5w3XwFmC2znVJij0rKmalOvkqo taiVujU7NojjhJkjQjiEGxib/uoWC1vCOVaa5w5r+E6ETAFS7r8uIstNXVnXTWzf bIPUcN+Cpg== Received: by lepiller.eu (OpenSMTPD) with ESMTPSA id df34a768 (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256:NO); Sat, 20 Mar 2021 10:58:55 +0000 (UTC) Date: Sat, 20 Mar 2021 06:58:47 -0400 User-Agent: K-9 Mail for Android In-Reply-To: <6ac44e1dc193a3d78351aed9a80e1c651e809ab5.camel@HIDDEN> References: <20210319192144.17799-1-contact@HIDDEN> <6ac44e1dc193a3d78351aed9a80e1c651e809ab5.camel@HIDDEN> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [bug#47269] [PATCH 0/1] Add node-global-gradle-clean To: Maxime Devos <maximedevos@HIDDEN>, Dhruvin Gandhi <contact@HIDDEN>, 47269 <at> debbugs.gnu.org From: Julien Lepiller <julien@HIDDEN> Message-ID: <A8F6017C-2514-4E94-B00C-1975EA790432@HIDDEN> X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 47269 X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Le 20 mars 2021 04:51:41 GMT-04:00, Maxime Devos <maximedevos@telenet=2Ebe= > a =C3=A9crit : >On Sat, 2021-03-20 at 00:51 +0530, Dhruvin Gandhi via Guix-patches via >wrote: >> I've recently started using Guix System and it has been my daily >driver for a >> month now=2E Surprisingly, guix already has every package I need=2E I >decided to >> ask my friends about packages they'll need before they can start >using Guix=2E >>=20 >> I will try to submit patches of those packages in coming months=2E I am >new to >> guix, and am new to contributing code via patches=2E Let me know if you >have any >> corrections/suggestions=2E > >I prefer referring to the commit directly instead of by tag, as >the commit is required for SWH fallback if the repo disappears=2E Sorry to contradict, but using a tag is much more readable and works well = with Software Heritage=2E At least, the linter seems to work in that case= =2E Have I missed something? Dhruvin, could you submit a new patch with Maxime's suggestions? If you ha= ve troubles with Rome items don't worry, since It's your first patch, we ca= n change a few things for you before pushing :) Also, could you run (from the guix checkout): =2E/pre-inst-env guix lint node-global-gradle-clean And fix any error it reports? Thanks a lot!
guix-patches@HIDDEN
:bug#47269
; Package guix-patches
.
Full text available.Received: (at 47269) by debbugs.gnu.org; 20 Mar 2021 08:51:54 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sat Mar 20 04:51:54 2021 Received: from localhost ([127.0.0.1]:51479 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1lNXKs-0001S7-54 for submit <at> debbugs.gnu.org; Sat, 20 Mar 2021 04:51:54 -0400 Received: from albert.telenet-ops.be ([195.130.137.90]:40652) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <maximedevos@HIDDEN>) id 1lNXKo-0001Rx-Vl for 47269 <at> debbugs.gnu.org; Sat, 20 Mar 2021 04:51:53 -0400 Received: from ptr-bvsjgyjmffd7q9timvx.18120a2.ip6.access.telenet.be ([IPv6:2a02:1811:8c09:9d00:aaf1:9810:a0b8:a55d]) by albert.telenet-ops.be with bizsmtp id iYro2400U0mfAB406Yrovm; Sat, 20 Mar 2021 09:51:49 +0100 Message-ID: <6ac44e1dc193a3d78351aed9a80e1c651e809ab5.camel@HIDDEN> Subject: Re: [bug#47269] [PATCH 0/1] Add node-global-gradle-clean From: Maxime Devos <maximedevos@HIDDEN> To: Dhruvin Gandhi <contact@HIDDEN>, 47269 <at> debbugs.gnu.org Date: Sat, 20 Mar 2021 09:51:41 +0100 In-Reply-To: <20210319192144.17799-1-contact@HIDDEN> References: <20210319192144.17799-1-contact@HIDDEN> Content-Type: multipart/signed; micalg="pgp-sha256"; protocol="application/pgp-signature"; boundary="=-QsSyTXOcMrFcABbfW34i" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r21; t=1616230309; bh=Ea06ulRFUjgfk+suNezWEvX3GfNdDVJfz3anzo9sWm4=; h=Subject:From:To:Date:In-Reply-To:References; b=kV6slwmzQ2udyIyVc9sH9mhfOewIgcFI/X4c2Gd4kL7Z38Z0v7ERgcZs2WtQhURpL EyI6Db7CWxpI+RyoCongbSsgyu9t6tCFZqCn9mSFE3J3/HQtgThK9fPOvG5VEhF0k0 uU4bEjk5YXyLzF3eqwyN72cB2w+/NSjCNoVuZR5ow+ZHVX1obHqcTA1oxUhYAXceuw A5gWLLByNQhED0c9Ip0uUxH1pnSmxiSjIF8/wkKua8qbPO6p8rr5rmvaS0Ir4tdWyU APUYojqzYPZMr8O1XFqZLf33+iG2PIT+qmevWwrLAhZmlGoM9x5nl+xbltnhp9PLNo X09n66tdu7iPA== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 47269 X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.7 (-) --=-QsSyTXOcMrFcABbfW34i Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sat, 2021-03-20 at 00:51 +0530, Dhruvin Gandhi via Guix-patches via wrot= e: > I've recently started using Guix System and it has been my daily driver f= or a > month now. Surprisingly, guix already has every package I need. I decided= to > ask my friends about packages they'll need before they can start using Gu= ix. >=20 > I will try to submit patches of those packages in coming months. I am new= to > guix, and am new to contributing code via patches. Let me know if you hav= e any > corrections/suggestions. See =E2=80=9816.4 Packaging Guidelines=E2=80=99 and =E2=80=9816.6 Submittin= g Patches=E2=80=99 in the manual. > Dhruvin Gandhi (1): > Add node-global-gradle-clean >=20 > gnu/packages/node-xyz.scm | 22 ++++++++++++++++++++++ > 1 file changed, 22 insertions(+) There's an uniform style for commit messages. Example for when adding new packages: (start snip) commit 7382b1027a319e505be6cfcadf1f5bd761dadccc Author: Ricardo Wurmus <rekado@HIDDEN> Date: Thu Feb 4 23:20:05 2021 +0100 gnu: Add r-shinyjqui. =20 * gnu/packages/cran.scm (r-shinyjqui): New variable. commit 5ae09d7979a0696d862b9555314eab199f7ce576 Author: Ricardo Wurmus <rekado@HIDDEN> Date: Thu Feb 4 22:41:35 2021 +0100 gnu: Add r-spelling. =20 * gnu/packages/cran.scm (r-spelling): New variable. (end snip) (More examples in the git history) When defining a new package, usually a copyright line should be added at the top of the file. I prefer referring to the commit directly instead of by tag, as the commit is required for SWH fallback if the repo disappears. Is there any particular reason tests are disabled? Maybe add a comment "; No test suite." if that's the case. I'm not a fan of starting package descriptions with "This package is ...", even though plenty of plenty of packages in gnu/package/node-xyz.scm have such a description. A description from gnu/packages/guile-xyz.scm I like: "Guile-DSV is a GNU Guile module for working with the delimiter-separated values (DSV) data format. Guile-DSV supports the Unix-style DSV format and RFC 4180 format." Greetings, Maxime. --=-QsSyTXOcMrFcABbfW34i Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iI0EABYIADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYFW3nRccbWF4aW1lZGV2 b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7siVAP4wF9MCySxbUVov1wjxps6avUqu wbz9BCDDLk6jfu4hrgEAlbYv30gh2RQ7augbM1RwXhXXu6dy5+NWa2iYj8EKjAI= =03uX -----END PGP SIGNATURE----- --=-QsSyTXOcMrFcABbfW34i--
guix-patches@HIDDEN
:bug#47269
; Package guix-patches
.
Full text available.Received: (at submit) by debbugs.gnu.org; 19 Mar 2021 19:26:49 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Fri Mar 19 15:26:49 2021 Received: from localhost ([127.0.0.1]:51019 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1lNKlk-0002Tp-Ic for submit <at> debbugs.gnu.org; Fri, 19 Mar 2021 15:26:49 -0400 Received: from lists.gnu.org ([209.51.188.17]:54960) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <contact@HIDDEN>) id 1lNKhe-0002NI-Em for submit <at> debbugs.gnu.org; Fri, 19 Mar 2021 15:22:34 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35734) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <contact@HIDDEN>) id 1lNKhd-0000hs-8v for guix-patches@HIDDEN; Fri, 19 Mar 2021 15:22:34 -0400 Received: from mout-p-102.mailbox.org ([80.241.56.152]:26986) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_CHACHA20_POLY1305:256) (Exim 4.90_1) (envelope-from <contact@HIDDEN>) id 1lNKha-0007wl-8C for guix-patches@HIDDEN; Fri, 19 Mar 2021 15:22:32 -0400 Received: from smtp1.mailbox.org (smtp1.mailbox.org [80.241.60.240]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-102.mailbox.org (Postfix) with ESMTPS id 4F2DLC2cbfzQjnP; Fri, 19 Mar 2021 20:22:27 +0100 (CET) X-Virus-Scanned: amavisd-new at heinlein-support.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dhruvin.dev; s=MBO0001; t=1616181745; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=P56YogvuZOTgW7W+EP2W+CxVUNA+uwF2rqdtEQsZlkA=; b=FE9pGzgeNvh5hQhxI+MlSos70dTbTuA6bFgVIEXSXqV2ZWN9xvoKTU0Jth9QjL8WhVsrDW tLGjBhIcGa2H8FNJX/RajOmmewIMThj5ozYE9tBJ00qqqdJD2BqENY3BFJuU/Hdyb4CSY1 vqh+TH05hGb1UEaBJK3yZG4wat0ggl9mbG/cVABJMDppDsutdFBJVbR6JXg2VgBY5RRP7B zQ8tGk0H5afMg+i25MWKm1+zrrRondvCbIPJPP9ZoCDqsfvqBdTe5nq8gr0zL9OPUvWQ+K ugtHdJH704E8d3DSzXa8f2Tn3pr1RC3tSCuw22URanzw8AdGLesKbKNXHCLKaw== Received: from smtp1.mailbox.org ([80.241.60.240]) by spamfilter06.heinlein-hosting.de (spamfilter06.heinlein-hosting.de [80.241.56.125]) (amavisd-new, port 10030) with ESMTP id dh7JK6BTSS6I; Fri, 19 Mar 2021 20:22:24 +0100 (CET) From: Dhruvin Gandhi <contact@HIDDEN> To: guix-patches@HIDDEN Subject: [PATCH 0/1] Add node-global-gradle-clean Date: Sat, 20 Mar 2021 00:51:43 +0530 Message-Id: <20210319192144.17799-1-contact@HIDDEN> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-MBO-SPAM-Probability: X-Rspamd-Score: -4.80 / 15.00 / 15.00 X-Rspamd-Queue-Id: 621748A6 X-Rspamd-UID: 5e2321 Received-SPF: pass client-ip=80.241.56.152; envelope-from=contact@HIDDEN; helo=mout-p-102.mailbox.org X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Fri, 19 Mar 2021 15:26:46 -0400 Cc: Dhruvin Gandhi <contact@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -2.4 (--) I've recently started using Guix System and it has been my daily driver for a month now. Surprisingly, guix already has every package I need. I decided to ask my friends about packages they'll need before they can start using Guix. I will try to submit patches of those packages in coming months. I am new to guix, and am new to contributing code via patches. Let me know if you have any corrections/suggestions. Dhruvin Gandhi (1): Add node-global-gradle-clean gnu/packages/node-xyz.scm | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+) -- 2.31.0
Dhruvin Gandhi <contact@HIDDEN>
:guix-patches@HIDDEN
.
Full text available.guix-patches@HIDDEN
:bug#47269
; Package guix-patches
.
Full text available.
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.