GNU bug report logs - #47316
27.1; commands with color input should use a common color chooser

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 47316 in the body.
You can then email your comments to 47316 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: scame <laszlomail <at> protonmail.com>
To: "bug-gnu-emacs <at> gnu.org" <bug-gnu-emacs <at> gnu.org>
Subject: 27.1;  commands with color input should use a common color chooser
Date: Mon, 22 Mar 2021 11:01:13 +0000

[Message part 1 (text/plain, inline)]

set-foreground-color uses a color chooser: read-color.

customize-face uses something else which looks more readable IMO, though
the usefulness of the underline is debatable:

https://necromuralist.github.io/posts/changing-emacs-font-colors/color_selector.png

Other commands like set-face-foreground, highlight-regexp and others show only
color names, but not the colors themselves.

All color input commands should use a common color selector which shows the
actual colors too.

[Message part 2 (text/html, inline)]

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: scame <laszlomail <at> protonmail.com>, "scame via Bug reports for GNU Emacs,
 the Swiss army knife of text editors" <bug-gnu-emacs <at> gnu.org>,
 47316 <at> debbugs.gnu.org
Subject: Re: bug#47316: 27.1;
 commands with color input should use a common color chooser
Date: Mon, 22 Mar 2021 13:33:57 +0200

On March 22, 2021 1:01:13 PM GMT+02:00, "scame via Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs <at> gnu.org> wrote:
> set-foreground-color uses a color chooser: read-color.
> 
> customize-face uses something else which looks more readable IMO,
> though
> the usefulness of the underline is debatable:
> 
> https://necromuralist.github.io/posts/changing-emacs-font-colors/color_selector.png
> 
> Other commands like set-face-foreground, highlight-regexp and others
> show only
> color names, but not the colors themselves.
> 
> All color input commands should use a common color selector which
> shows the
> actual colors too.

read-color will show you the colors from which you can select if you type '?', the standard Emacs command that requests the list of possible candidate values.

Message #14 received at submit <at> debbugs.gnu.org (full text, mbox):

From: scame <laszlomail <at> protonmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: "scame via Bug reports for GNU Emacs,
 the Swiss army knife of text editors" <bug-gnu-emacs <at> gnu.org>,
 "47316 <at> debbugs.gnu.org" <47316 <at> debbugs.gnu.org>
Subject: Re: bug#47316: 27.1;
 commands with color input should use a common color chooser
Date: Mon, 22 Mar 2021 12:11:56 +0000

> read-color will show you the colors from which you can select if you type '?', the standard Emacs command that requests the list of possible candidate values.

Yes, I mentioned it in my mail:

> > set-foreground-color uses a color chooser: read-color.

But customize use a different implementation, not read-color (at least on 27)
and other commands do not use read-color at all, despite getting color input,
they just list the color names without coloring them.

Other commands which read a face, not a color, show just face names for
completion. Showing face colors and other attributes inline (like in case
of list-faces-display) could be a nice improvement.

Message #20 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: scame <laszlomail <at> protonmail.com>
Cc: bug-gnu-emacs <at> gnu.org, 47316 <at> debbugs.gnu.org
Subject: Re: bug#47316: 27.1;
 commands with color input should use a common color chooser
Date: Mon, 22 Mar 2021 19:42:09 +0200

> Date: Mon, 22 Mar 2021 12:11:56 +0000
> From: scame <laszlomail <at> protonmail.com>
> Cc: "scame via Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs <at> gnu.org>, "47316 <at> debbugs.gnu.org" <47316 <at> debbugs.gnu.org>
> 
> > read-color will show you the colors from which you can select if you type '?', the standard Emacs command that requests the list of possible candidate values.
> 
> Yes, I mentioned it in my mail:
> 
> > > set-foreground-color uses a color chooser: read-color.

The way it was written, together with the rest of the message, could
cause people to interpret that as if read-color didn't display the
colors.  My intent was to point out that it does.

Message #26 received at 47316 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: scame <laszlomail <at> protonmail.com>
Cc: 47316 <at> debbugs.gnu.org
Subject: Re: bug#47316: 27.1;  commands with color input should use a common
 color chooser
Date: Mon, 22 Mar 2021 19:49:57 +0100

scame <laszlomail <at> protonmail.com> writes:

> set-foreground-color uses a color chooser: read-color.
>
> customize-face uses something else which looks more readable IMO, though
> the usefulness of the underline is debatable:
>
> https://necromuralist.github.io/posts/changing-emacs-font-colors/color_selector.png

I think the Customize face interface probably should remain separate...

> Other commands like set-face-foreground, highlight-regexp and others show only
> color names, but not the colors themselves.
>
> All color input commands should use a common color selector which shows the 
> actual colors  too.

I've now fixed set-face-*, but highlight-regexp does not prompt for a
colour name -- it prompts for a face, so it can't use read-color.

Are there any other commands that prompts for colours that doesn't use
read-color?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #31 received at 47316 <at> debbugs.gnu.org (full text, mbox):

From: scame <laszlomail <at> protonmail.com>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: "47316 <at> debbugs.gnu.org" <47316 <at> debbugs.gnu.org>
Subject: Re: bug#47316: 27.1;
 commands with color input should use a common color chooser
Date: Mon, 22 Mar 2021 19:57:59 +0000

>
> I've now fixed set-face-*, but highlight-regexp does not prompt for a
> colour name -- it prompts for a face, so it can't use read-color.
>
> Are there any other commands that prompts for colours that doesn't use
> read-color?

I encountered this problem with the set-face- commands only. Other color
commands seem to use read-color.

Message #34 received at 47316 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: scame <laszlomail <at> protonmail.com>
Cc: "47316 <at> debbugs.gnu.org" <47316 <at> debbugs.gnu.org>
Subject: Re: bug#47316: 27.1;  commands with color input should use a common
 color chooser
Date: Mon, 22 Mar 2021 21:01:49 +0100

scame <laszlomail <at> protonmail.com> writes:

>> I've now fixed set-face-*, but highlight-regexp does not prompt for a
>> colour name -- it prompts for a face, so it can't use read-color.
>>
>> Are there any other commands that prompts for colours that doesn't use
>> read-color?
>
> I encountered this problem with the set-face- commands only. Other color
> commands seem to use read-color.

OK; thanks for checking.  I'm closing this bug report, then.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.